Multiline input for name field in report field does not scroll (V2) by mohammadjafarinejad · Pull Request #81005 · Expensify/App

mohammadjafarinejad · 2026-01-30T13:17:50Z

Explanation of Change

Original PR: #77324

Fixed Issues

$ #76785
PROPOSAL: #76785 (comment)

Tests

Sign in to staging.new.expensify.com
Navigate to Workspace > Workspace settings > Report fields
In the "Name" field, enter a long report format eg. ({report:total} | {report:total:usd} | {report:total:EUR})
Remove the last couple of letters
Verify that either:

A scroll is displayed to show all the input by scrolling down, OR
The user can view the far right by navigating right
Verify TrackDistance, CreateExpense, and other places in the app where we use InputField, and make sure the functionality remains intact.
Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android-web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

web-safari.mp4

web-chrome.mp4

…d does not scroll" This reverts commit efcc003.

melvin-bot · 2026-01-30T13:17:57Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

codecov · 2026-01-30T13:29:11Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...nput/BaseTextInput/implementation/index.native.tsx	`77.72% <100.00%> (+1.05%)`	⬆️
...omponents/TextInput/TextInputMeasurement/index.tsx	`45.45% <ø> (+18.18%)`	⬆️
src/styles/utils/index.ts	`50.50% <100.00%> (+2.18%)`	⬆️
...s/TextInput/BaseTextInput/implementation/index.tsx	`0.00% <0.00%> (ø)`
... and 90 files with indirect coverage changes

…t handling

…tInput components

melvin-bot · 2026-01-31T05:37:21Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/TextInput/BaseTextInput/implementation/index.native.tsx

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7df20112b6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/TextInput/TextInputMeasurement/index.tsx

shawnborton · 2026-02-02T06:54:02Z

Videos look good to me 👍

src/styles/utils/index.ts

joekaufmanexpensify

V2 after revert

huult · 2026-02-03T02:46:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-11.at.10.32.42.mp4

Android: mWeb Chrome

Screen.Recording.2026-02-11.at.10.34.14.mp4

iOS: HybridApp

Screen.Recording.2026-02-11.at.10.40.06.mp4

iOS: mWeb Safari

Screen.Recording.2026-02-11.at.10.41.16.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-02-11.at.10.23.27.mp4

huult · 2026-02-03T03:43:39Z

src/components/TextInput/BaseTextInput/implementation/index.tsx

        !hasLabel && styles.pt0,
        textInputContainerStyles,
-        (autoGrow || !!contentWidth) && StyleUtils.getWidthStyle(textInputWidth + (shouldApplyPaddingToContainer ? styles.textInputContainer.padding * 2 : 0)),
+        (autoGrow || !!contentWidth) && StyleUtils.getWidthStyle(textInputWidth + containerPadding),


@mohammadjafarinejad Is this change only required for web? If yes, could you explain why it’s not needed on native?

On native, the condition to add padding is only !!contentWidth:

App/src/components/TextInput/BaseTextInput/implementation/index.native.tsx

Line 268 in f741465

!!contentWidth && StyleUtils.getWidthStyle(textInputWidth + (shouldApplyPaddingToContainer ? styles.textInputContainer.padding * 2 : 0)),

But in web, if autoGrow is true, we don’t add extra padding because autoGrowMeasurementStyles already includes it. As a result, textInputWidth ends up including the padding automatically.

App/src/components/TextInput/BaseTextInput/implementation/index.tsx

Line 306 in f741465

(autoGrow || !!contentWidth) && StyleUtils.getWidthStyle(textInputWidth + containerPadding),

I could also write a more detailed comment in the code to explain this difference clearly—would that be helpful?

huult · 2026-02-03T03:52:08Z

src/styles/utils/index.ts

+        ...(paddingLeft && {paddingLeft}),
+        ...(paddingRight && {paddingRight}),
+        ...(borderLeftWidth && {borderLeftWidth}),
+        ...(borderRightWidth && {borderRightWidth}),


Suggested change

...(paddingLeft && {paddingLeft}),

...(paddingRight && {paddingRight}),

...(borderLeftWidth && {borderLeftWidth}),

...(borderRightWidth && {borderRightWidth}),

...(paddingLeft !== undefined && {paddingLeft}),

...(paddingRight !== undefined && {paddingRight}),

...(borderLeftWidth !== undefined && {borderLeftWidth}),

...(borderRightWidth !== undefined && {borderRightWidth}),

This function has a bug when the value is 0

I think I wrote it intentionally this way because, as you can see here, sometimes we can have zero padding.

App/src/components/TextInput/BaseTextInput/implementation/index.tsx

Line 303 in f741465

!shouldApplyPaddingToContainer && styles.p0,

If we don’t exclude 0 paddings in autoGrowMeasurementStyles, we could unexpectedly override inputStyle paddings with 0.

App/src/components/TextInput/TextInputMeasurement/index.tsx

Lines 65 to 66 in f741465

inputStyle,

autoGrowMeasurementStyles,

I also noticed that if we change the order, some components pass 0 padding to inputStyle, which would then override autoGrowMeasurementStyles.

autoGrowMeasurementStyles, inputStyle,

So basically, we need autoGrowMeasurementStyles to include all horizontal non-zero paddings to avoid overwriting inputStyle paddings.

Could you please provide reproduction steps for the bug?

huult · 2026-02-10T02:14:59Z

@mohammadjafarinejad Please sync with the main branch.

mohammadjafarinejad · 2026-02-10T03:23:22Z

@huult Done

huult

LGTM

github-actions · 2026-02-11T18:11:15Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-11T18:15:08Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81005.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-aec0e35-e7fd5d7065cf1c6be8fe767bbc6cf1d26bbe6aa0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-aec0e35-86ed1c2dedabf3b5bdf984bc4464f19c84e7496d/index.html

Web 🕸️
https://81005.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-12T15:47:08Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.18-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-13T18:47:58Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.18-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Reapply "Report field - Multiline input for name field in report fiel…

506e9e4

…d does not scroll" This reverts commit efcc003.

melvin-bot bot assigned mohammadjafarinejad Jan 30, 2026

mohammadjafarinejad added 7 commits January 31, 2026 01:35

Add hidden input container styles to match visible input dimensions

6291839

chore: clarify hidden input comment

f6cfacf

fix: prevent whiteSpace from getting stuck on 'nowrap' in Safari inpu…

0462266

…t handling

fix: update hidden input styles for accurate width calculation in Tex…

9b46db4

…tInput components

fix: add style utils to extract hidden input style

5d0c6b6

fix: remove unused hiddenTextInputContainer styles

e975166

chore: disable sentryLabel lint error

7df2011

mohammadjafarinejad marked this pull request as ready for review January 31, 2026 05:37

mohammadjafarinejad requested review from a team as code owners January 31, 2026 05:37

melvin-bot bot requested a review from huult January 31, 2026 05:37

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team January 31, 2026 05:37

mohammadjafarinejad mentioned this pull request Jan 31, 2026

[$250] Report field - Multiline input for name field in report field does not scroll #76785

Closed

16 tasks

github-actions bot reviewed Jan 31, 2026

View reviewed changes

src/components/TextInput/BaseTextInput/implementation/index.native.tsx Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Jan 31, 2026

View reviewed changes

src/components/TextInput/TextInputMeasurement/index.tsx Show resolved Hide resolved

fix: double padding calculation

f741465

shawnborton reviewed Feb 2, 2026

View reviewed changes

src/styles/utils/index.ts Show resolved Hide resolved

joekaufmanexpensify approved these changes Feb 2, 2026

View reviewed changes

huult reviewed Feb 3, 2026

View reviewed changes

Merge branch 'Expensify:main' into fix/76785-v2

ee0441e

huult approved these changes Feb 11, 2026

View reviewed changes

melvin-bot bot requested a review from Julesssss February 11, 2026 03:48

Julesssss approved these changes Feb 11, 2026

View reviewed changes

Julesssss merged commit aec0e35 into Expensify:main Feb 11, 2026
30 checks passed

github-actions bot mentioned this pull request Feb 11, 2026

Investigate workflow job failing on main: lint / ESLint check #82168

Closed

MelvinBot mentioned this pull request Feb 11, 2026

Make empty state buttons hug content when single button #82160

Closed

35 tasks

OSBotify mentioned this pull request Feb 12, 2026

Deploy Checklist: New Expensify 2026-02-12 #82262

Closed

OSBotify mentioned this pull request Feb 13, 2026

[Due for payment 2026-02-24] Web - Chat - Unable to select all text in the composer via CMD+A or double clicking #82465

Closed

7 tasks

Conversation

mohammadjafarinejad commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 30, 2026

Uh oh!

codecov bot commented Jan 30, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Jan 31, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

shawnborton commented Feb 2, 2026

Uh oh!

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

huult commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

mohammadjafarinejad Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

huult Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

mohammadjafarinejad Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

huult commented Feb 10, 2026

Uh oh!

mohammadjafarinejad commented Feb 10, 2026

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

OSBotify commented Feb 12, 2026

Uh oh!

OSBotify commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mohammadjafarinejad commented Jan 30, 2026 •

edited

Loading

codecov bot commented Jan 30, 2026 •

edited by github-actions bot

Loading

huult commented Feb 3, 2026 •

edited

Loading