[No QA] feat: Add sentryLabel for INP debugging across report page components (part 2) by dariusz-biela · Pull Request #77513 · Expensify/App

dariusz-biela · 2025-12-12T15:10:48Z

Explanation of Change

This PR continues adding Sentry INP (Interaction to Next Paint) labels to interactive components on the report page to enable performance monitoring and debugging of user interactions. This is part 2 following PR #77397.

Changes made:

Added SENTRY_LABEL constants in src/CONST/index.ts for the following categories:

REPORT_PREVIEW - card, carousel arrows, submit/approve/pay/export/view/add expense buttons
TRANSACTION_PREVIEW - expense card
EMOJI_PICKER - button, dropdown button, menu item, skin tone toggle/items, category shortcuts, search input
EMOJI_REACTIONS - reaction bubble, add reaction bubble
MINI_CONTEXT_MENU - quick reaction, emoji picker button
TASK - preview card, preview checkbox, view title, view checkbox, view description, view assignee, header action button

Extended component types with optional sentryLabel prop:

AnimatedSubmitButton
BaseMiniContextMenuItem
ButtonWithDropdownMenu and DropdownOption
SettlementButton and AnimatedSettlementButton
ExportWithDropdownMenu
MenuItem
BaseTextInput
TextInputClearButton

Applied labels to interactive elements across report page components:

MoneyRequestReportPreviewContent.tsx - expense report card, carousel navigation, action buttons
TransactionPreview/index.tsx - individual expense cards
EmojiPickerButton.tsx, EmojiPickerButtonDropdown.tsx - emoji picker triggers
EmojiPickerMenuItem (web + native) - emoji items in picker
EmojiSkinToneList.tsx - skin tone selection
CategoryShortcutButton.tsx - emoji category shortcuts
EmojiPickerMenu (web + native) - search input
EmojiReactionBubble.tsx, AddReactionBubble.tsx - message reactions
MiniQuickEmojiReactions.tsx - quick reaction buttons in mini context menu
TaskPreview.tsx - task preview card and checkbox
TaskView.tsx - task title, checkbox, description and assignee menu items
TaskHeaderActionButton.tsx - mark complete/incomplete button

No logic changes

This PR contains no functional changes - only metadata annotations for Sentry performance tracking.

Fixed Issues

$ #76128
PROPOSAL:

Tests

Open any report page in the browser
Open DevTools (F12) and go to the Elements tab
Search for [data-sentry-label] attribute using Ctrl+F / Cmd+F
Verify that interactive elements have appropriate data-sentry-label attributes:
- Expense report preview cards and buttons
- Individual expense cards in carousel
- Emoji picker button and items
- Emoji reactions on messages
- Quick reactions in mini context menu
- Task preview and task view components
Verify that no errors appear in the JS console

Note: This is the second batch of labels for the report page. Additional labels will be added in follow-up PRs.

Verify that no errors appear in the JS console

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Add sentryLabel prop to track user interactions for Sentry INP monitoring: - TaskPreview: card pressable and checkbox - TaskView: title, checkbox, description and assignee menu items - TaskHeaderActionButton: mark complete/incomplete button - MenuItem: add sentryLabel prop support for all menu items

melvin-bot · 2025-12-12T15:10:55Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

codecov · 2025-12-12T15:20:00Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`84.54% <ø> (ø)`
.../components/EmojiPicker/CategoryShortcutButton.tsx	`12.50% <ø> (ø)`
src/components/EmojiPicker/EmojiPickerButton.tsx	`81.81% <ø> (ø)`
...mponents/EmojiPicker/EmojiPickerButtonDropdown.tsx	`0.00% <ø> (ø)`
...s/EmojiPicker/EmojiPickerMenuItem/index.native.tsx	`0.00% <ø> (ø)`
src/components/EmojiPicker/EmojiSkinToneList.tsx	`5.88% <ø> (ø)`
src/components/Reactions/AddReactionBubble.tsx	`3.03% <ø> (ø)`
src/components/Reactions/EmojiReactionBubble.tsx	`5.88% <ø> (ø)`
...c/components/Reactions/MiniQuickEmojiReactions.tsx	`4.00% <ø> (ø)`
...onents/ReportActionItem/ExportWithDropdownMenu.tsx	`0.00% <ø> (ø)`
... and 13 more
... and 12 files with indirect coverage changes

…tton to BaseTextInput

melvin-bot · 2025-12-12T15:24:14Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…page-2 # Conflicts: # src/components/TextInput/TextInputClearButton/index.tsx

DylanDylann · 2025-12-16T03:26:55Z

@rlinoz Does this PR require C+ review?

- Replace deprecated blurOnSubmit with submitBehavior in EmojiPickerMenu - Change namespace import to named imports in EmojiPickerMenuItem

…page-2 # Conflicts: # src/CONST/index.ts # src/components/ButtonWithDropdownMenu/types.ts # src/components/EmojiPicker/EmojiPickerButton.tsx # src/components/TaskHeaderActionButton.tsx

rlinoz · 2025-12-16T12:34:11Z

Hey @DylanDylann I think we are good, just adding sentry labels, thanks!

rlinoz · 2025-12-17T12:36:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

OSBotify · 2025-12-17T13:02:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-18T19:01:47Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.82-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T19:31:10Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.82-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T21:46:01Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.82-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-19T13:18:16Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.84-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-19T23:39:26Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.84-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

dariusz-biela added 3 commits December 12, 2025 14:14

feat: add Sentry labels to report preview components

7359f8b

feat: add Sentry labels to emoji picker and reactions components

01e499d

melvin-bot bot assigned dariusz-biela Dec 12, 2025

refactor(sentry): Move ClearButton suffix logic from TextInputClearBu…

2741896

…tton to BaseTextInput

dariusz-biela marked this pull request as ready for review December 12, 2025 15:24

dariusz-biela requested review from a team as code owners December 12, 2025 15:24

melvin-bot bot requested review from DylanDylann and heyjennahay and removed request for a team and heyjennahay December 12, 2025 15:24

melvin-bot bot removed the request for review from a team December 12, 2025 15:24

dariusz-biela added 2 commits December 12, 2025 16:57

fix: fixes prettier error

3547e1a

Merge branch 'main' into dariusz-biela/perf/sentry/inp-labels-report-…

c96ba3c

…page-2 # Conflicts: # src/components/TextInput/TextInputClearButton/index.tsx

dariusz-biela added 3 commits December 16, 2025 13:21

fix: resolve ESLint errors in EmojiPicker components

3ab4fec

- Replace deprecated blurOnSubmit with submitBehavior in EmojiPickerMenu - Change namespace import to named imports in EmojiPickerMenuItem

Merge branch 'main' into dariusz-biela/perf/sentry/inp-labels-report-…

5ab5bdd

…page-2 # Conflicts: # src/CONST/index.ts # src/components/ButtonWithDropdownMenu/types.ts # src/components/EmojiPicker/EmojiPickerButton.tsx # src/components/TaskHeaderActionButton.tsx

fix: remove duplicate TASK_ACTION_BUTTON constant after merge

63e80a3

rlinoz self-requested a review December 16, 2025 12:33

rlinoz removed the request for review from DylanDylann December 16, 2025 12:34

rlinoz approved these changes Dec 17, 2025

View reviewed changes

rlinoz merged commit fcdbbc3 into Expensify:main Dec 17, 2025
30 of 31 checks passed

OSBotify mentioned this pull request Dec 18, 2025

Deploy Checklist: New Expensify 2025-12-18 #78018

Closed

melvin-bot bot mentioned this pull request Dec 19, 2025

[Sentry] Extending Sentry Analysis to Systematically Reduce High INP Events #76128

Open

adhorodyski mentioned this pull request Feb 19, 2026

[No QA] Add sentryLabel to sign-in and onboarding flows for INP tracking #82917

Merged

52 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] feat: Add sentryLabel for INP debugging across report page components (part 2)#77513

[No QA] feat: Add sentryLabel for INP debugging across report page components (part 2)#77513
rlinoz merged 9 commits intoExpensify:mainfrom
software-mansion-labs:dariusz-biela/perf/sentry/inp-labels-report-page-2

dariusz-biela commented Dec 12, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Dec 12, 2025

Uh oh!

codecov bot commented Dec 12, 2025 •

edited by github-actions bot

Loading

Uh oh!

melvin-bot bot commented Dec 12, 2025

Uh oh!

DylanDylann commented Dec 16, 2025

Uh oh!

rlinoz commented Dec 16, 2025

Uh oh!

rlinoz commented Dec 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

OSBotify commented Dec 17, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dariusz-biela commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Changes made:

No logic changes

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 12, 2025

Uh oh!

codecov bot commented Dec 12, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 12, 2025

Uh oh!

DylanDylann commented Dec 16, 2025

Uh oh!

rlinoz commented Dec 16, 2025

Uh oh!

rlinoz commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Dec 17, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dariusz-biela commented Dec 12, 2025 •

edited

Loading

codecov bot commented Dec 12, 2025 •

edited by github-actions bot

Loading

rlinoz commented Dec 17, 2025 •

edited

Loading