Fix: Report-Expense report thread and reply title is shown as In expense report by annaweber830 · Pull Request #77633 · Expensify/App

annaweber830 · 2025-12-14T08:29:18Z

…space

Explanation of Change

Fixed Issues

$ #76058
PROPOSAL: #76058 (comment)

Tests

Go to https://staging.new.expensify.com/home
Open the 1:1 thread chat from LHN
Note header and chat details
Go to Reports - chat
Scroll down to 1:1 thread chat
Note thread title and message is shown correctly
Go to LHN
Open expense report thread page
Note header and chat details
Go to Reports - chat
Note parent message and reply thread title shows "workspace name" instead of "expense report"
Note the title of expense shown as "In expense report" correctly

Verify that no errors appear in the JS console

Offline tests

Same as Test

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Go to https://staging.new.expensify.com/home
Open the 1:1 thread chat from LHN
Note header and chat details
Go to Reports - chat
Scroll down to 1:1 thread chat
Note thread title and message is shown correctly
Go to LHN
Open expense report thread page
Note header and chat details
Go to Reports - chat
Note parent message and reply thread title shows "workspace name" instead of "expense report"
Note the title of expense shown as "In expense report" correctly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-13.at.7.34.02.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-12-13.at.7.16.36.PM.mp4

iOS: Native

Screen.Recording.2025-12-13.at.11.35.38.PM.mp4

iOS: mWeb Safari

Screen.Recording.2025-12-13.at.11.44.40.PM.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-12-13.at.7.06.03.PM.mp4

…space

melvin-bot · 2025-12-14T08:29:25Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-12-14T08:37:36Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ReportUtils.ts	`71.70% <0.00%> (-0.18%)`	⬇️
... and 11 files with indirect coverage changes

trjExpensify

Yep, I seem to recall we agreed that a thread in an expense report should use the expense report as the subtitle in Reports > Chats.

P.S Can you try to make your PR titles more reflective of what code changes the PR is making / fill out the explanation of changes section? Thanks!

mananjadhav · 2025-12-18T20:34:56Z

Reviewing the code.

mananjadhav · 2025-12-31T07:41:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- x ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

web-expense-report-title.mov

mananjadhav · 2026-01-06T17:52:27Z

Quick bump @grgia on the PR.

src/libs/ReportUtils.ts

grgia · 2026-01-07T11:35:34Z

src/libs/ReportUtils.ts

+        while (currentParent) {
+            // Prevent infinite loops in case of circular references
+            if (visitedReportIDs.has(currentParent.reportID)) {
+                break;


If we break, we still return policy name?

grgia · 2026-01-07T11:36:18Z

src/libs/ReportUtils.ts

+
+        while (currentParent) {
+            // Prevent infinite loops in case of circular references
+            if (visitedReportIDs.has(currentParent.reportID)) {


Can we guarantee this reportID exists?

No, we cannot guarantee reportID exists at runtime, even though TypeScript marks it as required. So I add a guard check logic.

grgia · 2026-01-07T11:37:18Z

src/libs/ReportUtils.ts

@@ -6107,6 +6107,38 @@ function getReportName(
 function getSearchReportName(props: GetReportNameParams): string {
    const {report, policy} = props;
    if (isChatThread(report) && policy?.name) {


Why do we still need this policy?.name check

The check ensures we only use this special traversal logic when we have a valid policy name to return. Without it, we could return undefined instead of letting getReportName() handle the case with its fallbacks.

grgia

Few comments

mananjadhav · 2026-01-13T17:05:43Z

@grgia Is this waiting on something?

annaweber830 · 2026-01-14T08:56:55Z

Hi @trjExpensify , could you please let me know why this hasn’t been merged yet, please?

grgia · 2026-01-14T16:36:52Z

@annaweber830 the performance tests were failing, I reran now but all tests need to pass.

mananjadhav · 2026-01-14T17:43:43Z

@grgia The performance test that is failing seems to be unrelated to the actual code. Also the step at which it fails is "Post Setup Nodejs".

trjExpensify · 2026-01-15T00:36:47Z

Not sure @annaweber830, I approved it before.

grgia · 2026-01-15T16:23:29Z

Please merge main @annaweber830

grgia · 2026-01-15T16:23:47Z

I have reran the tests, so let's see if merging main fixes it

…6058

grgia · 2026-01-15T16:46:35Z

thank you!

OSBotify · 2026-01-15T17:46:15Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.3-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-16T23:15:35Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.3-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Report-Expense report thread and reply title is shown as In work…

1276903

…space

annaweber830 requested review from a team as code owners December 14, 2025 08:29

melvin-bot bot assigned annaweber830 Dec 14, 2025

melvin-bot bot requested review from mananjadhav and trjExpensify and removed request for a team December 14, 2025 08:29

melvin-bot bot removed the request for review from a team December 14, 2025 08:29

fix: prettier error

942b43f

trjExpensify previously approved these changes Dec 15, 2025

View reviewed changes

annaweber830 changed the title ~~Fix: Report-Expense report thread and reply title is shown as In workspace~~ Fix: Report-Expense report thread and reply title is shown as In expense report Dec 15, 2025

mananjadhav approved these changes Dec 31, 2025

View reviewed changes

melvin-bot bot requested a review from grgia December 31, 2025 21:09

grgia reviewed Jan 7, 2026

View reviewed changes

src/libs/ReportUtils.ts Show resolved Hide resolved

grgia reviewed Jan 7, 2026

View reviewed changes

fix: prevent parent report ID

89d874a

annaweber830 dismissed trjExpensify’s stale review via 89d874a January 7, 2026 22:04

grgia approved these changes Jan 8, 2026

View reviewed changes

annaweber830 requested a review from trjExpensify January 14, 2026 08:56

mananjadhav mentioned this pull request Jan 14, 2026

[$250] Report-Expense report thread and reply title is shown as In workspace #76058

Closed

8 tasks

trjExpensify approved these changes Jan 15, 2026

View reviewed changes

Merge branch 'main' of https://github.com/annaweber830/App into fix-7…

b44c2a6

…6058

grgia merged commit bc9184a into Expensify:main Jan 15, 2026
28 checks passed

OSBotify mentioned this pull request Jan 15, 2026

Deploy Checklist: New Expensify 2026-01-15 #79701

Closed

65 tasks

Conversation

annaweber830 commented Dec 14, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 14, 2025

Uh oh!

codecov bot commented Dec 14, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Dec 18, 2025

Uh oh!

mananjadhav commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented Jan 6, 2026

Uh oh!

Uh oh!

grgia Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

annaweber830 Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

grgia Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

annaweber830 Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

grgia Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

annaweber830 Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Jan 13, 2026

Uh oh!

annaweber830 commented Jan 14, 2026

Uh oh!

grgia commented Jan 14, 2026

Uh oh!

mananjadhav commented Jan 14, 2026

Uh oh!

trjExpensify commented Jan 15, 2026

Uh oh!

grgia commented Jan 15, 2026

Uh oh!

grgia commented Jan 15, 2026

Uh oh!

Uh oh!

grgia commented Jan 15, 2026

Uh oh!

OSBotify commented Jan 15, 2026

Uh oh!

OSBotify commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Dec 14, 2025 •

edited by github-actions bot

Loading

mananjadhav commented Dec 31, 2025 •

edited

Loading