Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
a6d2ea9 to
b15c486
Compare
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
246fae2 to
02b2aea
Compare
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Categories - App crashes when deleting categoryVersion Number: v9.2.84-0 PR:77657 Action Performed:
Expected Result:App crash when deleting category Actual Result:Admin should be able to delete an individual category by selecting the Delete option. The category should be removed from the table after deletion. Workaround:Unknown Platforms:
Screenshots/Videos1.mp4 |
Expense - Report loads infinitely after removing expenses from report offlineVersion Number: v9.2.84-0 PR:77657 Action Performed:
Expected Result:Report will not load infinitely after removing expenses from report offline. Actual Result:Report loads infinitely after removing expenses from report offline. Workaround:Unknown Platforms:
Screenshots/Videos1.mp4 |
Expense - Report RHP opens not here page after resolving duplicatesVersion Number: v9.2.84-0 PR:77657 Action Performed:
Expected Result:Report RHP will close. Actual Result:Report RHP opens not here page after resolving duplicates. Workaround:Unknown Platforms:
Screenshots/Videos1.mp4 |
Background changes to Reports after deleting expense and opening another expense on InboxVersion Number: v9.2.84-0 PR:77657 Action Performed:
Expected Result:Background will not change after deleting expense and opening another expense. Actual Result:Background changes to Reports after deleting expense and opening another expense on Inbox. Workaround:Unknown Platforms:
Screenshots/Videos1.mp4 |
Expense - Validate your account RHP and expense report close after clicking RHP back buttonVersion Number: v9.2.84-0 PR:77657 Action Performed:Precondition:
Expected Result:Only Validate your account RHP will close. Actual Result:Both Validate your account RHP and expense report close after clicking back button on Validate your account RHP. Expense report also auto closes after entering magic code on Validate your account RHP. Workaround:Unknown Platforms:
Screenshots/Videos1.mp4 |
Expense - Report with RBR appears in LHN after deleting expense with replyVersion Number: v9.2.84-0 PR:77657 Action Performed:
Expected Result:Report with RBR will not appear in LHN after deleting expense with reply. Actual Result:Report with RBR appears in LHN after deleting expense with reply. The report shows "Auth OpenReport returned an error". Workaround:Unknown Platforms:
Screenshots/Videos1.mp4 |
Reports - RHP opens not here page after deleting expenseVersion Number: v9.2.84-0 PR:77657 Action Performed:
Expected Result:RHP will close after deleting expense. Actual Result:RHP opens not here page after deleting expense. Workaround:Unknown Platforms:
Screenshots/Videos1.mp4 |
Expense - Report loads infinitely after submitting expense offline and returning onlineVersion Number: v9.2.84-0 PR:77657 Action Performed:Precondition:
Expected Result:Report in the background will auto open chat with User B. Actual Result:Report in the background loads infinitely. Workaround:Unknown Platforms:
Screenshots/VideosBug7034823_1766311698511.7.mp4 |
Android - Reports - Wrong navigation on back button after opening report via subtitle linkVersion Number: v9.2.84-0 PR:77657 Action Performed:
Expected Result:App will return to Reports > Reports. Actual Result:App reopens transaction thread. Workaround:Unknown Platforms:
Screenshots/Videos1.mp4 |
Expense - After rejecting expense, all RHPs close, report with RBR appears in LHNVersion Number: v9.2.84-0 PR:77657 Action Performed:
Expected Result:
Actual Result:
Workaround:Unknown Platforms:
Screenshots/Videos1.mp4 |
Expense - After splitting expense, app returns to Reports instead of expense reportVersion Number: v9.2.84-0 PR:77657 Action Performed:
Expected Result:After splitting expense, app will return to expense report. Actual Result:After splitting expense, app returns to Reports. Workaround:Unknown Platforms:
Screenshots/VideosBug7034910_1766331768157.Screen_Recording_20251221_233956_Expensify_Adhoc.mp4 |
Web - BA Onfido - Blank screen appears after accept consent to the identity verificationVersion Number: 9.2.84-0 PR:77657 Action Performed:
Expected Result:User can go to the next screen after accept consent to the identity verification in Onfido flow. Actual Result:Blank screen appears after user accept consent to the identity verification. User cannot complete the Onfido flow. Workaround:Unknown Platforms:
Screenshots/Videos1.mp4 |
I believe this one is not from this PR, it doesn't touch this logic. @jponikarchuk Could you check if it occurs on staging? |
@WojtekBoman It's not reproducible in Staging and we are not able to validate in Prod |
ec1002c to
017e2d6
Compare
Screen.Recording.2025-12-22.at.12.30.29.movThis bug is reproducible on prod cc: @jponikarchuk |
|
@WojtekBoman I'm not able to reproduce in Prod with a new account #77657 (comment) bandicam.2025-12-22.13-41-52-652.mp4 |
Screen.Recording.2025-12-22.at.13.21.34.mov@jponikarchuk it should be reproducible in Reports tab. Now the page from the reports tab is reused in Inbox tab. Solving this issue should resolve the case present on this branch |
|
@WojtekBoman Ok, thanks. I used a new Gmail account with + in Prod, my build is v9.2.84-8 |
mountiny
left a comment
There was a problem hiding this comment.
Looking great, some minor comments, we have done full regression testing here and fixed the issues QA found, I think we can move this ahead and try to resolve the deploy blockers if they come
| const commentRef = useRef(value); | ||
|
|
||
| const {superWideRHPRouteKeys} = useContext(WideRHPContext); | ||
| // Autofocus is disabled on SearchReport when another RHP is displayed below as it causes animation issues |
There was a problem hiding this comment.
| // Autofocus is disabled on SearchReport when another RHP is displayed below as it causes animation issues | |
| // Autofocus is disabled on SearchReport when another RHP is displayed below as it causes animation issues |
| type SearchMoneyRequestPageProps = | ||
| | PlatformStackScreenProps<RightModalNavigatorParamList, typeof SCREENS.RIGHT_MODAL.SEARCH_MONEY_REQUEST_REPORT> | ||
| | PlatformStackScreenProps<RightModalNavigatorParamList, typeof SCREENS.RIGHT_MODAL.EXPENSE_REPORT>; |
| // Fix specific case: https://github.com/Expensify/App/pull/77657#issuecomment-3678696730. | ||
| // When user is editing a money request report (/e/:reportID route) and has | ||
| // an optimistic report in the background that should be replaced with preexisting report | ||
| const isOptimisticReportInBackground = screenName === SCREENS.RIGHT_MODAL.EXPENSE_REPORT && backTo && backTo.includes(`/r/${reportID}`); |
There was a problem hiding this comment.
@rayane-d we are making some changes here to the preexistingReport handling FYI
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
@collectioneur is it a dupe of this one? |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.3-0 🚀
|
|
This PR is failing because of issue ##79708 The issue is reproducible in: Web Bug7050303_1768498764643.4.1.mp4 |
It's a next version of this PR, this one was reverted |
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.3.3-8 🚀
|
Explanation of Change
This PR modifies the way of displaying expense reports:
search/r/:reportID(SCREENS.RIGHT_MODAL.SEARCH_MONEY_REQUEST_REPORT) - this screen is moved from the central screen to the Super Wide RHPe/:reportID(RIGHT_MODAL.EXPENSE_REPORT) - it's a new route displaying expense reports in the Inbox tab.Fixed Issues
$ #71821
PROPOSAL:
Tests
Test 1
Test 2
Test 3
Test 4
Test 5
Test 6
Verify if these bugs don't appear:
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-12.at.15.33.47.mov
Android: mWeb Chrome
Screen.Recording.2026-01-12.at.16.35.33.mov
iOS: Native
Screen.Recording.2026-01-13.at.14.29.20.mov
iOS: mWeb Safari
Screen.Recording.2026-01-13.at.14.36.16.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-13.at.15.23.52.mov