Skip to content

Super wide RHP #77657

Merged
mountiny merged 38 commits intoExpensify:mainfrom
software-mansion-labs:swrhp-v3
Jan 15, 2026
Merged

Super wide RHP #77657
mountiny merged 38 commits intoExpensify:mainfrom
software-mansion-labs:swrhp-v3

Conversation

@collectioneur
Copy link
Contributor

@collectioneur collectioneur commented Dec 15, 2025

Explanation of Change

This PR modifies the way of displaying expense reports:

  • search/r/:reportID (SCREENS.RIGHT_MODAL.SEARCH_MONEY_REQUEST_REPORT) - this screen is moved from the central screen to the Super Wide RHP
  • e/:reportID (RIGHT_MODAL.EXPENSE_REPORT) - it's a new route displaying expense reports in the Inbox tab.

Fixed Issues

$ #71821
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Test 1

  1. Go to the Reports page in the Reports tab.
  2. Click on the report you created.
  3. Verify that it opens as a super wide RHP, no style bugs appear, the overlay works correctly, the backButton returns you back, and there are no other issues.

Test 2

  1. Add two more reports: one empty, and one containing a single expense.
  2. Go to the Reports page in the Reports tab.
  3. Click on any report.
  4. Switch between the reports you created using the arrows in the top-right corner.
  5. Verify that:
  • the report with one transaction displays as a wide RHP,
  • the empty report also displays as a wide RHP (but without a receipt),
  • when switching between reports, all styles update correctly,
  • and the RHP sizes change depending on the number of transactions (0, 1, >1).

Test 3

  1. Go to the Reports page in the Reports tab.
  2. Open a report with more than one transaction.
  3. Click on one of the expenses.
  4. Verify that a wide RHP opens and overlays are displayed correctly.
  5. Close the wide RHP by clicking on the overlay or using the backButton.
  6. Verify that the wide RHP closed correctly, the overlay disappeared, and the UI returned to the super wide RHP.

Test 4

  1. Go to the Inbox page and find a report with multiple expenses.
  2. Click on it.
  3. Verify that the SWRHP opens, nothing is broken, and everything functions correctly.

Test 5

  1. Go to the Reports page in the Reports tab.
  2. Open a report with more than one transaction.
  3. Click on one of the expenses.
  4. Click the More button in the wide RHP and choose an option that opens an RHP (e.g., Info).
  5. Verify that the RHP opened correctly, overlays reflect the proper structure, and nothing is broken.

Test 6

  1. Go to the Reports page in the Reports tab.
  2. Open a report with more than one transaction.
  3. Click on one of the expenses.
  4. Click the link below the wide RHP title that leads back to the parent report.
  5. Verify that the wide RHP correctly returns back to the parent super wide RHP.

Verify if these bugs don't appear:

Offline tests

QA Steps

Same as tests

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-01-12.at.15.33.47.mov
Android: mWeb Chrome
Screen.Recording.2026-01-12.at.16.35.33.mov
iOS: Native
Screen.Recording.2026-01-13.at.14.29.20.mov
iOS: mWeb Safari
Screen.Recording.2026-01-13.at.14.36.16.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-13.at.15.23.52.mov

@codecov
Copy link

codecov bot commented Dec 15, 2025

@github-actions
Copy link
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #77657.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/77657/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/77657/index.html
Android iOS
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://77657.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@mountiny
Copy link
Contributor

@github-actions
Copy link
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #77657.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/77657/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/77657/index.html
Android iOS
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://77657.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@jponikarchuk
Copy link

jponikarchuk commented Dec 21, 2025

Categories - App crashes when deleting category


Version Number: v9.2.84-0 PR:77657
Reproducible in staging?: Yes
Reproducible in production?: No
Device used: Mac 15.4.1 Safari/Chrome

Action Performed:

  1. Navigate to https://77657.pr-testing.expensify.com
  2. Navigate to the workspace settings of the collect policy
  3. Click on a category
  4. Click on delete
  5. Repeat step 3-4 if necessary

Expected Result:

App crash when deleting category

Actual Result:

Admin should be able to delete an individual category by selecting the Delete option. The category should be removed from the table after deletion.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

logs.txt

@jponikarchuk
Copy link

Expense - Report loads infinitely after removing expenses from report offline


Version Number: v9.2.84-0 PR:77657
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): dsoinjdoinsjojdio@gmail.com
Device used: Mac 26.1 / Chrome

Action Performed:

  1. Go to 77657.pr-testing.expensify.com/
  2. Go to workspace chat.
  3. Create two expenses.
  4. Open the expense report.
  5. Go offline.
  6. Select all expenses via checkbox.
  7. Click dropdown button > Move expenses.
  8. Click Remove from report.

Expected Result:

Report will not load infinitely after removing expenses from report offline.

Actual Result:

Report loads infinitely after removing expenses from report offline.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

@jponikarchuk
Copy link

Expense - Report RHP opens not here page after resolving duplicates


Version Number: v9.2.84-0 PR:77657
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): dsoinjdoinsjojdio@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.1 / Chrome

Action Performed:

  1. Go to 77657.pr-testing.expensify.com/
  2. Go to workspace chat.
  3. Create two expenses with the same amount in two different reports.
  4. Open the second report.
  5. Click Review duplicates.
  6. Click Keep this one on the second expense.
  7. Reach the confirm page.
  8. Click Confirm.

Expected Result:

Report RHP will close.

Actual Result:

Report RHP opens not here page after resolving duplicates.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

@jponikarchuk
Copy link

Background changes to Reports after deleting expense and opening another expense on Inbox


Version Number: v9.2.84-0 PR:77657
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): jsnoidjsodidjojso@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.1 / Chrome

Action Performed:

  1. Go to 77657.pr-testing.expensify.com
  2. Go to workspace chat.
  3. Create three expenses.
  4. Open the expense report.
  5. Open any expense.
  6. Click on the header > Delete expense > Delete.
  7. Open another expense.

Expected Result:

Background will not change after deleting expense and opening another expense.

Actual Result:

Background changes to Reports after deleting expense and opening another expense on Inbox.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

@jponikarchuk
Copy link

Expense - Validate your account RHP and expense report close after clicking RHP back button


Version Number: v9.2.84-0 PR:77657
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): jsnoidjsodidjojso@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.1 / Chrome

Action Performed:

Precondition:

  • Account is not verified.
  1. Go to 77657.pr-testing.expensify.com/
  2. Go to workspace chat.
  3. Create an expense.
  4. Open the expense report.
  5. Click Submit and Approve.
  6. Click Mark as paid.
  7. Click back button on Validate your account RHP.

Expected Result:

Only Validate your account RHP will close.

Actual Result:

Both Validate your account RHP and expense report close after clicking back button on Validate your account RHP.

Expense report also auto closes after entering magic code on Validate your account RHP.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

@jponikarchuk
Copy link

Expense - Report with RBR appears in LHN after deleting expense with reply


Version Number: v9.2.84-0 PR:77657
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): dsoinjdoinsjojdio@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.1 / Chrome

Action Performed:

  1. Go to 77657.pr-testing.expensify.com
  2. Go to 1:1 DM with any user.
  3. Create an expense.
  4. Open the report.
  5. Send a message.
  6. Wait for expense report to appear in LHN.
  7. Click More > Delete > Delete the expense.
  8. Repeat Step 3 to 7.
  9. Open report with RBR on LHN.

Expected Result:

Report with RBR will not appear in LHN after deleting expense with reply.

Actual Result:

Report with RBR appears in LHN after deleting expense with reply. The report shows "Auth OpenReport returned an error".

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

@jponikarchuk
Copy link

Reports - RHP opens not here page after deleting expense


Version Number: v9.2.84-0 PR:77657
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): dsoinjdoinsjojdio@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.1 / Chrome

Action Performed:

  1. Go to 77657.pr-testing.expensify.com
  2. Go to workspace chat.
  3. Create an expense.
  4. Go to Reports > Reports.
  5. Open the expense report.
  6. Click on the header > Delete expense.
  7. Delete the expense.

Expected Result:

RHP will close after deleting expense.

Actual Result:

RHP opens not here page after deleting expense.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

@mitarachim
Copy link

mitarachim commented Dec 21, 2025

Expense - Report loads infinitely after submitting expense offline and returning online


Version Number: v9.2.84-0 PR:77657
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): sdjodsjonsjoinjsdod@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.1 / Chrome

Action Performed:

Precondition:

  • User A and User B have never chatted before.
  1. Go to 77657.pr-testing.expensify.com
  2. [User A] Go offline.
  3. [User A] Submit an expense to User B.
  4. [User A] Open the expense report.
    5, [User B] Submit an expense to User A.
  5. [User A] With expense report opened, go online.
  6. [User A] Close the report RHP.

Expected Result:

Report in the background will auto open chat with User B.

Actual Result:

Report in the background loads infinitely.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7034823_1766311698511.7.mp4

@jponikarchuk
Copy link

Android - Reports - Wrong navigation on back button after opening report via subtitle link


Version Number: v9.2.84-0 PR:77657
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): dsoinjdoinsjojdio@gmail.com
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy S25 FE / Android 16

Action Performed:

  1. Launch adhoc app.
  2. Go to workspace chat.
  3. Create two expenses.
  4. Go to Reports > Reports.
  5. Open the report.
  6. Open any expense.
  7. Tap on the report header subtitle.
  8. Tap app back button.

Expected Result:

App will return to Reports > Reports.

Actual Result:

App reopens transaction thread.
App only returns to Reports > Reports after tapping app back buton two more times.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

@jponikarchuk
Copy link

Expense - After rejecting expense, all RHPs close, report with RBR appears in LHN


Version Number: v9.2.84-0 PR:77657
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): sjdiojsonjosjdsondsj@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.1 / Chrome

Action Performed:

  1. Go to 77657.pr-testing.expensify.com
  2. Go to workspace chat.
  3. Create two expenses.
  4. Open the expense report.
  5. Click Submit.
  6. Open any expense.
  7. Click More > Reject.
  8. Enter reason and click Reject expense.

Expected Result:

  • After rejecting expense, expense report RHP will remain open. Only transaction thread RHP will close.
  • There will be no report with RBR after rejecting expense.

Actual Result:

  • After rejecting expense, both expense report RHP and transaction thread RHP close.
  • Report with RBR appears in LHN after rejecting expense, which shows "Unexpected error creating this chat. Please try again later." when opened.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

@jponikarchuk
Copy link

jponikarchuk commented Dec 21, 2025

Expense - After splitting expense, app returns to Reports instead of expense report


Version Number: v9.2.84-0 PR:77657
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): sjdiojsonjosjdsondsj@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.1 / Chrome

Action Performed:

  1. Launch adhoc app.
  2. Go to workspace chat.
  3. Create two expenses.
  4. Go to Reports > Reports.
  5. Open the expense report.
  6. Open any expense.
  7. Tap More > Split.
  8. Tap Save.

Expected Result:

After splitting expense, app will return to expense report.

Actual Result:

After splitting expense, app returns to Reports.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7034910_1766331768157.Screen_Recording_20251221_233956_Expensify_Adhoc.mp4

@jponikarchuk
Copy link

Web - BA Onfido - Blank screen appears after accept consent to the identity verification


Version Number: 9.2.84-0 PR:77657
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): applausetester+122025dr05@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: MacOS 26.2 / Safari, Chrome. MacOS 14.7.4 / Safari, Chrome

Action Performed:

  1. Open https://77657.pr-testing.expensify.com
  2. Login with new expensifail account
  3. Create new workspace
  4. Go to Workspace > Workflow > Payments > Add Bank Account
  5. Select Login with Plaid > Regions bank
  6. Follow the Onfido flow until first Onfido screen appears > Verify Identity consent
  7. Accept Consent to process biometric data

Expected Result:

User can go to the next screen after accept consent to the identity verification in Onfido flow.

Actual Result:

Blank screen appears after user accept consent to the identity verification. User cannot complete the Onfido flow.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

@WojtekBoman
Copy link
Contributor

Web - BA Onfido - Blank screen appears after accept consent to the identity verification

Version Number: 9.2.84-0 PR:77657 Reproducible in staging?: Yes Reproducible in production?: No Email or phone of affected tester (no customers): applausetester+122025dr05@applause.expensifail.com Issue reported by: Applause Internal Team Device used: MacOS 26.2 / Safari, Chrome. MacOS 14.7.4 / Safari, Chrome

Action Performed:

  1. Open https://77657.pr-testing.expensify.com
  2. Login with new expensifail account
  3. Create new workspace
  4. Go to Workspace > Workflow > Payments > Add Bank Account
  5. Select Login with Plaid > Regions bank
  6. Follow the Onfido flow until first Onfido screen appears > Verify Identity consent
  7. Accept Consent to process biometric data

Expected Result:

User can go to the next screen after accept consent to the identity verification in Onfido flow.

Actual Result:

Blank screen appears after user accept consent to the identity verification. User cannot complete the Onfido flow.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

I believe this one is not from this PR, it doesn't touch this logic. @jponikarchuk Could you check if it occurs on staging?

@jponikarchuk
Copy link

jponikarchuk commented Dec 22, 2025

I believe this one is not from this PR, it doesn't touch this logic. @jponikarchuk Could you check if it occurs on staging?

@WojtekBoman It's not reproducible in Staging and we are not able to validate in Prod

@WojtekBoman
Copy link
Contributor

WojtekBoman commented Dec 22, 2025

Screen.Recording.2025-12-22.at.12.30.29.mov

This bug is reproducible on prod cc: @jponikarchuk
#77657 (comment)

@jponikarchuk
Copy link

@WojtekBoman I'm not able to reproduce in Prod with a new account #77657 (comment)

bandicam.2025-12-22.13-41-52-652.mp4

@WojtekBoman
Copy link
Contributor

Screen.Recording.2025-12-22.at.13.21.34.mov

@jponikarchuk it should be reproducible in Reports tab. Now the page from the reports tab is reused in Inbox tab. Solving this issue should resolve the case present on this branch

@jponikarchuk
Copy link

@WojtekBoman Ok, thanks. I used a new Gmail account with + in Prod, my build is v9.2.84-8

Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, some minor comments, we have done full regression testing here and fixed the issues QA found, I think we can move this ahead and try to resolve the deploy blockers if they come

const commentRef = useRef(value);

const {superWideRHPRouteKeys} = useContext(WideRHPContext);
// Autofocus is disabled on SearchReport when another RHP is displayed below as it causes animation issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Autofocus is disabled on SearchReport when another RHP is displayed below as it causes animation issues
// Autofocus is disabled on SearchReport when another RHP is displayed below as it causes animation issues

Comment on lines +45 to +47
type SearchMoneyRequestPageProps =
| PlatformStackScreenProps<RightModalNavigatorParamList, typeof SCREENS.RIGHT_MODAL.SEARCH_MONEY_REQUEST_REPORT>
| PlatformStackScreenProps<RightModalNavigatorParamList, typeof SCREENS.RIGHT_MODAL.EXPENSE_REPORT>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WojtekBoman did you handle this comment?

// Fix specific case: https://github.com/Expensify/App/pull/77657#issuecomment-3678696730.
// When user is editing a money request report (/e/:reportID route) and has
// an optimistic report in the background that should be replaced with preexisting report
const isOptimisticReportInBackground = screenName === SCREENS.RIGHT_MODAL.EXPENSE_REPORT && backTo && backTo.includes(`/r/${reportID}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rayane-d we are making some changes here to the preexistingReport handling FYI

@melvin-bot melvin-bot bot requested a review from mountiny January 15, 2026 11:58
@mountiny mountiny merged commit d4be46d into Expensify:main Jan 15, 2026
62 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@IuliiaHerets
Copy link

@collectioneur is it a dupe of this one?

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.3-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@lanitochka17
Copy link

This PR is failing because of issue ##79708

The issue is reproducible in: Web

Bug7050303_1768498764643.4.1.mp4

@WojtekBoman
Copy link
Contributor

@collectioneur is it a dupe of this one?

It's a next version of this PR, this one was reverted

@m-natarajan
Copy link

This PR is failing with #79708, #79712 #79732

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.3-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.