[No QA] feat: Add sentryLabel for INP debugging across report page components (part 3) by dariusz-biela · Pull Request #77755 · Expensify/App

dariusz-biela · 2025-12-16T12:42:58Z

Explanation of Change

This PR continues adding Sentry INP (Interaction to Next Paint) labels to interactive components on the report page to enable performance monitoring and debugging of user interactions. This is part 3 following PR #77397 (part 2).

Changes made:

Added SENTRY_LABEL constants in src/CONST/index.ts for the following categories:

NAVIGATION_TAB_BAR (extended) - floating action button, floating receipt button
FAB_MENU - create expense, track distance, create report, start chat, send invoice, book travel, test drive, new workspace, quick action
ATTACHMENT_CAROUSEL - previous/next buttons, item, moderation button, retry button
ATTACHMENT_MODAL - send button, image zoom
HEADER - back button, download button, close button
VIDEO_PLAYER - play/pause, fullscreen, more, expand, thumbnail, mute, video
HTML_RENDERER - image
RECEIPT - image

Extended component types with optional sentryLabel prop:

FloatingActionButton
FloatingReceiptButton
VideoPlayer/IconButton

Applied labels to interactive elements across report page components:

FloatingActionButton.tsx - main FAB button
FloatingReceiptButton.tsx - receipt scanning button
FloatingActionButtonAndPopover.tsx - FAB menu items (create expense, track distance, create report, start chat, send invoice, book travel, test drive, new workspace, quick action)
CarouselButtons.tsx - previous/next navigation buttons in attachment carousel
CarouselItem.tsx - individual attachment items
AttachmentViewImage/index.tsx - moderation button on images
AttachmentView/index.tsx - retry button for failed attachments
AttachmentModalBaseContent/index.tsx - send button in attachment modal
ImageView/index.tsx - image zoom functionality
HeaderWithBackButton/index.tsx - back, download, and close buttons
BaseVideoPlayer.tsx - video element
VideoPlayerControls/index.tsx - play/pause, expand, fullscreen buttons
VideoPlayerControls/VolumeButton/index.tsx - mute/volume button
VideoPlayer/IconButton.tsx - generic video player icon buttons
VideoPlayerThumbnail.tsx - video thumbnail
VideoPlayerPreview/index.tsx - video preview
ImageRenderer.tsx - images rendered in HTML content
ReportActionItemImage.tsx - receipt images in report actions

No logic changes

This PR contains no functional changes - only metadata annotations for Sentry performance tracking.

Fixed Issues

$ #76128
PROPOSAL:

Tests

Open any report page in the browser
Open DevTools (F12) and go to the Elements tab
Search for [data-sentry-label] attribute using Ctrl+F / Cmd+F
Verify that interactive elements have appropriate data-sentry-label attributes:
- Floating action button (FAB) at bottom right
- FAB menu items when FAB is expanded
- Floating receipt button
- Attachment carousel navigation buttons
- Images and attachments in reports
- Video player controls
- Header buttons (back, download, close)
Verify that no errors appear in the JS console

Note: This is the third batch of labels for the report page. Additional labels will be added in follow-up PRs.

Verify that no errors appear in the JS console

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

FloatingActionButtons

Attachment in chat

Attachment modal

…page-3 # Conflicts: # src/components/FloatingActionButton.tsx # src/components/FloatingReceiptButton.tsx # src/components/MenuItem.tsx

codecov · 2025-12-16T12:54:34Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`84.54% <ø> (ø)`
...Attachments/AttachmentCarousel/CarouselButtons.tsx	`60.00% <ø> (ø)`
...ts/Attachments/AttachmentCarousel/CarouselItem.tsx	`88.23% <ø> (ø)`
...ments/AttachmentView/AttachmentViewImage/index.tsx	`80.00% <ø> (ø)`
...rc/components/Attachments/AttachmentView/index.tsx	`50.00% <ø> (ø)`
src/components/BaseMiniContextMenuItem.tsx	`0.00% <ø> (ø)`
src/components/Button/index.tsx	`89.92% <ø> (ø)`
src/components/Checkbox.tsx	`88.46% <ø> (ø)`
src/components/ContextMenuItem.tsx	`0.00% <ø> (ø)`
src/components/FloatingActionButton.tsx	`93.75% <ø> (ø)`
... and 17 more
... and 44 files with indirect coverage changes

melvin-bot · 2025-12-16T15:36:34Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-12-16T15:36:40Z

@abdulrahuman5196 @rlinoz One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

huult · 2025-12-16T15:46:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Floating action button (FAB) at bottom right

FAB menu items when FAB is expanded

Floating receipt button

Attachment carousel navigation buttons

Images and attachments in reports

Video player controls

Header buttons (back, download, close)

huult · 2025-12-16T16:32:24Z

Header buttons (back, download, close)

@dariusz-biela May I ask whether we have added data-sentry-label to the receipt attachment’s three-dots icon and the download icon?

The PDF file in the attachment modal doesn’t have a data-sentry-label

dariusz-biela · 2025-12-17T10:59:26Z

May I ask whether we have added data-sentry-label to the receipt attachment’s three-dots icon and the download icon?

Glad you found it. I honestly didn't notice it was a different modal than Attachments. I'll add a commit to add those sentryLabels.

The PDF file in the attachment modal doesn’t have a data-sentry-label

This was a conscious decision. Currently, the PDF in attachment modal doesn't have a Pressable component. The click action is solely a result of the PDF display library implementation. Therefore, I decided to omit it for now.

I might come back to this someday, but for now we wanted to form a general opinion about this solution, so we wanted to cover the most significant actions on the report page, in a relatively simple way (that's why we focused on Pressable).

dariusz-biela · 2025-12-17T11:31:43Z

I added data-sentry-label to Receipt modal:

…page-3

dariusz-biela · 2025-12-17T11:55:21Z

The Eslint React Compiler throws errors that files already being compiled contain useMemo, useCallback, and React.memo.

I haven't changed any logic in them, so I wouldn't want to refactor this PR, as it affects seven files and would dilute the main purpose of this PR.

rlinoz · 2025-12-17T12:04:49Z

I think we are good here, just not sure if the react compiler failure will fail in main too, let me check.

huult · 2025-12-17T12:05:59Z

@dariusz-biela please resolve conflict

…page-3 # Conflicts: # src/pages/media/AttachmentModalScreen/AttachmentModalBaseContent/index.tsx

huult

LGTM

Create a reusable WithSentryLabel type in src/types/utils/SentryLabel.ts and update all component types to use it via intersection instead of defining sentryLabel?: string inline. Updated files: - GenericPressable/types.ts - Button/index.tsx - MenuItem.tsx - Checkbox.tsx - FloatingActionButton.tsx - FloatingReceiptButton.tsx - ContextMenuItem.tsx - BaseMiniContextMenuItem.tsx - ThreeDotsMenu/types.ts - ButtonWithDropdownMenu/types.ts - VideoPlayer/IconButton.tsx - ContextMenuActions.tsx

rlinoz

Thanks!

melvin-bot · 2025-12-17T15:58:59Z

@rlinoz looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

rlinoz · 2025-12-17T15:59:23Z

No emergency, but the check is new and is being discussed here https://expensify.slack.com/archives/C08CZDJFJ77/p1765984171175009?thread_ts=1765912376.034269&cid=C08CZDJFJ77

Also, this PR didn't add any new components and it doesn't make much sense to tackle those changes here.

OSBotify · 2025-12-17T16:08:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-18T19:02:14Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.82-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T19:31:37Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.82-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T21:46:28Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.82-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-19T13:18:43Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.84-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-19T23:39:53Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.84-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

dariusz-biela added 3 commits December 12, 2025 16:55

feat: add sentryLabel to FloatingActionButton and FloatingReceiptButton

5b80f80

eat: add sentryLabel to MenuItem and FAB menu items

86e138f

feat: add sentryLabel to attachment, video player and header components

c8a47f3

melvin-bot bot assigned dariusz-biela Dec 16, 2025

Merge branch 'main' into dariusz-biela/perf/sentry/inp-labels-report-…

f91fffb

…page-3 # Conflicts: # src/components/FloatingActionButton.tsx # src/components/FloatingReceiptButton.tsx # src/components/MenuItem.tsx

dariusz-biela added 2 commits December 16, 2025 14:02

fix: replace deprecated runOnJS with scheduleOnRN in BaseVideoPlayer

4d096fc

fix: fix eslint error @typescript-eslint/no-unused-vars

58a8dc5

dariusz-biela marked this pull request as ready for review December 16, 2025 15:36

dariusz-biela requested review from a team as code owners December 16, 2025 15:36

melvin-bot bot requested review from a team, huult and joekaufmanexpensify and removed request for a team December 16, 2025 15:36

melvin-bot bot requested review from abdulrahuman5196 and rlinoz and removed request for a team December 16, 2025 15:36

feat: add Sentry labels to Receipt Modal header

895b2bc

Merge branch 'main' into dariusz-biela/perf/sentry/inp-labels-report-…

5e1df3c

…page-3

rlinoz removed the request for review from abdulrahuman5196 December 17, 2025 12:04

rlinoz previously approved these changes Dec 17, 2025

View reviewed changes

Merge branch 'main' into dariusz-biela/perf/sentry/inp-labels-report-…

fdc717e

…page-3 # Conflicts: # src/pages/media/AttachmentModalScreen/AttachmentModalBaseContent/index.tsx

dariusz-biela dismissed rlinoz’s stale review via fdc717e December 17, 2025 12:28

huult approved these changes Dec 17, 2025

View reviewed changes

melvin-bot bot requested a review from rlinoz December 17, 2025 12:31

dariusz-biela added 2 commits December 17, 2025 15:06

refactor: fix prettier errors

fc1d833

rlinoz approved these changes Dec 17, 2025

View reviewed changes

rlinoz merged commit c7fd0e4 into Expensify:main Dec 17, 2025
29 of 30 checks passed

melvin-bot bot added the Emergency label Dec 17, 2025

rlinoz removed the Emergency label Dec 17, 2025

OSBotify mentioned this pull request Dec 18, 2025

Deploy Checklist: New Expensify 2025-12-18 #78018

Closed

melvin-bot bot mentioned this pull request Dec 19, 2025

[Sentry] Extending Sentry Analysis to Systematically Reduce High INP Events #76128

Open

adhorodyski mentioned this pull request Feb 19, 2026

[No QA] Add sentryLabel to sign-in and onboarding flows for INP tracking #82917

Merged

52 tasks

Conversation

dariusz-biela commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Changes made:

No logic changes

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

FloatingActionButtons

Attachment in chat

Attachment modal

Uh oh!

codecov bot commented Dec 16, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 16, 2025

Uh oh!

melvin-bot bot commented Dec 16, 2025

Uh oh!

huult commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dariusz-biela commented Dec 17, 2025

Uh oh!

dariusz-biela commented Dec 17, 2025

Uh oh!

dariusz-biela commented Dec 17, 2025

Uh oh!

rlinoz commented Dec 17, 2025

Uh oh!

huult commented Dec 17, 2025

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

rlinoz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot bot commented Dec 17, 2025

Uh oh!

rlinoz commented Dec 17, 2025

Uh oh!

OSBotify commented Dec 17, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

OSBotify commented Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dariusz-biela commented Dec 16, 2025 •

edited

Loading

codecov bot commented Dec 16, 2025 •

edited by github-actions bot

Loading

huult commented Dec 16, 2025 •

edited

Loading

huult commented Dec 16, 2025 •

edited

Loading