seprate subtitle from title by Nodebrute · Pull Request #77914 · Expensify/App

Nodebrute · 2025-12-17T17:04:49Z

Explanation of Change

Fixed Issues

$ #76669
PROPOSAL: #76669 (comment)

Tests

Go to workspace chat
Create an expense
Click on newly created expense
Click on header
Verify the following design (title and form field)

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Go to workspace chat
Create an expense
Click on newly created expense
Click on header
Verify the following design (title and form field)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

editable version

Android: mWeb Chrome

iOS: Native

non-editable version

editable version

iOS: mWeb Safari

non-editable version

editable version

MacOS: Chrome / Safari

editable version

**non-editable version**

melvin-bot · 2025-12-17T17:04:56Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Nodebrute · 2025-12-17T17:05:46Z

Will add the android and mweb screenshots shortly.

Nodebrute · 2025-12-17T17:23:09Z

@Pujan92 I was running into an issue with long subtitles wrapping into two lines.

After removing subtitleNumberOfLines={2}, the layout now looks like this. Can you confirm the expected behavior?

codecov · 2025-12-17T17:27:59Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/ParentNavigationSubtitle.tsx	`80.55% <100.00%> (+3.88%)`	⬆️
src/pages/ReportDetailsPage.tsx	`57.30% <85.71%> (+0.20%)`	⬆️
... and 10 files with indirect coverage changes

joekaufmanexpensify

Change makes sense 👍

Pujan92 · 2025-12-22T13:43:38Z

I think keeping it in a single line was the earlier behavior. In this PR, it is updated to 2 lines.

Let's confirm the doubt with @Expensify/design team.

Pujan92 · 2025-12-24T11:59:14Z

@dannymcclain can you plz help with comment

dubielzyk-expensify · 2025-12-26T12:05:29Z

I think we'd probably don't want it going to two lines so truncation is fine, no strong feelings though. We have to truncate at some point so we can also do it after two lines

The text in this PR doesn't match the mock though. The font size should be the same as the Report ID and the like. It's smaller at the moment:

dubielzyk-expensify · 2025-12-26T12:06:30Z

On second thought maybe given the long emails and potentially long Workspace names it makes more sense two truncate after two lines

Nodebrute · 2025-12-29T08:42:32Z

Sorry, this got delayed due to the holidays. I’ll update today.

Nodebrute · 2025-12-30T18:08:44Z

@Pujan92 I have updated the code according to the design.

Pujan92 · 2026-01-03T12:02:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Nodebrute · 2026-01-08T18:11:46Z

@Pujan92 pr is ready for review.

Pujan92 · 2026-01-10T13:28:56Z

src/pages/ReportDetailsPage.tsx

-                            textStyles={[styles.textAlignCenter]}
                            subtitleNumberOfLines={2}
+                            shouldShowFrom={false}
+                            textStyles={parentNavigationSubtitleTextStyle}


Suggested change

textStyles={parentNavigationSubtitleTextStyle}

textStyles={parentNavigationSubtitleTextStyle}

descriptionTextStyle={[styles.mutedNormalTextLabel, styles.mb1]}

We need to set descriptionTextStyle to make it consistent with other description labels.

Pujan92 · 2026-01-10T14:08:23Z

src/pages/ReportDetailsPage.tsx

+                    shouldShowRightIcon={false}
+                    interactive={false}
+                    titleComponent={nameSectionFurtherDetailsContent}
+                    description={translate('common.from')}


Suggested change

description={translate('common.from')}

description={translate('common.from')}

descriptionTextStyle={[styles.mutedNormalTextLabel, styles.mb1]}

Pujan92 · 2026-01-10T14:09:51Z

@Nodebrute Also needs to resolve conflicts.

Pujan92 · 2026-01-10T14:11:12Z

Someone plz trigger the build so @dannymcclain and @dubielzyk-expensify can also verify it

github-actions · 2026-01-12T02:42:43Z

🚧 @dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-12T03:16:12Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #77914.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8f7c0817336422376eccda4eac48fd87d31eaf31/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-2fc2bf8011abee1666b4b6aced795c84d2e09949/index.html

Web 🕸️
https://77914.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dubielzyk-expensify · 2026-01-12T03:58:16Z

It looks good for me on an expense and report:

But I'd expect to see the same for a room maybe!?:

And then I get this weird left + centered thing on my expense room:

cc @dannymcclain for thoughts on the above

dannymcclain · 2026-01-12T14:46:28Z

It looks good for me on an expense and report:

Same! 👍

But I'd expect to see the same for a room maybe!?:

I don't think I feel as strongly about this one because there's nothing for you to click on or interact with—though I'm not against separating it out as well. I'd probably do it like this though if we're going to change that:

Room name
#purrfect >

Workspace
Expensify Chat

And then I get this weird left + centered thing on my expense room:

I didn't come across this, but let's make sure we address it!

Nodebrute · 2026-01-12T19:33:09Z

Working on it, will update soon

dubielzyk-expensify · 2026-01-13T01:38:15Z

I don't think I feel as strongly about this one because there's nothing for you to click on or interact with—though I'm not against separating it out as well. I'd probably do it like this though if we're going to change that:

That makes sense. Happy to proceed with what you're suggesting 👍

Nodebrute · 2026-01-15T16:23:10Z

@Pujan92 conflicts resolved.

Pujan92 · 2026-01-23T13:21:30Z

But I'd expect to see the same for a room maybe!?:

I don't think I feel as strongly about this one because there's nothing for you to click on or interact with—though I'm not against separating it out as well. I'd probably do it like this though if we're going to change that:

Room name
#purrfect >
Workspace
Expensify Chat

Just to highlight, currently we are rendering a common component for non-expense reports(eg. workspace room, invoices) and also alignment is specific to scenarios. To confirm, Do we need to make this format update for workspace room name?

And then I get this weird left + centered thing on my expense room:

I didn't come across this, but let's make sure we address it!

@dannymcclain Can you help to create this expense room, I thought we only have workspace room and there I didn't able to see this issue?

dannymcclain · 2026-01-24T17:24:30Z

@Expensify/design what do you think? Should we just make this change everywhere? Feels like that would ultimately probably be the right choice, but want to double-check.

@dannymcclain Can you help to create this expense room, I thought we only have workspace room and there I didn't able to see this issue?

I can't repro the issue Jon was having.

dubielzyk-expensify · 2026-01-25T23:32:08Z

@Expensify/design what do you think? Should we just make this change everywhere? Feels like that would ultimately probably be the right choice, but want to double-check.

What change are you referring to, Danny?

shawnborton · 2026-01-26T06:01:20Z

I think I am following. We should map out how other items would work though... like what do we show for "From" for all possible "chat" types? I guess in most cases we just show the workspace?

dannymcclain · 2026-01-26T21:49:56Z

Cleared it up with Jon in person, but yes Shawn for most of the other ones instead of the label for the row being From, it would just be Workspace. So for example, this one would be:

Room name
#sfonshore26 >

Workspace
Expensify Chat

dubielzyk-expensify · 2026-01-26T22:26:17Z

Ahh yes I'm down for this 👍

shawnborton · 2026-01-27T06:21:22Z

Works for me!

Pujan92 · 2026-02-01T12:54:30Z

@Nodebrute Let's make the required change and apply the same for the workspace room

Nodebrute · 2026-02-02T18:04:18Z

@Pujan92 on it.

Pujan92 · 2026-02-18T12:24:03Z

Bump @Nodebrute for the update

Nodebrute · 2026-02-18T13:36:49Z

Sorry, I missed this. I’ll update it today.

Nodebrute · 2026-02-26T21:39:07Z

@Pujan92 additionalRoomDetails is used in multiple places (Workspace Chat, Room, and Invoice Room). Should I update all of them?

   const additionalRoomDetails =
        (isPolicyExpenseChat && !!report?.isOwnPolicyExpenseChat) || isExpenseReportUtil(report) || isPolicyExpenseChat || isInvoiceRoom
            ? chatRoomSubtitle
            : `${translate('threads.in')} ${chatRoomSubtitle}`;

Pujan92 · 2026-03-07T12:34:12Z

@Nodebrute we need this specific to workspace room where we have the workspace name. For others, as shown here don't need that change

seprate subtitle from title

b00d21f

Nodebrute requested review from a team as code owners December 17, 2025 17:04

melvin-bot bot assigned Nodebrute Dec 17, 2025

melvin-bot bot requested review from Pujan92 and joekaufmanexpensify and removed request for a team December 17, 2025 17:04

melvin-bot bot removed the request for review from a team December 17, 2025 17:04

Nodebrute added 2 commits December 17, 2025 22:11

fix lint

1ea5ae2

fix subtitle in 2 lines

f151d22

Nodebrute added 2 commits December 17, 2025 22:35

fix lint errors

f57edd0

remove unused variables

f8283c8

joekaufmanexpensify previously approved these changes Dec 17, 2025

View reviewed changes

Merge branch 'main' into sepratetitle

a2684a5

Nodebrute dismissed joekaufmanexpensify’s stale review via a2684a5 December 30, 2025 10:06

Nodebrute added 3 commits December 30, 2025 15:13

fix lint error

afc0c4b

fix font size of subtitle

af97ac4

fix lint

27b87ea

Merge branch 'main' into sepratetitle

7c16bd1

Nodebrute and others added 2 commits January 8, 2026 22:27

undo subtitle line change

af674c7

Merge branch 'main' into sepratetitle

94ec79b

Pujan92 suggested changes Jan 10, 2026

View reviewed changes

Nodebrute and others added 2 commits January 14, 2026 00:44

Merge branch 'main' into sepratetitle

c3bb82b

add description styles

fd783be

Nodebrute and others added 2 commits February 27, 2026 01:26

Merge branch 'main' into sepratetitle

de1e48a

fix lint

6261b1e

	textStyles={parentNavigationSubtitleTextStyle}
	textStyles={parentNavigationSubtitleTextStyle}
	descriptionTextStyle={[styles.mutedNormalTextLabel, styles.mb1]}

	description={translate('common.from')}
	description={translate('common.from')}
	descriptionTextStyle={[styles.mutedNormalTextLabel, styles.mb1]}

Conversation

Nodebrute commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 17, 2025

Uh oh!

Nodebrute commented Dec 17, 2025

Uh oh!

Nodebrute commented Dec 17, 2025

Uh oh!

codecov bot commented Dec 17, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Pujan92 commented Dec 22, 2025

Uh oh!

Pujan92 commented Dec 24, 2025

Uh oh!

dubielzyk-expensify commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dubielzyk-expensify commented Dec 26, 2025

Uh oh!

Nodebrute commented Dec 29, 2025

Uh oh!

Nodebrute commented Dec 30, 2025

Uh oh!

Pujan92 commented Jan 3, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Nodebrute commented Jan 8, 2026

Uh oh!

Pujan92 Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Pujan92 Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Nodebrute Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Pujan92 commented Jan 10, 2026

Uh oh!

Pujan92 commented Jan 10, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

Uh oh!

dubielzyk-expensify commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dannymcclain commented Jan 12, 2026

Uh oh!

Nodebrute commented Jan 12, 2026

Uh oh!

dubielzyk-expensify commented Jan 13, 2026

Uh oh!

Nodebrute commented Jan 15, 2026

Uh oh!

Pujan92 commented Jan 23, 2026

Uh oh!

dannymcclain commented Jan 24, 2026

Uh oh!

dubielzyk-expensify commented Jan 25, 2026

Uh oh!

shawnborton commented Jan 26, 2026

Uh oh!

dannymcclain commented Jan 26, 2026

Nodebrute commented Dec 17, 2025 •

edited

Loading

codecov bot commented Dec 17, 2025 •

edited by github-actions bot

Loading

dubielzyk-expensify commented Dec 26, 2025 •

edited

Loading

dubielzyk-expensify commented Jan 12, 2026 •

edited

Loading