[BYOC] Bulk assign cards - Update assign card flow in RHP by carlosmiceli · Pull Request #77931 · Expensify/App

carlosmiceli · 2025-12-17T20:08:30Z

Explanation of Change

New card assignment flow:

Select a card from the table
Pick a member in the RHP
Confirm the details in confirmation screen in RHP
Cardholder, card name, and start date are editable
Also updated back navigation for all possible flows

Fixed Issues

$ #77796
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…ign-r1-card-flow

hungvu193 · 2025-12-18T09:37:18Z

One thing I noticed during testing is, sometimes Last updated field is empty after assigning a card. We probably should hide it if it's empty

Screen.Recording.2025-12-18.at.16.36.16.mov

hungvu193 · 2025-12-18T09:46:59Z

Not related to this PR but I think it's good to fix it (if you think it's under the scope of this PR), we have similiar issue here, but looks like they don't fix it in every other places.

Bug: App crashes when reloading card details bug

Click on any card on Company Card Page.
Reload the page.

Screen.Recording.2025-12-18.at.16.46.11.mov

src/ROUTES.ts

Co-authored-by: Hans <hungvu193@users.noreply.github.com>

hungvu193 · 2025-12-18T15:58:56Z

Another thing I ,guess we should need to fix, user can still assign the card when the card connection is broken:

Import Plaid card > Click Assign to assign the card.
Notice in the background, there's an error shows that card connection is broken > go back to Company Card page
Notice that the Assign button is disabled.
Reload the page and click on Assign button again.
Notice that even when the error appears, you're still able to assign that card.

Screen.Recording.2025-12-18.at.22.54.27.mov

Co-authored-by: Hans <hungvu193@users.noreply.github.com>

…leton Implement loading skeleton for Company Cards table

hungvu193 · 2025-12-18T17:07:31Z

Bug: Card name is overflow when it's too long

Open company card page.
Click Assign.
Change the card name to a very long name (100 characters) save and Assign the card.
Notice the Card display name in company card page.

Screen.Recording.2025-12-19.at.00.06.06.mov

github-actions · 2025-12-18T18:34:57Z

🚧 @dylanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-12-18T19:07:30Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #77931.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/77931/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/77931/index.html

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	https://77931.pr-testing.expensify.com
The build for Desktop was skipped

👀 View the workflow run that generated this build 👀

tgolen · 2025-12-18T19:54:19Z

src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx

@@ -51,7 +53,10 @@ function ConfirmationStep({policyID, feed, backTo}: ConfirmationStepProps) {
    const [cardFeeds] = useCardFeeds(policyID);

    const data = assignCard?.data;


I don't think this constant is valuable. I would update everything to reference assigneCard?.data (which some places do already).

✅ Updated.

tgolen · 2025-12-18T19:56:02Z

src/pages/workspace/companyCards/assignCard/TransactionStartDateStep.tsx

+        const backTo = route?.params?.backTo;
+        if (backTo) {
+            Navigation.goBack(backTo);
+            return;
+        }


There is a pretty big refactoring underway to remove backTo. I don't think the necessary foundation is in place yet to refactor this, so it will probably need to remain as-is for now.

tgolen · 2025-12-18T19:57:28Z

src/pages/workspace/companyCards/WorkspaceCompanyCardsList.tsx

+                    onPress={() => {
+                        if (!assignedCard) {
+                            onAssignCard(cardIdentifier);
+                            return;
+                        }
+
+                        if (!assignedCard?.accountID || !assignedCard?.fundID) {
+                            return;
+                        }
+
+                        return Navigation.navigate(
+                            ROUTES.WORKSPACE_COMPANY_CARD_DETAILS.getRoute(
+                                policyID,
+                                assignedCard.cardID.toString(),
+                                getCompanyCardFeedWithDomainID(assignedCard?.bank as CompanyCardFeed, assignedCard.fundID),
+                            ),
+                        );
+                    }}


Can you please move this function to be declared outside of return ()?

tgolen · 2025-12-18T20:03:59Z

src/pages/workspace/companyCards/WorkspaceCompanyCardsList.tsx

+        return (
+            <WorkspaceCompanyCardsFeedAddedEmptyPage
+                shouldShowGBDisclaimer={shouldShowGBDisclaimer}
+                handleAssignCard={onAssignCard}


All other places in this PR the code is andleAssignCard={() => onAssignCard()}. Is this OK like this? I assume it's passing a cardID to the callback and the other references are specifically NOT passing a cardID?

ikevin127 · 2025-12-18T20:18:24Z

♻️ Checking comments / issues reported by @hungvu193 & @tgolen and addressing them...

dannymcclain · 2025-12-18T20:40:27Z

🐛 BUG: Somehow this card ended up with an empty Card name field (kinda). I'm not really sure how to reproduce this as this is just kinda how the feed loaded in for me.

CardNameEmptySomehow.mp4

dylanexpensify · 2025-12-18T20:41:25Z

🐛 BUG: Clicking update card for a card after assigning doesn't result in an updated timestamp

Screen.Recording.2025-12-18.at.4.19.36.PM.mov

dylanexpensify · 2025-12-18T20:48:50Z

🐛 BUG: Going offline while on plaid card feed and navigating to commercial card feeds throws an Uh oh error

Screen.Recording.2025-12-18.at.4.21.42.PM.mov

dannymcclain · 2025-12-18T20:53:58Z

🐛 BUG: When I simulate failed network requests, the assign button doesn't do anything.

NothingHappensWhenRequestFails.mp4

dannymcclain · 2025-12-18T20:58:16Z

🧼 Polish / 🐛 Bug: There are no slide transitions on the RHP screens, the screens just change instantly.

NoTransitions.mp4

dannymcclain · 2025-12-18T21:02:39Z

🐛 BUG: Header changes on Start date screen causing an unnecessary UI jump:

Normal	Extra text

dylanexpensify · 2025-12-18T21:26:15Z

🧼 Polish: transition for unassigning card can be quicker/more seamless. Currently it disappears and reappears.

Screen.Recording.2025-12-18.at.4.25.09.PM.mov

dannymcclain · 2025-12-18T21:29:51Z

🧼 Polish: Card icon reloads for every kind of filtering transition:

IconReloading.mp4

cc @chrispader

OSBotify · 2025-12-23T00:52:33Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.2.86-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-24T18:49:39Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.86-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

chrispader and others added 27 commits December 15, 2025 17:50

feat: allow linking to specific card in ASSIGN_CARD flow

e2f9b82

Merge branch 'byoc-bulk-card-assign-r1-table' into byoc-bulk-card-ass…

84951db

…ign-r1-card-flow

feat: extract route options into param object type

3c3f84c

update assignee step text

077e486

Update TransactionStartDateStep.tsx

215c8f7

Update en.ts

fb10e3f

import isLoadingOnyxValue and cardListMetada

2a6efbe

check card feeds

92bd4cb

add isloadingCardsList

f85990b

import skeleton elements

c254b6b

implement skeleton when loading

fafdcb4

polish skeleton loading

2562d10

add cardID to route

a881e70

update navigation

880dbe4

add plaid and commercial checks for urls

fd036d8

open rhp if visiting card url directly

98ac60f

open member selection in rhp

c21c0fb

remove filteredCardList logic

cd67fb3

remove steps from confirmation screen

99419cd

update back navigation

056142e

UI updates to confirmation screen

49ef4bf

remove unused variables

121d160

update card identifier menu item in confirmation screen

ad439c9

add default date to confirmation screen

9aa99af

update cardholder menu item

a7da239

add back navigation logic to start date

d60e4d1

fix assignee step navigation when reselecting same member

04e686a

carlosmiceli requested review from a team as code owners December 17, 2025 20:08

melvin-bot bot assigned carlosmiceli Dec 17, 2025

hungvu193 reviewed Dec 18, 2025

View reviewed changes

src/ROUTES.ts Outdated Show resolved Hide resolved

Update src/pages/workspace/companyCards/WorkspaceCompanyCardsList.tsx

2296422

Co-authored-by: Hans <hungvu193@users.noreply.github.com>

carlosmiceli and others added 3 commits December 18, 2025 11:19

fix flashing assign card screen

f5ce09c

Update src/ROUTES.ts

799dfe6

Co-authored-by: Hans <hungvu193@users.noreply.github.com>

Merge pull request #77804 from Expensify/cm-company-cards-loading-ske…

e92856b

…leton Implement loading skeleton for Company Cards table

fix conflicts and integrate previous list changes into new table

398330f

tgolen requested changes Dec 18, 2025

View reviewed changes

dannymcclain requested a review from a team December 18, 2025 20:25

carlosmiceli merged commit 70531b6 into byoc-bulk-card-assign-r1 Dec 18, 2025
35 of 55 checks passed

carlosmiceli deleted the byoc-bulk-card-assign-r1-card-flow branch December 18, 2025 21:59

carlosmiceli restored the byoc-bulk-card-assign-r1-card-flow branch December 18, 2025 22:00

OSBotify mentioned this pull request Dec 23, 2025

Deploy Checklist: New Expensify 2025-12-23 #78313

Closed

melvin-bot bot mentioned this pull request Dec 24, 2025

[Due for payment 2025-12-31] [BYOC] Bulk assign cards - Update assign card flow in RHP #77796

Closed

		@@ -51,7 +53,10 @@ function ConfirmationStep({policyID, feed, backTo}: ConfirmationStepProps) {
		const [cardFeeds] = useCardFeeds(policyID);

		const data = assignCard?.data;

Conversation

carlosmiceli commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

hungvu193 commented Dec 18, 2025

Uh oh!

hungvu193 commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

hungvu193 commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

tgolen Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

ikevin127 Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

tgolen Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

tgolen Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

ikevin127 Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

tgolen Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

ikevin127 Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

ikevin127 commented Dec 18, 2025

Uh oh!

dannymcclain commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dylanexpensify commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dylanexpensify commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dannymcclain commented Dec 18, 2025

Uh oh!

dannymcclain commented Dec 18, 2025

Uh oh!

dannymcclain commented Dec 18, 2025

Uh oh!

dylanexpensify commented Dec 18, 2025

Uh oh!

dannymcclain commented Dec 18, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

OSBotify commented Dec 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

carlosmiceli commented Dec 17, 2025 •

edited

Loading

hungvu193 commented Dec 18, 2025 •

edited

Loading

hungvu193 commented Dec 18, 2025 •

edited

Loading

dannymcclain commented Dec 18, 2025 •

edited

Loading

dylanexpensify commented Dec 18, 2025 •

edited

Loading

dylanexpensify commented Dec 18, 2025 •

edited

Loading