Skip to content

Refactored ConfirmModal usage to useConfirmModal#77950

Merged
roryabraham merged 13 commits intoExpensify:mainfrom
abbasifaizan70:76695-refactored-confirmation-modal-PR-3
Jan 7, 2026
Merged

Refactored ConfirmModal usage to useConfirmModal#77950
roryabraham merged 13 commits intoExpensify:mainfrom
abbasifaizan70:76695-refactored-confirmation-modal-PR-3

Conversation

@abbasifaizan70
Copy link
Contributor

@abbasifaizan70 abbasifaizan70 commented Dec 18, 2025 •
edited
Loading

Explanation of Change

This PR refactored ConfirmModal usage to useConfirmModal in the following files:

RoomMemberDetailsPage.tsx
ReportParticipantDetailsPage.tsx
EditReportFieldPage.tsx
TravelTerms.tsx

Fixed Issues

$ #76695
PROPOSAL: #76695 (comment)

Tests

RoomMemberDetailsPage.tsx

  1. Navigate to a workspace room
  2. Click on room header → Details → Members
  3. Click on any member's name/avatar to view their details
  4. Member details page should open
  5. Look for "Remove Room Member" button > - Click it
  6. A confirmation modal should appear.

ReportParticipantDetailsPage.tsx

  1. Create a group chat with 3+ people (or use an existing one)
  2. Make sure you're the admin of the group
  3. Tap on the group chat header
  4. Go to Members
  5. Tap on any member's name (not yourself)
  6. Click "Remove from group" button

EditReportFieldPage.tsx

  1. Go to Settings → Workspaces → [Your Workspace]
  2. Enable Report Fields if not already enabled
  3. Create a custom report field (text, date, or dropdown)
  4. Create or open an expense report in that workspace
  5. Go to the report and find the custom field
  6. Tap to edit the custom report field
  7. Tap the ⋮ three-dot menu in the header
  8. Select "Delete"

TravelTerms.tsx

  1. Open book travel from left FAB
  2. Navigate through the book travel acceptance flow
  3. If additional verification is required:
  4. After that Modal should appear "We're reviewing your request"
  • Verify that no errors appear in the JS console

Offline tests

same as tests.

QA Steps

same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

RoomMemberDetailsPage.tsx

https://github.com/user-attachments/assets/fc92aba3-08c7-4d3b-8a34-ecd08bd8423c

ReportParticipantDetailsPage.tsx

Screen.Recording.2026-01-06.at.7.26.21.PM.mov
Android: mWeb Chrome

RoomMemberDetailsPage.tsx

Screen.Recording.2026-01-06.at.7.50.55.PM.mov

ReportParticipantDetailsPage.tsx

Screen.Recording.2026-01-06.at.7.21.22.PM.mov
iOS: Native

RoomMemberDetailsPage.tsx

Screen.Recording.2026-01-06.at.7.55.48.PM.mov

ReportParticipantDetailsPage.tsx

Screen.Recording.2026-01-06.at.7.11.08.PM.mov
iOS: mWeb Safari

RoomMemberDetailsPage.tsx

Screen.Recording.2026-01-06.at.7.56.48.PM.mov

ReportParticipantDetailsPage.tsx

Screen.Recording.2026-01-06.at.7.16.38.PM.mov
MacOS: Chrome / Safari

RoomMemberDetailsPage.tsx

image

ReportParticipantDetailsPage.tsx

image

EditReportFieldPage.tsx

image
Screen.Recording.2026-01-06.at.7.23.34.PM.mov

TravelTerms.tsx

image
Screen.Recording.2026-01-07.at.6.59.22.PM.mov

@codecov
Copy link

codecov bot commented Dec 18, 2025 •
edited by github-actions bot
Loading

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/pages/RoomMemberDetailsPage.tsx 0.00% <0.00%> (ø)
src/pages/ReportParticipantDetailsPage.tsx 0.00% <0.00%> (ø)
src/pages/RoomMembersPage.tsx 0.00% <0.00%> (ø)
...es/home/sidebar/FloatingActionButtonAndPopover.tsx 51.32% <14.28%> (+0.18%) ⬆️
src/pages/ReportDetailsPage.tsx 58.78% <23.52%> (-0.81%) ⬇️
src/pages/ReportParticipantsPage.tsx 0.00% <0.00%> (ø)
src/pages/EditReportFieldPage.tsx 0.00% <0.00%> (ø)
src/pages/Travel/TravelTerms.tsx 0.00% <0.00%> (ø)
... and 165 files with indirect coverage changes

@abbasifaizan70 abbasifaizan70 mentioned this pull request Dec 18, 2025
Closed
@abbasifaizan70 abbasifaizan70 marked this pull request as ready for review December 18, 2025 16:50
@abbasifaizan70 abbasifaizan70 requested review from a team as code owners December 18, 2025 16:50
@melvin-bot
Copy link

melvin-bot bot commented Dec 18, 2025

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from a team and roryabraham and removed request for a team December 18, 2025 16:50
@melvin-bot
Copy link

melvin-bot bot commented Dec 18, 2025

@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@abbasifaizan70 abbasifaizan70 mentioned this pull request Dec 18, 2025
Closed
53 tasks
@trjExpensify
Copy link
Contributor

trjExpensify commented Dec 18, 2025

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

@trjExpensify trjExpensify removed their request for review December 18, 2025 16:52
@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Jan 2, 2026 •
edited
Loading

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
2026-01-07.12.43.09.mov
2026-01-07.12.44.40.mov
2026-01-07.12.46.39.mov
2026-01-07.12.42.25.mov
Android: mWeb Chrome
2026-01-07.12.36.11.mov
2026-01-07.12.37.29.mov
2026-01-07.12.37.55.mov
2026-01-07.12.38.28.mov
iOS: HybridApp
2026-01-07.12.29.15.mov
2026-01-07.12.30.24.mov
2026-01-07.12.31.18.mov
2026-01-07.12.32.04.mov
iOS: mWeb Safari
2026-01-07.11.56.18.mov
2026-01-07.11.59.36.mov
2026-01-07.12.00.22.mov
2026-01-07.12.04.05.mov
MacOS: Chrome / Safari
2026-01-07.11.08.54.mov
2026-01-07.11.11.26.mov
2026-01-07.11.32.26.mov
2026-01-07.11.40.49.mov

@abbasifaizan70
Copy link
Contributor Author

abbasifaizan70 commented Jan 5, 2026 •
edited
Loading

@ZhenjaHorbach Updated with Main and also added space.

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Jan 5, 2026

@abbasifaizan70
What about screenshots or videos in the PR description?

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Jan 7, 2026

LGTM!

roryabraham
roryabraham requested changes Jan 7, 2026
View reviewed changes
@abbasifaizan70
Copy link
Contributor Author

abbasifaizan70 commented Jan 7, 2026

@roryabraham Resolved feedback. Thanks

@roryabraham roryabraham merged commit a938a24 into Expensify:main Jan 7, 2026
30 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented Jan 7, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

This was referenced Jan 8, 2026
Open
Closed
Open
Open
Open
Open
Merged
Closed
@OSBotify OSBotify mentioned this pull request Jan 8, 2026
Closed
76 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jan 8, 2026

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.96-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify OSBotify mentioned this pull request Jan 9, 2026
Closed
7 tasks
arosiclair added a commit that referenced this pull request Jan 9, 2026
@arosiclair
Revert "Merge pull request #77950 from abbasifaizan70/76695-refactore…
1fd4ef7 
…d-confirmation-modal-PR-3"

This reverts commit a938a24, reversing
changes made to e8a88b5.
@arosiclair arosiclair mentioned this pull request Jan 9, 2026
Merged
51 tasks
@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Jan 9, 2026

@abbasifaizan70
Could you reopen PR with this fix and with changes from this discussion?

@OSBotify
Copy link
Contributor

OSBotify commented Jan 9, 2026

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Jan 9, 2026

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 9, 2026

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 9, 2026

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.97-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 10, 2026

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.99-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 13, 2026

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.99-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify OSBotify mentioned this pull request Jan 13, 2026
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roryabraham roryabraham roryabraham approved these changes

+1 more reviewer

@ZhenjaHorbach ZhenjaHorbach ZhenjaHorbach approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abbasifaizan70 abbasifaizan70

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abbasifaizan70 @trjExpensify @ZhenjaHorbach @OSBotify @roryabraham