Conversation
|
🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
bot
requested review from
JmillsExpensify
and removed request for
a team
| import type {BaseTextInputRef} from '@components/TextInput/BaseTextInput/types'; | ||
| import useConfirmModal from '@hooks/useConfirmModal'; |
| data={data} | ||
| disableKeyboardShortcuts={removeMembersConfirmModalVisible} |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fd4ef7813
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| title={caseID === CASES.DEFAULT ? translate('task.deleteTask') : translate('iou.deleteExpense', {count: 1})} | ||
| isVisible={isDeleteModalVisible} | ||
| onConfirm={() => { | ||
| setIsDeleteModalVisible(false); | ||
| isTransactionDeleted.current = true; |
There was a problem hiding this comment.
The delete confirmation now only sets isTransactionDeleted.current = true and closes the modal; the actual deleteTransaction() + navigation is deferred to the unmount cleanup effect. Since the confirm handler no longer navigates away, a user who confirms delete and stays on the details page will never trigger the deletion (they have to manually back out to unmount), leaving the transaction intact despite confirming.
Useful? React with 👍 / 👎.
| <ConfirmModal | ||
| isVisible={showVerifyCompanyModal} | ||
| onConfirm={() => { | ||
| createTravelEnablementIssue(); | ||
| setShowVerifyCompanyModal(false); |
There was a problem hiding this comment.
The verify-company modal now just hides itself on confirm/cancel and does not clear TRAVEL_PROVISIONING. Because the effect opens the modal whenever travelProvisioning.error is ERROR_ADDITIONAL_VERIFICATION_REQUIRED, leaving that error in Onyx will cause the modal to reappear on remount or any provisioning merge, repeatedly blocking the user. The previous cleanup avoided this; the modal dismissal should clear the provisioning session.
Useful? React with 👍 / 👎.
| const hideDeleteModal = useCallback(() => { | ||
| callbackWhenDeleteModalHide.current = () => (onCancelDeleteModal.current = runAndResetCallback(onCancelDeleteModal.current)); | ||
| setIsDeleteCommentConfirmModalVisible(false); | ||
| setShouldSetModalVisibilityForDeleteConfirmation(true); | ||
| setIsRoomArchived(false); | ||
| setIsChronosReportEnabled(false); | ||
| setIsChatPinned(false); |
There was a problem hiding this comment.
hideDeleteModal now only resets local flags and no longer closes the delete confirmation. Since hideDeleteModal() is still called when a report action unmounts (e.g., navigating away from a chat), the global confirm modal can remain visible even after its backing action is gone, leaving a stale delete prompt that still acts on old refs. This should explicitly dismiss the modal via the modal context (or equivalent).
Useful? React with 👍 / 👎.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Revert 79155 & 77950 (cherry picked from commit e2d4a9e) (cherry-picked to staging by arosiclair)
…860157713-1 🍒 Cherry pick PR #79219 to staging 🍒
|
🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.96-6 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.96-6 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.97-0 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.99-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.2.99-8 🚀
|
3 participants
Explanation of Change
Reverts #79155 and #77950
Fixed Issues
$ #79187
Tests
Preconditions:
Steps:
Offline tests
None
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos