Conversation
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2025-12-18.at.15.33.15.movScreen.Recording.2025-12-18.at.15.29.31.mov |
|
@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| }; | ||
| }); | ||
|
|
||
| const defaultColumns = sortColumns( |
There was a problem hiding this comment.
is this logic accurate? it looks like defaultColumns is just allColumns?
There was a problem hiding this comment.
Yea, it is the same, with the added isSelected key
| renderItem={renderItem} | ||
| /> | ||
| </View> | ||
| <View style={[styles.ph5, styles.pb5]}> |
There was a problem hiding this comment.
I dont think this should be pb5, right? The prev was gap2 and mt3 on the button, so itd be gap5, not pb5
There was a problem hiding this comment.
Changing it to gap5 breaks the layout. I think because the button is now outside the ListFooterComponent prop, we need to update the styles
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.85-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.85-7 🚀
|
Explanation of Change
Adds the ability to drag to reorder columns
Fixed Issues
$ #76876
Tests
Reports > ExpensesReports > ReportsOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2025-12-18.at.10.04.05.AM.mov
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari