P2P KYC - Fix errors at field level #7812
Conversation
nkuoch
requested review from
a team and
marcaaron
and removed request for
marcochavezf
marcaaron
left a comment
marcaaron
left a comment
There was a problem hiding this comment.
Thanks for finding this! 🙇 Just left a couple style comments.
|
|
||
| this.getErrors = () => formHelper.getErrors(props); | ||
| this.clearError = path => formHelper.clearError(props, path); | ||
| getErrors() { |
There was a problem hiding this comment.
style - needs a doc with @returns {Object}
| return `${this.props.translate(this.fieldNameTranslationKeys[fieldName])} ${this.props.translate('common.isRequiredField')}.`; | ||
| } | ||
|
|
||
| clearError(path) { |
There was a problem hiding this comment.
style - needs a doc with @param {String} path
| } | ||
|
|
||
| clearError(path) { | ||
| return this.formHelper.clearError(this.props, path); |
There was a problem hiding this comment.
Probably can skip the return since clearError() returns void
|
Updated |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @marcaaron in version: 1.1.40-0 🚀
|
|
@nkuoch @marcaaron |
|
I just checked it off thanks |
|
🚀 Deployed to production by @yuwenmemon in version: 1.1.40-2 🚀
|
Details
When there was an error at field level, the field didn't get red, and the corresponding error didn't show up.
It's because getErrors was always sending the original props, not the updated ones that were received after an Onyx change.
Now, I'm passing the right props.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/197281
Tests / QA Steps
Try to transfer your wallet balance.
When asked for your personal additional details, submit the form with empty fields.
Required fields should get red and with a corresponding error message.
Tested On
Screenshots
Web