P2P KYC - Ask user to provide full SSN when LexisNexis cannot #7804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkuoch
force-pushed
the
nat-p2pkyc
branch
2 times, most recently
from
99d4c66 to
f4d55ef
Compare
nkuoch
changed the title
nkuoch
force-pushed
the
nat-p2pkyc
branch
4 times, most recently
from
8c06c63 to
0195646
Compare
nkuoch
changed the title
nkuoch
changed the title
nkuoch
changed the title
nkuoch
force-pushed
the
nat-p2pkyc
branch
3 times, most recently
from
dd9e9f9 to
3cd3b7e
Compare
nkuoch
commented
Feb 18, 2022
| } | ||
|
|
||
| setAdditionalDetailsLoading(false); | ||
| setAdditionalDetailsErrors(null); |
Contributor
Author
There was a problem hiding this comment.
FYI I removed all these because we were already doing it there.
nkuoch
changed the title
ctkochan22
previously approved these changes
Feb 21, 2022
7 tasks
Contributor
Author
|
Bump @ctkochan22 and @marcaaron |
marcaaron
approved these changes
Feb 28, 2022
Contributor
marcaaron
left a comment
marcaaron
left a comment
There was a problem hiding this comment.
Code looks good and is testing well for me. Really nice changes!
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
68 tasks
Contributor
Contributor
Contributor
|
🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Ask for full 9 digit SSN when LexisNexis cannot find the first five after the user gives his last 4.
Fixed Issues
Part of https://github.com/Expensify/Expensify/issues/193504
Tests
Tested with the secure PR (but should be merged before the secure one) and these app fixes: #7782 and #7812
Try to transfer your wallet balance.
Fill up the Additional Details Step with random 4 digit SSN.
Submit the form.
Make sure you get an error, asking you to enter your full SSN.
Enter your full SSN and submit. You should then get another error (not SSN related).
QA Steps
None, as it needs the secure PR.
Tested On
Screenshots
Web