Revert "[Part 1]: Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS in src/libs/TransactionUtils/index.ts"

[yuwenmemon]

Reverts #77119

[melvin-bot]

@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #78255.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	https://78255.pr-testing.expensify.com
The build for Desktop was skipped

---

👀 View the workflow run that generated this build 👀

[yuwenmemon]

I was still able to reproduce the regression here locally on this revert PR but checking an Ad-Hoc build just in case I'm holding it wrong...

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ReportPrimaryActionUtils.ts	90.61% <100.00%> (-0.09%)	⬇️
src/libs/ReportSecondaryActionUtils.ts	92.94% <100.00%> (-0.02%)	⬇️
src/libs/TransactionUtils/index.ts	71.79% <100.00%> (+0.12%)	⬆️
src/components/MoneyReportHeader.tsx	0.00% <0.00%> (ø)
src/libs/actions/IOU.ts	64.91% <25.00%> (ø)
... and 11 files with indirect coverage changes

[yuwenmemon]

Yep, this ain't the one.