Remove unnecessary custom types from translations - batch 6 by mrejdak · Pull Request #78268 · Expensify/App

mrejdak · 2025-12-22T10:43:28Z

Explanation of Change

Removing unnecessary custom types from translations (batch 6). Translations returning PluralForms are not flattened.

Fixed Issues

Tests

Testing every modified component is not necessary since the changes are all related to types only, and TypeScript already checks types and enforces correct parameter usage.

AddressForm.tsx

Go to Account tab and select Profile
Scroll down and select Address
Input a zipcode in a wrong format for a chosen country (e.g. 'A12-B332' for Poland)
Verify that the incorrect zip code message is displayed correctly

ImportSpreadsheetConfirmModal.tsx Member.ts ImportedMembersPage.tsx

Go to Workspaces tab and create a new one.
Select Members, click More and Download CSV.
Click More, Import spreadsheet and select the same file that was just downloaded.
Click Import and verify that the modal displays the correct message.
Edit the downloaded file, by adding a new row ("[email],admin,[email],,,,,").
Import the modified file and verify the displayed message is correct.
Modify the added row, by changing the role to member and add 2 more rows without specifying the roles ("[email],,[email],,,,,").
Select the modified file for import, but change the first field mapping to 'Ignore'.
Click Import and verify that the error message about required mapping missing is correct.
Change both first and second field mapping to 'Email' and verify the error message about multiple mapping is correct.
Change the second field mapping back to 'Role' and click Import.
In the new confirmation page, verify that the message above role selection is correct.
Select any role and click Import.
Verify that the message about added and updated members is correct.

Category.ts

Go to Workspaces tab and create a new one.
Select Categories, click More and Download CSV.
Edit the downloaded file, by adding a few new rows (e.g. "Aaa,,,true,,false,,," "Aab,,,true,,true,,,")
Import the modified file and verify the displayed message is correct.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

AddressForm.tsx

ImportSpreadsheetConfirmModal.tsx Member.ts ImportedMembersPage.tsx

Simulator Screenshot - iPhone 17 Pro - 2025-12-23 at 10 47 56

Simulator Screenshot - iPhone 17 Pro - 2025-12-23 at 10 57 54

Simulator Screenshot - iPhone 17 Pro - 2025-12-23 at 11 03 24

Simulator Screenshot - iPhone 17 Pro - 2025-12-23 at 11 03 09

Simulator Screenshot - iPhone 17 Pro - 2025-12-23 at 11 11 34

Category.ts

iOS: mWeb Safari

MacOS: Chrome / Safari

AddressForm.tsx

ImportSpreadsheetConfirmModal.tsx Member.ts ImportedMembersPage.tsx

Category.ts

melvin-bot · 2025-12-22T10:43:33Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

…d parameters instead of an object

codecov · 2025-12-22T19:41:50Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/AddressForm.tsx	`98.00% <ø> (ø)`
src/components/ExceededCommentLength.tsx	`100.00% <100.00%> (ø)`
src/components/ImportSpreadsheetConfirmModal.tsx	`0.00% <ø> (ø)`
src/components/UploadFile.tsx	`0.00% <ø> (ø)`
src/libs/actions/Policy/Category.ts	`49.81% <ø> (ø)`
src/libs/actions/Policy/Member.ts	`72.75% <ø> (ø)`
src/libs/actions/Policy/PerDiem.ts	`0.00% <ø> (ø)`
src/libs/actions/Policy/Tag.ts	`69.81% <ø> (ø)`
.../pages/MissingPersonalDetails/substeps/Address.tsx	`0.00% <ø> (ø)`
src/pages/Travel/FlightTripDetails.tsx	`0.00% <ø> (ø)`
... and 14 more
... and 14 files with indirect coverage changes

melvin-bot · 2025-12-23T11:04:18Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…ject

src/languages/params.ts

src/languages/en.ts

heyjennahay · 2026-01-08T10:25:32Z

No product review required. Removing myself and unsubscribing

QichenZhu · 2026-01-08T12:11:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

AddressForm.tsx

ImportSpreadsheetConfirmModal.tsx Member.ts ImportedMembersPage.tsx

Category.ts

Android: mWeb Chrome

AddressForm.tsx

ImportSpreadsheetConfirmModal.tsx Member.ts ImportedMembersPage.tsx

Category.ts

iOS: HybridApp

AddressForm.tsx

Simulator Screenshot - iPhone 17 - 2026-01-09 at 00 27 32

ImportSpreadsheetConfirmModal.tsx Member.ts ImportedMembersPage.tsx

Simulator Screenshot - iPhone 17 - 2026-01-09 at 00 28 08

Simulator Screenshot - iPhone 17 - 2026-01-09 at 00 28 24

Simulator Screenshot - iPhone 17 - 2026-01-09 at 00 28 44

Simulator Screenshot - iPhone 17 - 2026-01-09 at 00 28 52

Simulator Screenshot - iPhone 17 - 2026-01-09 at 00 28 59

Simulator Screenshot - iPhone 17 - 2026-01-09 at 00 29 13

Category.ts

Simulator Screenshot - iPhone 17 - 2026-01-09 at 00 29 48

iOS: mWeb Safari

AddressForm.tsx

Simulator Screenshot - iPhone 17 - 2026-01-08 at 23 38 59

ImportSpreadsheetConfirmModal.tsx Member.ts ImportedMembersPage.tsx

Simulator Screenshot - iPhone 17 - 2026-01-08 at 23 43 43

Simulator Screenshot - iPhone 17 - 2026-01-08 at 23 44 35

Simulator Screenshot - iPhone 17 - 2026-01-08 at 23 44 56

Simulator Screenshot - iPhone 17 - 2026-01-08 at 23 45 09

Simulator Screenshot - iPhone 17 - 2026-01-08 at 23 45 23

Simulator Screenshot - iPhone 17 - 2026-01-08 at 23 45 37

Category.ts

Simulator Screenshot - iPhone 17 - 2026-01-08 at 23 46 04

MacOS: Chrome / Safari

AddressForm.tsx

ImportSpreadsheetConfirmModal.tsx Member.ts ImportedMembersPage.tsx

Category.ts

QichenZhu

Approving, but conflicts again

melvin-bot · 2026-01-08T15:51:16Z

@iwiznia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

iwiznia · 2026-01-08T15:51:38Z

Lint failures existed before and are unrelated to the changes here

OSBotify · 2026-01-08T16:48:40Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.2.96-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

situchan · 2026-01-08T19:47:34Z

src/components/ImportSpreadsheetConfirmModal.tsx

        const title = spreadsheet.importFinalModal.titleKey ? translate(spreadsheet.importFinalModal.titleKey) : '';
        const prompt = spreadsheet.importFinalModal.promptKey
-            ? translate(spreadsheet.importFinalModal.promptKey, spreadsheet.importFinalModal.promptKeyParams as TranslationParameters<typeof spreadsheet.importFinalModal.promptKey>[0])
+            ? translate(spreadsheet.importFinalModal.promptKey, ...(spreadsheet.importFinalModal.promptKeyParams as TranslationParameters<typeof spreadsheet.importFinalModal.promptKey>))


This line caused crash.

…remove-unnecessary-types-batch-6" This reverts commit b9039c9, reversing changes made to 1c2b441.

Revert "Merge pull request #78268 from software-mansion-labs/mrejdak/…

Revert "Merge pull request #78268 from software-mansion-labs/mrejdak/… (cherry picked from commit b4e1c87)

Revert "Merge pull request #78268 from software-mansion-labs/mrejdak/… (cherry picked from commit b4e1c87) (cherry-picked to staging by arosiclair)

…s/mrejdak/remove-unnecessary-types-batch-6"

OSBotify · 2026-01-09T18:17:39Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

OSBotify · 2026-01-09T19:14:01Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-09T19:20:57Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-09T20:01:31Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.2.97-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-10T02:20:37Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.2.99-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-13T03:12:07Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.99-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-20T17:41:05Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.3.5-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2026-01-21T09:49:33Z

@mrejdak This PR is a duplicate of the other one. The QA team has already checked and approved the first one, so we’ve marked this one as done too

OSBotify · 2026-01-21T23:05:34Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

5th batch - wip

d5bf763

melvin-bot bot assigned mrejdak Dec 22, 2025

mrejdak added 6 commits December 22, 2025 14:04

few more types replaced

a2a6319

generated languages types replaced

1e8b541

remove replaced types, reverted a pluarform flattening

c1bf623

spreadsheet types flattened

ca5976f

Merge branch 'main' into mrejdak/remove-unnecessary-types-batch-6

2bcad81

modified the promptKeyParams of OnyxUpdate to keep a list of flattene…

f08e373

…d parameters instead of an object

Merge branch 'main' into mrejdak/remove-unnecessary-types-batch-6

00e313c

blazejkustra approved these changes Dec 23, 2025

View reviewed changes

mrejdak marked this pull request as ready for review December 23, 2025 11:04

mrejdak requested review from a team as code owners December 23, 2025 11:04

melvin-bot bot requested review from QichenZhu and removed request for a team December 23, 2025 11:04

melvin-bot bot requested review from heyjennahay and removed request for a team December 23, 2025 11:04

fixed tests, as the promptKeyParams now holds a list instead of an ob…

cddca8c

…ject

QichenZhu suggested changes Dec 26, 2025

View reviewed changes

src/languages/params.ts Outdated Show resolved Hide resolved

src/languages/en.ts Outdated Show resolved Hide resolved

resolved comments

f1a0c36

mrejdak requested a review from QichenZhu January 7, 2026 10:26

Merge branch 'main' into mrejdak/remove-unnecessary-types-batch-6

236eabc

heyjennahay removed their request for review January 8, 2026 10:25

QichenZhu approved these changes Jan 8, 2026

View reviewed changes

melvin-bot bot requested a review from iwiznia January 8, 2026 12:13

mrejdak requested a review from iwiznia January 8, 2026 15:09

iwiznia approved these changes Jan 8, 2026

View reviewed changes

iwiznia merged commit b9039c9 into Expensify:main Jan 8, 2026
31 of 32 checks passed

melvin-bot bot added the Emergency label Jan 8, 2026

iwiznia removed the Emergency label Jan 8, 2026

OSBotify mentioned this pull request Jan 8, 2026

Deploy Checklist: New Expensify 2026-01-08 #79110

Closed

76 tasks

situchan reviewed Jan 8, 2026

View reviewed changes

situchan mentioned this pull request Jan 8, 2026

[Due for payment 2026-01-28] [Due for payment 2026-01-20] Tag - App crashes when import multi-level tags #79136

Closed

7 tasks

arosiclair added a commit that referenced this pull request Jan 8, 2026

Revert "Merge pull request #78268 from software-mansion-labs/mrejdak/…

5bb2f3c

…remove-unnecessary-types-batch-6" This reverts commit b9039c9, reversing changes made to 1c2b441.

arosiclair mentioned this pull request Jan 8, 2026

[CP Staging] Revert "Merge pull request #78268 from software-mansion-labs/mrejdak/… #79162

Merged

arosiclair added a commit that referenced this pull request Jan 8, 2026

Merge pull request #79162 from Expensify/arosiclair-revert-78268

b4e1c87

Revert "Merge pull request #78268 from software-mansion-labs/mrejdak/…

arosiclair added a commit that referenced this pull request Jan 8, 2026

Merge pull request #79162 from Expensify/arosiclair-revert-78268

e258ba6

Revert "Merge pull request #78268 from software-mansion-labs/mrejdak/… (cherry picked from commit b4e1c87)

mrejdak added a commit to software-mansion-labs/expensify-app-fork that referenced this pull request Jan 9, 2026

Reapply "Merge pull request Expensify#78268 from software-mansion-lab…

19a8007

…s/mrejdak/remove-unnecessary-types-batch-6"

m-natarajan mentioned this pull request Jan 9, 2026

[$250] 79110-PR78268-Workspace-Incorrect count of categories added #79217

Open

7 tasks

melvin-bot bot mentioned this pull request Jan 13, 2026

[$250] Remove unnecessary types from translations #76429

Open

OSBotify mentioned this pull request Jan 20, 2026

Deploy Checklist: New Expensify 2026-01-20 #80009

Closed

85 tasks

IuliiaHerets mentioned this pull request Jan 20, 2026

Remove unnecessary custom types from translations - batch 6 #79190

Merged

53 tasks

Conversation

mrejdak commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 22, 2025

Uh oh!

codecov bot commented Dec 22, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 23, 2025

Uh oh!

Uh oh!

Uh oh!

heyjennahay commented Jan 8, 2026

Uh oh!

QichenZhu commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

QichenZhu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot bot commented Jan 8, 2026

Uh oh!

iwiznia commented Jan 8, 2026

Uh oh!

OSBotify commented Jan 8, 2026

Uh oh!

situchan Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 10, 2026

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

OSBotify commented Jan 20, 2026

Uh oh!

IuliiaHerets commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mrejdak commented Dec 22, 2025 •

edited

Loading

codecov bot commented Dec 22, 2025 •

edited by github-actions bot

Loading

QichenZhu commented Jan 8, 2026 •

edited

Loading