Skip to content

[CP Staging] Revert "Merge pull request #78268 from software-mansion-labs/mrejdak/…#79162

Merged
arosiclair merged 2 commits intomainfrom
arosiclair-revert-78268
Jan 8, 2026
Merged

[CP Staging] Revert "Merge pull request #78268 from software-mansion-labs/mrejdak/…#79162
arosiclair merged 2 commits intomainfrom
arosiclair-revert-78268

Conversation

@arosiclair
Copy link
Copy Markdown
Contributor

@arosiclair arosiclair commented Jan 8, 2026 •
edited
Loading

…remove-unnecessary-types-batch-6"

This reverts commit b9039c9, reversing changes made to 1c2b441.

Explanation of Change

Reverts #78268

Fixed Issues

$ #79136

@arosiclair
Revert "Merge pull request #78268 from software-mansion-labs/mrejdak/…
5bb2f3c 
…remove-unnecessary-types-batch-6"

This reverts commit b9039c9, reversing
changes made to 1c2b441.
@arosiclair arosiclair self-assigned this Jan 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 8, 2026

🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jan 8, 2026

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

The diff is too large to include in this comment (72KB), so I've created a gist for you:

📋 View the translation diff here 📋

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply, or directly by running gh gist view --raw a7ed00aec4ab5f06ea026000af67b182 | git apply 😉

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 8, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #79162.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Web 🕸️
https://79162.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 8, 2026 •
edited by github-actions bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/AddressForm.tsx 98.00% <ø> (+98.00%) ⬆️
src/components/ExceededCommentLength.tsx 100.00% <100.00%> (ø)
src/components/ImportSpreadsheetConfirmModal.tsx 0.00% <ø> (ø)
src/components/UploadFile.tsx 0.00% <ø> (ø)
src/libs/actions/Policy/Category.ts 49.81% <ø> (ø)
src/libs/actions/Policy/Member.ts 72.75% <ø> (+29.42%) ⬆️
src/libs/actions/Policy/PerDiem.ts 0.00% <ø> (ø)
src/libs/actions/Policy/Tag.ts 69.81% <ø> (ø)
.../pages/MissingPersonalDetails/substeps/Address.tsx 0.00% <ø> (ø)
src/pages/Travel/FlightTripDetails.tsx 0.00% <ø> (ø)
... and 14 more
... and 270 files with indirect coverage changes

@arosiclair arosiclair marked this pull request as ready for review January 8, 2026 22:25
@arosiclair arosiclair requested review from a team as code owners January 8, 2026 22:25
@melvin-bot melvin-bot bot requested review from JmillsExpensify and QichenZhu and removed request for a team January 8, 2026 22:25
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Jan 8, 2026

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from a team, alitoshmatov and cristipaval and removed request for a team January 8, 2026 22:25
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Jan 8, 2026

@alitoshmatov @cristipaval One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

robertjchen
robertjchen previously approved these changes Jan 8, 2026
View reviewed changes
@arosiclair arosiclair merged commit b4e1c87 into main Jan 8, 2026
31 of 34 checks passed
@arosiclair arosiclair deleted the arosiclair-revert-78268 branch January 8, 2026 22:30
@melvin-bot melvin-bot bot added the Emergency label Jan 8, 2026
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Jan 8, 2026

@arosiclair looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@arosiclair
Copy link
Copy Markdown
Contributor Author

arosiclair commented Jan 8, 2026

straight revert

@arosiclair arosiclair changed the title Revert "Merge pull request #78268 from software-mansion-labs/mrejdak/… [CP Staging] Revert "Merge pull request #78268 from software-mansion-labs/mrejdak/… Jan 8, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jan 8, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@os-botify os-botify bot mentioned this pull request Jan 8, 2026
Merged
51 tasks
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jan 8, 2026
arosiclair added a commit that referenced this pull request Jan 8, 2026
@arosiclair
Merge pull request #79162 from Expensify/arosiclair-revert-78268
e258ba6 
Revert "Merge pull request #78268 from software-mansion-labs/mrejdak/…

(cherry picked from commit b4e1c87)
arosiclair added a commit that referenced this pull request Jan 8, 2026
@arosiclair
Merge pull request #79162 from Expensify/arosiclair-revert-78268
96abab6 
Revert "Merge pull request #78268 from software-mansion-labs/mrejdak/…

(cherry picked from commit b4e1c87)

(cherry-picked to staging by arosiclair)
arosiclair added a commit that referenced this pull request Jan 8, 2026
@arosiclair
Merge pull request #79164 from Expensify/cherry-pick-staging-79162-20…
376f640 
…834219419-1

🍒 Cherry pick PR #79162 to staging 🍒
@OSBotify OSBotify mentioned this pull request Jan 8, 2026
Closed
76 tasks
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jan 8, 2026

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.96-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jan 9, 2026

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jan 9, 2026

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jan 9, 2026

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jan 9, 2026

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.97-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jan 10, 2026

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.99-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jan 13, 2026

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.99-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@melvin-bot melvin-bot bot mentioned this pull request Jan 13, 2026
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertjchen robertjchen robertjchen approved these changes

@QichenZhu QichenZhu Awaiting requested review from QichenZhu

@JmillsExpensify JmillsExpensify Awaiting requested review from JmillsExpensify

@alitoshmatov alitoshmatov Awaiting requested review from alitoshmatov

@cristipaval cristipaval Awaiting requested review from cristipaval

Assignees

@arosiclair arosiclair

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arosiclair @OSBotify @robertjchen