[CP Staging] [Share Bank Account] Fix share bank account share button and filtering by NikkiWines · Pull Request #78381 · Expensify/App

NikkiWines · 2025-12-23T17:23:28Z

Explanation of Change

Fixes a couple of bugs

The share option was erroneously showing up for personal bank accounts because we weren't setting it to false
When searching for a user after selecting them, we wouldn't retain the selected status

Fixed Issues

$ #78367
$ #78366

Tests

bug 1:

Precondition:

Workspace owner has invited user as workspace admin.
Workspace is set up with business bank account.
Workspace owner has personal bank account.
Perform the steps below as workspace owner.

Go to Profile > Wallet.
Click on the business bank account.
Click Share.
Click on the personal bank account.
Confirm you don't see the option to share

bug 2:

Precondition:

Workspace is set up with bank account.
Workspace has at least 13 admins.
Perform the action below as workspace owner:

Go to Profile > Wallet.
Click 3-dot menu on the bank account > Share.
Search for a user and select the user.
Search for the same user.
Confirm the selected user will be marked as selected in the search result.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as test steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-12-23.at.12.38.35.mov

melvin-bot · 2025-12-23T17:23:34Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2025-12-23T17:32:03Z

src/pages/settings/Wallet/ShareBankAccount/ShareBankAccount.tsx

 import ScrollView from '@components/ScrollView';
-import SelectionList from '@components/SelectionList';
-import UserListItem from '@components/SelectionList/ListItem/UserListItem';
+import SelectionList from '@components/SelectionListWithSections';


Let's migrate into SelectionList as follow-up after enough discussions with design team.
For now, please disable eslint for this.

We ended up keep using SelectionList, not reverting back to SelectionListWithSections.

codecov · 2025-12-23T17:32:15Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/SelectionList/BaseSelectionList.tsx	`66.99% <50.00%> (+0.16%)`	⬆️
src/pages/settings/Wallet/WalletPage/index.tsx	`0.00% <0.00%> (ø)`
...tings/Wallet/ShareBankAccount/ShareBankAccount.tsx	`0.00% <0.00%> (ø)`
... and 23 files with indirect coverage changes

…ectionList

situchan · 2025-12-23T17:55:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2025-12-23.at.11.54.19.PM.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-12-23.at.11.51.19.PM.mov

melvin-bot · 2025-12-23T17:57:23Z

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

youssef-lr

LGTM

OSBotify · 2025-12-23T18:11:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[CP Staging] [Share Bank Account] Fix share bank account share button and filtering (cherry picked from commit 3af2054) (cherry-picked to staging by Julesssss)

OSBotify · 2025-12-23T19:02:25Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.2.86-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-24T18:51:57Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.86-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-24T19:11:04Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.2.87-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-29T12:11:49Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.87-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

NikkiWines added 4 commits December 23, 2025 11:29

use adminsToDisplay so the filter preserves the isSelected state

ef4afe4

use ternary to ensure we don't show share button for personal accounts

886a58e

fix filtering for selecting all admins

79e7555

use selection list with sections

641856e

NikkiWines requested a review from situchan December 23, 2025 17:23

NikkiWines self-assigned this Dec 23, 2025

NikkiWines requested review from a team as code owners December 23, 2025 17:23

melvin-bot bot requested a review from eVoloshchak December 23, 2025 17:23

melvin-bot bot removed the request for review from a team December 23, 2025 17:23

situchan reviewed Dec 23, 2025

View reviewed changes

undo selectionListWithOptions and add shouldClearInputOnSelect to Sel…

6680d71

…ectionList

NikkiWines removed the request for review from eVoloshchak December 23, 2025 17:39

situchan approved these changes Dec 23, 2025

View reviewed changes

melvin-bot bot requested a review from youssef-lr December 23, 2025 17:57

youssef-lr approved these changes Dec 23, 2025

View reviewed changes

youssef-lr merged commit 3af2054 into main Dec 23, 2025
37 of 38 checks passed

youssef-lr deleted the nikki-share-bank-account-bugs branch December 23, 2025 18:02

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Dec 23, 2025

OSBotify mentioned this pull request Dec 23, 2025

Deploy Checklist: New Expensify 2025-12-23 #78313

Closed

Conversation

NikkiWines commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 23, 2025

Uh oh!

situchan Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

NikkiWines Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

situchan Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 23, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

situchan commented Dec 23, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 23, 2025

Uh oh!

youssef-lr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

OSBotify commented Dec 24, 2025

Uh oh!

OSBotify commented Dec 24, 2025

Uh oh!

OSBotify commented Dec 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NikkiWines commented Dec 23, 2025 •

edited

Loading

codecov bot commented Dec 23, 2025 •

edited by github-actions bot

Loading