Improve deleted tax behavior by huult · Pull Request #78472 · Expensify/App

huult · 2025-12-26T06:24:30Z

Explanation of Change

Handle deleted tax rates by detecting removed codes, showing them as disabled/selected in the picker, and clearing the tax on submit when editing

Fixed Issues

$ #73033
PROPOSAL: #73033 (comment)

Tests

Same QA step

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the Expensify app.
Create a workspace and enable Taxes in More features.
Open the Taxes page and add a new tax rate with a value greater than 0.
Go to the workspace chat and create an expense, selecting the tax rate from step 3.
Go to the workspace settings and change the value of the tax rate you used, or delete the tax rate you used.
Open the expense details and observe the Tax field and Tax Amount field.
Verify that the Tax field shows “Tax no longer valid.” When you tap Tax to open the tax picker, you should see that the tax value that was deleted or changed is shown in a disabled style. If you select this tax again, the Tax field becomes blank and this tax is removed from the picker list.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-01-19.at.10.46.29.mp4

Android: mWeb Chrome

Screen.Recording.2026-01-19.at.10.50.11.mp4

iOS: Native

Screen.Recording.2026-01-19.at.10.55.24.mp4

iOS: mWeb Safari

Screen.Recording.2026-01-19.at.10.57.56.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-01-19.at.10.39.58.mp4

melvin-bot · 2025-12-26T06:24:36Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/TaxPicker.tsx

codecov · 2025-12-26T06:32:36Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...ges/iou/request/step/IOURequestStepTaxRatePage.tsx	`0.00% <0.00%> (ø)`
...c/components/ReportActionItem/MoneyRequestView.tsx	`0.23% <0.00%> (-0.01%)`	⬇️
src/components/TaxPicker.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

…fter-edit

huult · 2025-12-29T08:29:43Z

Hi @MonilBhavsar, I have a question about the backend behavior.

Screen.Recording.2025-12-29.at.15.21.50.mov

Select a tax (for example, Tax 2 with tax value 35% and taxCode id_TAX_RATE_2)
Go to Workspace settings and change the tax value to 40%
Go back to the expense and you will see: “Tax no longer valid.”
I select the tax with value 40% and taxCode id_TAX_RATE_2 and submit it to the backend, the tax value is not updated to 40% and the taxOutOfPolicy error still exists.

Can we update step 4 so that when I select the tax with value 40% and taxCode id_TAX_RATE_2 and submit it to the backend, the tax value is updated to 40% and the taxOutOfPolicy error is removed?

cc @thesahindia @joekaufmanexpensify

MonilBhavsar · 2025-12-29T08:50:12Z

What API response did you get when you selected new tax rate with 40%?

huult · 2025-12-29T08:53:19Z

The response was from the UpdateMoneyRequestTaxRate API.

MonilBhavsar · 2025-12-29T08:56:54Z

Yes, do you mind sharing it here?

huult · 2025-12-29T09:03:42Z

requestID: "9b57e3713e2db251-LAX"

{
    "jsonCode": 200,
    "requestID": "9b57e3713e2db251-LAX",
    "onyxData": [
        {
            "key": "report_8491660798716591",
            "onyxMethod": "merge",
            "value": {
                "participants": {
                    "21091638": {
                        "notificationPreference": ""
                    }
                }
            }
        },
        {
            "key": "personalDetailsList",
            "onyxMethod": "merge",
            "value": {
                "21091638": {
                    "accountID": 21091638,
                    "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_22.png",
                    "displayName": "TM",
                    "firstName": "TM",
                    "lastName": "",
                    "login": "huult+03242949242242@gmail.com",
                    "phoneNumber": "",
                    "pronouns": "",
                    "status": null,
                    "timezone": {
                        "automatic": true,
                        "selected": "Asia\/Ho_Chi_Minh"
                    },
                    "validated": false
                }
            }
        },
        {
            "key": "report_8491660798716591",
            "onyxMethod": "merge",
            "value": {
                "lastReadTime": "2025-12-29 08:20:52.382"
            }
        },
        {
            "key": "reportNameValuePairs_8491660798716591",
            "onyxMethod": "merge",
            "value": {
                "chatType": "",
                "description": "",
                "parentReportActionID": "245929997925888734",
                "parentReportID": "7730730594068390"
            }
        },
        {
            "key": "report_8491660798716591",
            "onyxMethod": "merge",
            "value": {
                "chatType": "",
                "description": "",
                "lastActorAccountID": 21091638,
                "lastMessageText": "huult+03242949242242@gmail.com ",
                "lastVisibleActionCreated": "2025-12-29 07:42:11.872",
                "managerID": null,
                "ownerAccountID": 0,
                "parentReportActionID": "245929997925888734",
                "parentReportID": "7730730594068390",
                "policyID": "B2E2C2A6310459F2",
                "reportID": "8491660798716591",
                "reportName": "Chat Report",
                "state": "OPEN",
                "stateNum": 0,
                "statusNum": 0,
                "type": "chat",
                "visibility": null
            }
        },
        {
            "key": "reportActions_8491660798716591",
            "onyxMethod": "merge",
            "shouldShowPushNotification": true,
            "value": {
                "7967640082084948723": {
                    "actionName": "MODIFIEDEXPENSE",
                    "actorAccountID": 21091638,
                    "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_22.png",
                    "created": "2025-12-29 08:22:14.096",
                    "lastModified": "2025-12-29 08:22:14.096",
                    "message": [
                        {
                            "html": "huult+03242949242242@gmail.com ",
                            "text": "huult+03242949242242@gmail.com",
                            "type": "COMMENT",
                            "whisperedTo": []
                        }
                    ],
                    "originalMessage": {
                        "isNewDot": true,
                        "lastModified": "2025-12-29 08:22:14.096"
                    },
                    "person": [
                        {
                            "style": "strong",
                            "text": "TM",
                            "type": "TEXT"
                        }
                    ],
                    "reportActionID": "7967640082084948723",
                    "shouldShow": true
                }
            }
        },
        {
            "key": "reportActions_7730730594068390",
            "onyxMethod": "merge",
            "value": {
                "245929997925888734": {
                    "actionName": "IOU",
                    "actorAccountID": 21091638,
                    "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_22.png",
                    "created": "2025-12-29 07:42:09.798",
                    "lastModified": "2025-12-29 07:42:09.798",
                    "message": [
                        {
                            "html": "\u20ab23 expense",
                            "text": "\u20ab23 expense",
                            "type": "COMMENT",
                            "whisperedTo": []
                        }
                    ],
                    "originalMessage": {
                        "IOUReportID": 7730730594068390,
                        "IOUTransactionID": "4798280820925149892",
                        "amount": 2300,
                        "comment": "",
                        "currency": "VND",
                        "isNewDot": true,
                        "lastModified": "2025-12-29 07:42:09.798",
                        "participantAccountIDs": [
                            21091638,
                            0
                        ],
                        "type": "create"
                    },
                    "person": [
                        {
                            "style": "strong",
                            "text": "TM",
                            "type": "TEXT"
                        }
                    ],
                    "reportActionID": "245929997925888734",
                    "shouldShow": true
                }
            }
        },
        {
            "key": "report_8491660798716591",
            "onyxMethod": "merge",
            "value": {
                "lastReadTime": "2025-12-29 08:22:14.096"
            }
        },
        {
            "key": "reportActions_742576667027986",
            "onyxMethod": "merge",
            "value": {
                "4352628338059460823": {
                    "childCanHold": true,
                    "childCanUnhold": false,
                    "childCommenterCount": 0,
                    "childLastActorAccountID": 21091638,
                    "childLastMoneyRequestComment": "",
                    "childLastVisibleActionCreated": "",
                    "childManagerAccountID": 21091638,
                    "childMoneyRequestCount": 1,
                    "childOldestFourAccountIDs": "",
                    "childOwnerAccountID": 21091638,
                    "childRecentReceiptTransactionIDs": {},
                    "childReportID": "7730730594068390",
                    "childReportName": "Expense Report 2025-12-29",
                    "childStateNum": 0,
                    "childStatusNum": 0,
                    "childType": "expense",
                    "childVisibleActionCount": 0,
                    "message": [
                        {
                            "html": "TM's Workspace owes \u20ab23",
                            "text": "TM's Workspace owes \u20ab23",
                            "type": "COMMENT",
                            "whisperedTo": []
                        }
                    ],
                    "originalMessage": {
                        "isNewDot": true,
                        "lastModified": "2025-12-29 07:42:09.802",
                        "linkedReportID": "7730730594068390"
                    }
                }
            }
        },
        {
            "key": "transactionViolations_",
            "onyxMethod": "mergecollection",
            "value": {
                "transactionViolations_4798280820925149892": [
                    {
                        "data": null,
                        "name": "taxOutOfPolicy",
                        "showInReview": true,
                        "type": "violation"
                    }
                ]
            }
        },
        {
            "key": "transactions_4798280820925149892",
            "onyxMethod": "merge",
            "value": {
                "amount": -2300,
                "bank": "",
                "billable": false,
                "cardID": 23662666,
                "cardName": "Cash Expense",
                "cardNumber": "",
                "category": "Advertising",
                "comment": {
                    "comment": ""
                },
                "convertedAmount": -2300,
                "created": "2025-12-29",
                "currency": "VND",
                "hasEReceipt": false,
                "inserted": "2025-12-29 07:42:09",
                "managedCard": false,
                "mcc": 0,
                "merchant": "M",
                "modifiedAmount": "",
                "modifiedCreated": "",
                "modifiedCurrency": "",
                "modifiedMCC": "",
                "modifiedMerchant": "",
                "originalAmount": 0,
                "originalCurrency": "",
                "parentTransactionID": "",
                "posted": "",
                "receipt": null,
                "reimbursable": true,
                "reportID": "7730730594068390",
                "status": "Posted",
                "tag": "",
                "taxAmount": -596,
                "taxCode": "id_TAX_RATE_2",
                "taxValue": "35%", // I would like to change this value to 40%.
                "transactionID": "4798280820925149892"
            }
        },
        {
            "key": "report_7730730594068390",
            "onyxMethod": "merge",
            "value": {
                "avatarUrl": null,
                "chatReportID": "742576667027986",
                "chatType": "",
                "created": "2025-12-29 07:42:09",
                "currency": "VND",
                "description": "",
                "errorFields": {
                    "export": null,
                    "notFound": null
                },
                "fieldList": null,
                "hasExportError": false,
                "hasOutstandingChildRequest": false,
                "hasOutstandingChildTask": false,
                "hasParentAccess": true,
                "hasReportBeenReopened": false,
                "hasReportBeenRetracted": false,
                "invoiceReceiver": null,
                "iouReportID": null,
                "isCancelledIOU": false,
                "isDeletedParentAction": null,
                "isExportedToIntegration": false,
                "isPinned": false,
                "isWaitingOnBankAccount": false,
                "lastActionType": "CREATED",
                "lastActorAccountID": "21091638",
                "lastMentionedTime": null,
                "lastMessageHtml": "",
                "lastMessageText": "",
                "lastReadSequenceNumber": 0,
                "lastReadTime": "2025-12-29 08:22:00.726",
                "lastVisibleActionCreated": "2025-12-29 07:42:09.795",
                "lastVisibleActionLastModified": "2025-12-29 07:42:09.795",
                "managerID": 21091638,
                "nonReimbursableTotal": 0,
                "oldPolicyName": "",
                "ownerAccountID": 21091638,
                "parentReportActionID": "4352628338059460823",
                "parentReportID": "742576667027986",
                "participants": {
                    "21091638": {
                        "notificationPreference": ""
                    }
                },
                "permissions": [],
                "policyAvatar": null,
                "policyID": "B2E2C2A6310459F2",
                "policyName": null,
                "private_isArchived": "",
                "reportID": "7730730594068390",
                "reportName": "Expense Report 2025-12-29",
                "stateNum": 0,
                "statusNum": 0,
                "total": -2300,
                "transactionCount": 1,
                "tripData": null,
                "type": "expense",
                "unheldNonReimbursableTotal": 0,
                "unheldTotal": -2300,
                "visibility": null,
                "welcomeMessage": "",
                "writeCapability": "all"
            }
        },
        {
            "key": "reportNameValuePairs_7730730594068390",
            "onyxMethod": "merge",
            "value": {
                "expensify_text_title": {
                    "defaultExternalID": "",
                    "defaultValue": "{report:type} {report:startdate}",
                    "deletable": true,
                    "disabledOptions": [],
                    "externalID": null,
                    "externalIDs": [],
                    "fieldID": "text_title",
                    "isTax": false,
                    "keys": [],
                    "name": "title",
                    "orderWeight": 0,
                    "origin": null,
                    "target": "expense",
                    "type": "formula",
                    "value": "Expense Report 2025-12-29",
                    "values": []
                },
                "parentReportActionID": 4352628338059460823,
                "parentReportID": 742576667027986
            }
        },
        { // It should remove the taxOutOfPolicy violation.
            "key": "transactionViolations_",
            "onyxMethod": "mergecollection",
            "value": {
                "transactionViolations_4798280820925149892": [
                    {
                        "data": null,
                        "name": "taxOutOfPolicy",
                        "showInReview": true,
                        "type": "violation"
                    }
                ]
            }
        }
    ],
    "previousUpdateID": 9523081771,
    "lastUpdateID": 9523082270
}

MonilBhavsar · 2025-12-29T09:07:48Z

Thanks for sharing! Will take a look

…fter-edit

thesahindia · 2026-03-16T07:39:39Z

Login to your account on two different browser or devices
On device A: Go to workspace > Taxes > Add new tax rate
On device B: Submit an expense with the newly added tax rate
Open the expense preview
On device A: Click on the newly add tax and change the percentage
On device B: Verify that tax percentage doesn't update

IuliiaHerets · 2026-03-16T09:38:52Z

Chrome / v9.3.37-9 PR:78472
Passed

Screen.Recording.2026-03-16.at.11.33.04.mp4

MonilBhavsar · 2026-03-16T09:42:02Z

Thank you for testing! cc @thesahindia

thesahindia

Works well!

MonilBhavsar · 2026-03-16T11:04:03Z

Thanks @thesahindia! Looks like PR reviewer checklist needs an update?

thesahindia · 2026-03-16T11:05:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-12.at.1.13.59.PM.mov

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2026-03-12.at.4.39.24.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-03-12.at.4.42.55.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-12.at.4.56.15.PM.mov

thesahindia · 2026-03-16T11:06:57Z

Please rerun the checks again @MonilBhavsar

MonilBhavsar

looking good!

MonilBhavsar · 2026-03-16T11:27:47Z

src/components/ReportActionItem/MoneyRequestView.tsx

-    const taxRateTitle = updatedTransaction ? getTaxName(policy, updatedTransaction, isExpenseUnreported) : getTaxName(policy, transaction, isExpenseUnreported);
+
+    const baseTransaction = updatedTransaction ?? transaction;
+    const {taxCode, taxValue} = transaction ?? {};


Should it read tax values from baseTransaction?

Yes, I updated it to use baseTransaction for the merge/duplicate flow.

…fter-edit

MonilBhavsar · 2026-03-18T05:36:37Z

Thanks all! This is looking good

github-actions · 2026-03-18T05:38:11Z

🚧 @MonilBhavsar has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-18T05:42:53Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #78472.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e4c8216-84e475f-77d09b73609720c3600ee9a5e3eae06352e51080/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e4c8216-84e475f-504ddab03ed9b6fbb0e6cb65555a77d56cfbdb77/index.html

Web 🕸️
https://78472.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-18T13:28:39Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T14:04:40Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mitarachim · 2026-03-19T03:02:34Z

Deploy Blocker #85729 was identified to be related to this PR.

mitarachim · 2026-03-19T03:13:19Z

Deploy Blocker #85730 was identified to be related to this PR.

OSBotify · 2026-03-23T09:24:30Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Improve deleted tax behavior

6999b0c

huult requested review from a team as code owners December 26, 2025 06:24

melvin-bot bot assigned huult Dec 26, 2025

melvin-bot bot requested review from thesahindia and removed request for a team December 26, 2025 06:24

melvin-bot bot requested review from JmillsExpensify, flaviadefaria, heyjennahay, joekaufmanexpensify and trjExpensify and removed request for a team December 26, 2025 06:24

github-actions bot reviewed Dec 26, 2025

View reviewed changes

src/components/TaxPicker.tsx Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 26, 2025

View reviewed changes

src/components/TaxPicker.tsx Outdated Show resolved Hide resolved

huult marked this pull request as draft December 26, 2025 06:28

huult added 5 commits December 29, 2025 12:37

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

4e80669

…fter-edit

Handle case where tax value changes

2e421b1

update case where tax value changes

c8f59f2

fix perf-4

d9ff23b

Rename variables for clarity

37e04f1

huult marked this pull request as ready for review December 29, 2025 08:21

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

428ca4a

…fter-edit

thesahindia approved these changes Mar 16, 2026

View reviewed changes

MonilBhavsar reviewed Mar 16, 2026

View reviewed changes

huult added 4 commits March 16, 2026 20:59

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

58ab3a8

…fter-edit

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

f530db5

…fter-edit

update to use baseTransaction

499681a

Merge remote-tracking branch 'upstream/main' into 73033-invalid-tax-a…

915d5fa

…fter-edit

MonilBhavsar approved these changes Mar 18, 2026

View reviewed changes

MonilBhavsar merged commit e4c8216 into Expensify:main Mar 18, 2026
31 checks passed

github-actions bot mentioned this pull request Mar 18, 2026

Investigate workflow job failing on main: chooseDeployActions #85615

Closed

OSBotify mentioned this pull request Mar 18, 2026

Deploy Checklist: New Expensify 2026-03-18 #85646

Closed

100 tasks

lanitochka17 mentioned this pull request Mar 18, 2026

[Due for payment 2026-03-30] Expense - Disabled tax rate appears twice when submitting expense from self DM #85652

Closed

7 tasks

mitarachim mentioned this pull request Mar 19, 2026

[Due for payment 2026-03-30] Tax -Tax menu item is empty when Taxes are enabled after creating expense #85729

Closed

7 tasks

mitarachim mentioned this pull request Mar 19, 2026

[Due for payment 2026-03-30] Tax - Tax field is blank when expense is created offline #85730

Closed

7 tasks

MonilBhavsar mentioned this pull request Mar 19, 2026

[CP Staging] Revert "Improve deleted tax behavior" #85738

Merged

lanitochka17 mentioned this pull request Mar 19, 2026

[$250] Expense - Tax violation message briefly shown and disappeared. #85810

Open

7 tasks

melvin-bot bot mentioned this pull request Mar 23, 2026

[Due for payment 2026-03-30] [$250] Tax - Tax is no longer valid error shown in IOU details after editing tax rate value #73033

Open

16 tasks

Conversation

huult commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 26, 2025

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Dec 26, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

huult commented Dec 29, 2025

Uh oh!

MonilBhavsar commented Dec 29, 2025

Uh oh!

huult commented Dec 29, 2025

Uh oh!

MonilBhavsar commented Dec 29, 2025

Uh oh!

huult commented Dec 29, 2025

Uh oh!

MonilBhavsar commented Dec 29, 2025

Uh oh!

thesahindia commented Mar 16, 2026

Uh oh!

IuliiaHerets commented Mar 16, 2026

Uh oh!

MonilBhavsar commented Mar 16, 2026

Uh oh!

thesahindia left a comment

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar commented Mar 16, 2026

Uh oh!

thesahindia commented Mar 16, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

thesahindia commented Mar 16, 2026

Uh oh!

MonilBhavsar left a comment

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

huult Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar commented Mar 18, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

mitarachim commented Mar 19, 2026

Uh oh!

mitarachim commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

huult commented Dec 26, 2025 •

edited

Loading

codecov bot commented Dec 26, 2025 •

edited by github-actions bot

Loading