Skip to content

[CP Staging] Revert "Improve deleted tax behavior"#85738

Merged
cristipaval merged 1 commit intomainfrom
revert-78472-73033-invalid-tax-after-edit
Mar 19, 2026
Merged

[CP Staging] Revert "Improve deleted tax behavior"#85738
cristipaval merged 1 commit intomainfrom
revert-78472-73033-invalid-tax-after-edit

Conversation

@MonilBhavsar
Copy link
Contributor

@MonilBhavsar MonilBhavsar commented Mar 19, 2026 •
edited by cristipaval
Loading

Reverts #78472

Fixed Issues

$ #85652
$ #85729
$ #85730

cristipaval
cristipaval approved these changes Mar 19, 2026
View reviewed changes
Copy link
Contributor

@cristipaval cristipaval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@MonilBhavsar MonilBhavsar marked this pull request as ready for review March 19, 2026 07:59
@MonilBhavsar MonilBhavsar requested review from a team as code owners March 19, 2026 07:59
@melvin-bot melvin-bot bot requested review from heyjennahay and removed request for a team March 19, 2026 07:59
@cristipaval cristipaval changed the title Revert "Improve deleted tax behavior" [CP Staging] Revert "Improve deleted tax behavior" Mar 19, 2026
@cristipaval cristipaval added the CP Staging marks PRs that have been CP'd to staging label Mar 19, 2026
@cristipaval cristipaval merged commit 1bc48dd into main Mar 19, 2026
40 of 43 checks passed
@cristipaval cristipaval deleted the revert-78472-73033-invalid-tax-after-edit branch March 19, 2026 07:59
@melvin-bot melvin-bot bot added the Emergency label Mar 19, 2026
@melvin-bot
Copy link

melvin-bot bot commented Mar 19, 2026

@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot requested review from lakchote and removed request for a team March 19, 2026 07:59
@melvin-bot
Copy link

melvin-bot bot commented Mar 19, 2026

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2026

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify pushed a commit that referenced this pull request Mar 19, 2026
@cristipaval @OSBotify
Merge pull request #85738 from Expensify/revert-78472-73033-invalid-t…
4c39468 
…ax-after-edit

[CP Staging] Revert "Improve deleted tax behavior"

(cherry picked from commit 1bc48dd)

(cherry-picked to staging by cristipaval)
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85738.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1bc48dd-6d2fe73-68247c3c1afac5f7c5af029f798e46bfe8d34056/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1bc48dd-6d2fe73-990920827ac298a57501cee58281e6f34379b818/index.html
Android iOS
Web 🕸️
https://85738.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request Mar 19, 2026
Closed
100 tasks
@codecov
Copy link

codecov bot commented Mar 19, 2026 •
edited by github-actions bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/TaxPicker.tsx 0.00% <ø> (ø)
...c/components/ReportActionItem/MoneyRequestView.tsx 0.23% <0.00%> (+<0.01%) ⬆️
...ges/iou/request/step/IOURequestStepTaxRatePage.tsx 0.00% <0.00%> (ø)
... and 10 files with indirect coverage changes

@OSBotify
Copy link
Contributor

OSBotify commented Mar 19, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 19, 2026

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.3.40-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Mar 19, 2026

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.3.40-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Mar 19, 2026

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.3.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify
Copy link
Contributor

OSBotify commented Mar 23, 2026

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

This was referenced Mar 23, 2026
Closed
Closed
@melvin-bot melvin-bot bot mentioned this pull request Mar 23, 2026
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cristipaval cristipaval cristipaval approved these changes

@heyjennahay heyjennahay Awaiting requested review from heyjennahay

@lakchote lakchote Awaiting requested review from lakchote

Assignees

@MonilBhavsar MonilBhavsar

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MonilBhavsar @OSBotify @cristipaval