[CP Staging] Revert 79085 & 77238 by arosiclair · Pull Request #79145 · Expensify/App

arosiclair · 2026-01-08T20:44:49Z

Explanation of Change

Fixed Issues

This reverts commit 63b3857, reversing changes made to 883e8ec.

This reverts commit 454e537, reversing changes made to 5014512.

melvin-bot · 2026-01-08T20:48:55Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-01-08T20:53:57Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`83.47% <ø> (ø)`
src/components/MoneyReportHeader.tsx	`0.00% <ø> (ø)`
...ents/ReportActionItem/TransactionPreview/index.tsx	`83.87% <100.00%> (ø)`
src/components/TransactionItemRow/index.tsx	`87.12% <100.00%> (ø)`
src/libs/DistanceRequestUtils.ts	`81.34% <100.00%> (+16.41%)`	⬆️
src/libs/SearchUIUtils.ts	`59.32% <100.00%> (+0.14%)`	⬆️
src/libs/Violations/ViolationsUtils.ts	`67.37% <100.00%> (+0.90%)`	⬆️
src/libs/actions/IOU/index.ts	`67.48% <100.00%> (+56.22%)`	⬆️
src/libs/actions/Policy/Member.ts	`72.75% <ø> (+2.72%)`	⬆️
...rc/pages/iou/request/step/IOURequestStepAmount.tsx	`4.12% <ø> (+0.04%)`	⬆️
... and 19 more
... and 108 files with indirect coverage changes

melvin-bot · 2026-01-08T20:56:19Z

@arosiclair looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c309dc047

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-08T20:58:46Z

src/components/Search/index.tsx

            reportID: item.reportID,
            policyID: item.report?.policyID,
-            amount: hasValidModifiedAmount(item) ? Number(item.modifiedAmount) : item.amount,
+            amount: item.modifiedAmount ?? item.amount,


Fall back to original amount when modifiedAmount is 0

Using item.modifiedAmount ?? item.amount treats an explicitly set modifiedAmount of 0 as valid, but the rest of the app uses 0 as the “unset/missing” sentinel (e.g., other views use modifiedAmount || amount). When a transaction has a real non‑zero amount and modifiedAmount is stored as 0 (common for unmodified transactions), this selection entry will carry amount = 0, which then flows into selected report totals and bulk actions/export. The bug appears whenever modifiedAmount is explicitly 0, causing totals for selected items to be wrong.

Useful? React with 👍 / 👎.

arosiclair · 2026-01-08T21:00:53Z

straight revert

[CP Staging] Revert 79085 & 77238 (cherry picked from commit d09fa19) (cherry-picked to staging by arosiclair)

OSBotify · 2026-01-08T21:05:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-08T21:45:54Z

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.96-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-09T18:19:24Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

OSBotify · 2026-01-09T19:15:46Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-09T19:22:42Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-09T20:02:49Z

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.97-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-10T02:21:55Z

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.99-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-13T03:13:25Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.99-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

arosiclair added 2 commits January 8, 2026 15:42

Revert "Merge pull request #79085 from Expensify/alberto-cpDist"

c79537c

This reverts commit 63b3857, reversing changes made to 883e8ec.

Revert "Merge pull request #77238 from Expensify/alberto-zeroV4"

6c309dc

This reverts commit 454e537, reversing changes made to 5014512.

arosiclair self-assigned this Jan 8, 2026

arosiclair changed the title ~~Revert 79085 & 77238~~ [CP Staging] Revert 79085 & 77238 Jan 8, 2026

arosiclair marked this pull request as ready for review January 8, 2026 20:48

arosiclair requested review from a team as code owners January 8, 2026 20:48

melvin-bot bot requested review from eVoloshchak and trjExpensify and removed request for a team January 8, 2026 20:48

melvin-bot bot requested review from a team and joekaufmanexpensify and removed request for a team January 8, 2026 20:48

Julesssss approved these changes Jan 8, 2026

View reviewed changes

arosiclair merged commit d09fa19 into main Jan 8, 2026
33 of 38 checks passed

arosiclair deleted the arosiclair-revert-79085-77238 branch January 8, 2026 20:56

This comment was marked as outdated.

Sign in to view

melvin-bot bot added the Emergency label Jan 8, 2026

chatgpt-codex-connector bot reviewed Jan 8, 2026

View reviewed changes

arosiclair removed the Emergency label Jan 8, 2026

OSBotify pushed a commit that referenced this pull request Jan 8, 2026

Merge pull request #79145 from Expensify/arosiclair-revert-79085-77238

e44dd29

[CP Staging] Revert 79085 & 77238 (cherry picked from commit d09fa19) (cherry-picked to staging by arosiclair)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jan 8, 2026

OSBotify mentioned this pull request Jan 8, 2026

Deploy Checklist: New Expensify 2026-01-08 #79110

Closed

76 tasks

Conversation

arosiclair commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Uh oh!

melvin-bot bot commented Jan 8, 2026

Uh oh!

codecov bot commented Jan 8, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

This comment was marked as outdated.

melvin-bot bot commented Jan 8, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

arosiclair commented Jan 8, 2026

Uh oh!

OSBotify commented Jan 8, 2026

Uh oh!

OSBotify commented Jan 8, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 10, 2026

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

arosiclair commented Jan 8, 2026 •

edited

Loading

codecov bot commented Jan 8, 2026 •

edited by github-actions bot

Loading