Allow zero-amount expenses - ROUND 4

[Gonals]

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/557844
PROPOSAL:

Tests

Ok, there are a bunch of things here. All in newDot, in an account in the zero_expenses beta (or any expensify account):

• Confirm you can create a manual expense with zero as the amount. No violation should show.
• Confirm you can create a distance expense with zero as the distance. No violation should show.
• Confirm you can edit an existing manual expense to set the amount to zero. No violation should show.
• Confirm you can edit an existing receipt expense to set the amount to zero. No violation should show (beyond the amount being different to the smartscanned amount when relevant).
• Confirm you can edit an existing distance expense to set the distance to zero. No violation should show.
• Confirm you can edit an existing distance expense to set the amount to zero. No violation should show (beyond the amount being different to the calculated one when relevant).
• Confirm you can edit amounts/distances back to non-zero for all the above.
• Confirm that, when you create a zero-expense in the self-DM with no merchant, the merchant defaults to 'Expense', not '(none)' (it won't display, so check onyx)
• Zero amounts are still not allowed for splits
• Zero amounts are not allowed for P2P requests
• Zero amounts are allowed for self-DM
• Zero amounts are not allowed for accounts not on the beta

Offline tests

None

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

No real UI changes

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	83.47% <ø> (ø)
src/components/MoneyReportHeader.tsx	0.00% <ø> (ø)
...ents/ReportActionItem/TransactionPreview/index.tsx	83.87% <100.00%> (ø)
src/components/TransactionItemRow/index.tsx	87.12% <100.00%> (ø)
src/libs/DistanceRequestUtils.ts	81.34% <100.00%> (ø)
src/libs/SearchUIUtils.ts	59.00% <100.00%> (+0.06%)	⬆️
src/libs/TransactionPreviewUtils.ts	72.67% <100.00%> (+1.40%)	⬆️
src/libs/Violations/ViolationsUtils.ts	69.66% <ø> (+1.68%)	⬆️
src/libs/actions/IOU/index.ts	67.42% <100.00%> (-0.01%)	⬇️
src/libs/actions/Policy/Member.ts	73.96% <ø> (ø)
... and 19 more
... and 23 files with indirect coverage changes

[JmillsExpensify]

Thanks for the extensive test cases. Approved by product.

[Gonals]

Still fighting some issues with this one.

[Gonals]

Not sure if you need my review but there are conflicts.

So many conflicts

[Gonals]

Bug: cannot edit a non-zero distance to zero in offline mode.

Should it block this PR?

77238-bug-5.mov

I have not been able to reproduce this. It works fine for me

[Gonals]

@AndrewGable, @blimpich, all yours

[Gonals]

Found frontend fix for #76993 and #76896, so fixed them

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[Julesssss]

Hey @Gonals I think this introduced a regression. On main I can no longer create distance requests because participant selection doesn't work (no participant is suggested, and emails aren't selectable). Here's the issue for the regression.

This logic sets isWorkspacesOnly = true when the transaction amount is <= 0. It looks like amount is calculated later for distance flows.

Steps:

• Create > Distance Expense > Enter anything > Enter email at recipient page > Nothing selectable shows up

[OSBotify]

🚀 Deployed to staging by https://github.com/Gonals in version: 9.2.96-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[lanitochka17]

This PR is failing because of issue ##79124

The issue is reproducible in: Web

Bug7043827_1767890060616.6.1.mp4

[lanitochka17]

This PR is failing because of issue ##79127

The issue is reproducible in: Web

Bug7043826_1767890059513.5.1.mp4

[OSBotify]

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

[OSBotify]

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/Gonals in version: 9.2.97-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/Gonals in version: 9.2.99-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.99-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅