[A11y] Keyboard & Inputs

[rushatgabhane]

Explanation of Change

Part of

• https://github.com/Expensify/Expensify/issues/575078

Fixes keyboard navigation and input accessibility issues by adding proper roles, labels, and states to interactive elements.

Fixed Issues

$ #76903
$ #76907
$ #76910
$ #76911
$ #76947
$ #76949
$ #76952
$ #76959
$ #77561
$ #77570

$ #77498

Tests

Enable VoiceOver

Test 1: Workspace Categories - Switch Announcements (#76903)

1. Navigate to any Workspace → Categories
2. Tab/swipe to focus on a category toggle switch
3. Expected: Switch announces category name (e.g., "Enable Advertising category,
   switch, on")
4. Previous bug: All switches announced identically as "Enable category, switch,
   on/off"

---

Test 2: Workspace Reports/Rules - Switch with Description (#76907)

1. Navigate to Workspace → Reports (or Rules, More Features)
2. Tab to the "Report fields" toggle switch
3. Expected: Announces both label AND description (e.g., "Report fields, Report
   fields apply to all spend...")
4. Previous bug: Only announced "Report fields" without description

---

Test 3: Workspace More Options Button (#76910)

1. Navigate to Workspaces section
2. Tab to the three-dot "More options" icon button
3. Expected: Announces "More, button" (with button role)
4. Previous bug: Announced only "More options" without button role (had
   role="presentation")

---

Test 4: Duplicate Workspace Checkboxes (#76911)

1. Workspace → More options → Duplicate Workspace → Next
2. Tab to checkboxes (e.g., "Reports")
3. Expected: Announces full context (e.g., "Reports, 3 report fields, checkbox")
4. Previous bug: Only announced "Reports" without descriptive text

---

Test 5: FAB Buttons - No Redundant Text (#76947)

1. Go to Settings → Profile
2. Tab to "Scan receipt" and "Start chat" buttons (bottom left)
3. Expected: Announces "Scan receipt, button" and "Start chat, button"
4. Previous bug: Announced "Scan receipt (Floating action)"

---

Test 6: Security Page - Learn More Link (#76949)

1. Navigate to Settings → Security
2. Tab to "Learn more" link under Copilot section
3. Expected: Announces descriptive purpose (e.g., "Learn more about delegated access,
   link")
4. Previous bug: Only announced "Learn more, link"

---

Test 7: Date Picker Controls (#77561)

1. Go to Settings → Profile → Date of birth
2. When calendar opens, navigate through controls (year selector, prev/next arrows,
   dates)
3. Expected: All controls announce with "button" role
4. Previous bug: Announced as text only ("12", "Next") without role

---

Test 8: PopoverMenu Back Button (#76959)

1. Create an expense → More → Export
2. Tab to the back arrow with "Export" text
3. Expected: Announces "Go back, Export" or similar with context
4. Previous bug: Only announced "Export" without back navigation context

---

Test 9: "+" Create Button (#77498)

1. Open any chat
2. Focus on the "+" button
3. Expected: Announces descriptive label like "Create" or "Open actions menu, button"
4. Previous bug: Announced vaguely as "create" without button role context

• Verify that no errors appear in the JS console

Offline tests

N/A - These are accessibility attribute changes that don't affect offline behavior.

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A - Accessibility attribute changes

Android: mWeb Chrome

N/A - Accessibility attribute changes

iOS: Native

N/A - Accessibility attribute changes

iOS: mWeb Safari

N/A - Accessibility attribute changes

MacOS: Chrome / Safari

N/A - Accessibility attribute changes

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[melvin-bot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[melvin-bot]

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/AmountTextInput.tsx	100.00% <ø> (ø)
src/components/DatePicker/CalendarPicker/index.tsx	83.87% <ø> (ø)
src/components/MenuItem.tsx	87.19% <100.00%> (+0.06%)	⬆️
src/components/PopoverMenu.tsx	79.25% <100.00%> (+0.11%)	⬆️
...components/SelectionList/ListItem/BaseListItem.tsx	91.83% <100.00%> (+2.04%)	⬆️
...ponents/SelectionListWithSections/BaseListItem.tsx	95.55% <100.00%> (ø)
...c/pages/settings/Security/SecuritySettingsPage.tsx	0.00% <ø> (ø)
...s/workspace/categories/WorkspaceCategoriesPage.tsx	59.60% <ø> (ø)
...es/workspace/workflows/ToggleSettingsOptionRow.tsx	81.57% <100.00%> (+0.49%)	⬆️
src/components/Banner.tsx	0.00% <0.00%> (ø)
... and 2 more
... and 119 files with indirect coverage changes

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cee5adfe9c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[cead22]

Conflicts

[rushatgabhane]

@cead22 resolved

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/cead22 in version: 9.3.7-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[IuliiaHerets]

@rushatgabhane PR failed with such original issues:

• [Due for payment 2026-01-30] Screen Reader: Workspaces: Checkboxes are announced without part of the displayed text #76911
• [Due for payment 2026-03-19] [Due for payment 2026-01-30] Screen Reader: Settings-Security: The link is announced non-descriptively #76949

[Pujan92]

@IuliiaHerets can you plz share the screenshot/recording for it as it seems to fixed for me.

@rushatgabhane PR failed with such original issues:

• Screen Reader: Workspaces: Checkboxes are announced without part of the displayed text #76911

---

• Screen Reader: Settings-Security: The link is announced non-descriptively #76949

Link area label text is - Copilot: Delegated access

[OSBotify]

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.7-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

[Pujan92]

@cead22 @rushatgabhane could you plz assign me to the issue where payment can be tracked