Skip to content

Remove interactive role and double announcement for switches#80765

Merged
Valforte merged 10 commits intoExpensify:mainfrom
Uzaifm127:fix/79243
Feb 25, 2026
Merged

Remove interactive role and double announcement for switches#80765
Valforte merged 10 commits intoExpensify:mainfrom
Uzaifm127:fix/79243

Conversation

@Uzaifm127
Copy link
Contributor

@Uzaifm127 Uzaifm127 commented Jan 28, 2026

Explanation of Change

  1. Removed the double announcement for Switches.
  2. Removed the "double tap to activate" for menu item for plain text in Android/iOS.

Fixed Issues

$ #79243
$ #77497
$ #77496
PROPOSAL: #79243 (comment)

Tests

Test 1: Double announcement for switches.

Precondition: User is logged in.

  1. Using VoiceOver on iOS or TalkBack on Android, open the app.
  2. Swipe right to focus the Workspaces tab and double-tap to activate it.
  3. Choose a workspace, if workspace list is there otherwise skip this step.
  4. Swipe right to focus the More features option and double-tap to activate it.
  5. Swipe right to focus on any switch on More features.
  6. Verify that each switch is announced only once.

Other occurrence for this:

From Step 2 or 3.

  1. Swipe right to focus the Workflows option and double-tap to activate it.
  2. Swipe right to focus on "Submissions", "Approvals" and "Payment" switches.
  3. Verify that each switch is announced only once.

Test 2: Plain text announced as actionable (Android)

Precondition: You must have a virtual Expensify Card issued and visible in the wallet.

  1. Enable TalkBack on Android.
  2. Open the Expensify app.
  3. Swipe right to focus the Account tab and double-tap to activate it.
  4. Swipe right to focus the Wallet button and double-tap to activate it.
  5. Swipe right to focus the Expensify Card menu item near "Assigned cards" and double-tap to activate it.
  6. Swipe right to focus either on "Virtual card number", "Remaining limit" or Smart limit" menu item.
  7. Verify that Talkback doesn't announce "double tap to activate it".

Test 3: Toggle/checkbox label announced twice - #77497

Precondition: User is logged in.

  1. Using VoiceOver on iOS or TalkBack on Android, open the app or open the web app on Android chrome.
  2. Swipe right to focus the Account tab and double-tap to activate it.
  3. Swipe right to focus the Preferences button and double-tap to activate it.
  4. Swipe right to focus the toggle buttons and the visible text next to toggle buttons.
  5. Verify that Only the toggle buttons receive focus.
  6. Verify that the visible text next to the toggle is not be focusable.
  7. Verify that screen readers announce the label once via the toggle
  • Verify that no errors appear in the JS console

Offline tests

These are accessibility changes that don't affect offline behavior.

QA Steps

Same as tests

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Double announcement for switches.

Android-native-3.mov

Plain text announced as actionable

Android-native-2.mov

Toggle/checkbox label announced twice

Android-native-1.mov
Android: mWeb Chrome

Double announcement for switches.

Android-mWeb-3.mov

Plain text announced as actionable

Android-mWeb-2.mov

Toggle/checkbox label announced twice

Android-mWeb-1.mov
iOS: Native

Double announcement for switches.

ios-native-3.mov

Toggle/checkbox label announced twice

ios-native-1.mp4
iOS: mWeb Safari

Double announcement for switches.

ios-mWeb-3.mov

Toggle/checkbox label announced twice

ios-mWeb-1.mov
MacOS: Chrome / Safari Screenshot 2026-02-13 at 10 24 11 PM

@Uzaifm127 Uzaifm127 changed the title Fix/79243 Remove interactive role and double announcement for switches Jan 28, 2026
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/ImportSpreadsheetColumns.tsx 0.00% <ø> (ø)
src/components/MenuItem.tsx 88.34% <100.00%> (+0.05%) ⬆️
...c/components/ReportActionItem/MoneyRequestView.tsx 0.24% <ø> (ø)
src/components/TestToolMenu.tsx 88.57% <100.00%> (+1.07%) ⬆️
src/components/TestToolRow.tsx 100.00% <100.00%> (ø)
...ages/workspace/categories/CategorySettingsPage.tsx 0.00% <ø> (ø)
...ges/workspace/rules/RulesProhibitedDefaultPage.tsx 0.00% <ø> (ø)
src/pages/workspace/tags/TagSettingsPage.tsx 0.00% <ø> (ø)
...pages/workspace/tags/WorkspaceTagsSettingsPage.tsx 0.00% <ø> (ø)
src/pages/domain/Saml/SamlLoginSectionContent.tsx 0.00% <0.00%> (ø)
... and 10 more
... and 12 files with indirect coverage changes

@Uzaifm127 Uzaifm127 marked this pull request as ready for review January 29, 2026 14:39
@Uzaifm127 Uzaifm127 requested review from a team as code owners January 29, 2026 14:39
@melvin-bot
Copy link

melvin-bot bot commented Jan 29, 2026

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Uzaifm127
Copy link
Contributor Author

@dominictb Here is the overview of this PR.

We've got two issues.

  1. #77497 - Not reproducible now
  2. #77496 - Reproducible now

The first issue isn't reproducible so instead of that we are covering this issue pointed out by @dominictb

I've provided the recordings on Android native for both issues we are solving in this PR. We might need to run the test build for this to check on other platforms.

@Uzaifm127
Copy link
Contributor Author

@joekaufmanexpensify @dominictb Kindly bump for PR review.

Copy link
Contributor

@joekaufmanexpensify joekaufmanexpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine from a product perspective

@mallenexpensify
Copy link
Contributor

@Uzaifm127 apologies for the delay from @dominictb , they're offboarding. I pinged them in Slack to see if they'll review or if we need a new C+

Copy link
Contributor

@dominictb dominictb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally when the implementation deviates from the initial proposal, we'd ask to update the proposal first.

<Switch
disabledAction={disabledAction}
accessibilityLabel={typeof subtitle === 'string' && subtitle ? `${switchAccessibilityLabel}, ${subtitle}` : switchAccessibilityLabel}
accessibilityLabel={
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain a bit about your fix here for #79590 (comment)?

Also, can you also give a brief description why the first issue #77497 is no longer reproducible? But we only had this instance left? Are there any similar instances?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain a bit about your fix here for #79590 (comment)?

#79590 (comment) - This issue is the regression from this PR: #79149, so we aren't removing this completely instead we only preventing it if the accessibilityLabel and subtitle are same.

Also, can you also give a brief description why the first issue #77497 is no longer reproducible? But we only had this instance left? Are there any similar instances?

When I made my proposal, I made it in a hurry and I was brief about the issue. In the PR phase, when I deeply investigated the issues and tested in real android devices then I found the first issue not reproducible so I reverted my fix for first issue.

But we only had this instance left

If you're asking for the issue which we found here then we have several instances in the application but all the instances stems from src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx component as we used ToggleSettingOptionRow in several places, so fixing this ToggleSettingOptionRow will cover every instance.

accessibilityLabel={accessibilityLabel ?? defaultAccessibilityLabel}
accessible={shouldBeAccessible}
tabIndex={tabIndex}
tabIndex={getPlatform() !== CONST.PLATFORM.WEB && !interactive ? -1 : tabIndex}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why we previously need to set role, accessible and accessibilityLabel based on interactive. But now we only have tabIndex?

Copy link
Contributor Author

@Uzaifm127 Uzaifm127 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously we were trying to make the non interactive menu items non focusable but we don't need to make them non focusable, only "double tap to activate it" shouldn't be there in android and ios and setting the tab index to -1 would work.

I got to know about this when I was testing this in real android device and we are preventing it from web as setting tabIndex to -1 will make menu item non focusable in web which isn't the expected behaviour in the issue.

@Uzaifm127
Copy link
Contributor Author

Normally when the implementation deviates from the initial proposal, we'd ask to update the proposal first.

@dominictb Should I update my proposal first or we should move with the PR changes?

@Uzaifm127 Uzaifm127 requested a review from dominictb February 9, 2026 04:55
@dominictb
Copy link
Contributor

dominictb commented Feb 9, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp Screenshot_1771350750
Android: mWeb Chrome
Screen.Recording.2026-02-18.at.00.38.01.mov
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari Screenshot 2026-02-09 at 22 36 55 Screenshot 2026-02-09 at 22 36 34 Screenshot 2026-02-09 at 22 42 21

@dominictb

This comment was marked as resolved.

@dominictb
Copy link
Contributor

dominictb commented Feb 9, 2026

Both of the issues are not fixed for me:

Screen.Recording.2026-02-09.at.23.37.30.mov
Screen.Recording.2026-02-09.at.23.31.18.mov

@Uzaifm127
Copy link
Contributor Author

Will look into it.

@Uzaifm127
Copy link
Contributor Author

@dominictb Thanks for pointing out that the issue #77497 is reproducible.

When I said

#77497 - Not reproducible now

Then I only tested it on Android native and macOS, but it was reproducible on mWeb (Android and iOS) and iOS native.

For MenuItem.tsx issue, this issue was fixed in Android native by setting tabIndex to -1 but was still reproducible on Android mWeb. Now I fixed on mWeb and native android.

Now we are solving all three issues in all platforms, I added the video recordings and updated the PR description.

Let me know if that sounds good to you.

const {isAccordionExpanded, shouldAnimateAccordionSection} = useAccordionAnimation(isActive);

// We are disabling the announcement for subtitle if subtitle and switchAccessibilityLabel are equal
const isSubtitleAndSwitchAccessibilityLabelAreEqual = switchAccessibilityLabel === subtitle;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const isSubtitleAndSwitchAccessibilityLabelAreEqual = switchAccessibilityLabel === subtitle;
const areSubtitleAndSwitchAccessibilityLabelEqual = switchAccessibilityLabel === subtitle;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied.

Comment on lines +149 to +151
* We hide the subtitle from screen readers if it is identical to the switch's accessibility label.
* 'aria-hidden' is used for compatibility with iOS mWeb, while 'accessible={false}'
* is required for iOS native.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* We hide the subtitle from screen readers if it is identical to the switch's accessibility label.
* 'aria-hidden' is used for compatibility with iOS mWeb, while 'accessible={false}'
* is required for iOS native.
* We hide the subtitle from screen readers to avoid double announcements
* 'aria-hidden' is used for compatibility with iOS mWeb, while 'accessible={false}' works on iOS native.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied.

Comment on lines +721 to +723
const platform = getPlatform(true);
// This is required because we are preventing the "double tap to activate" announcement on Android web
const isAndroidWeb = platform === CONST.PLATFORM.MOBILE_WEB && getOperatingSystem() === CONST.OS.ANDROID;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be moved out of functional component.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required now.

Comment on lines +721 to +723
const platform = getPlatform(true);
// This is required because we are preventing the "double tap to activate" announcement on Android web
const isAndroidWeb = platform === CONST.PLATFORM.MOBILE_WEB && getOperatingSystem() === CONST.OS.ANDROID;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const platform = getPlatform(true);
// This is required because we are preventing the "double tap to activate" announcement on Android web
const isAndroidWeb = platform === CONST.PLATFORM.MOBILE_WEB && getOperatingSystem() === CONST.OS.ANDROID;
const platform = getPlatform(true);
// This is required because we are preventing the "double tap to activate" announcement on Android web
const isAndroidWeb = Browser.isMobileChrome();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required now.

@dominictb
Copy link
Contributor

dominictb commented Feb 17, 2026

BUG

Virtual card number menu item and Reveal details button are announced as disabled. The button is unresponsive as well.

Screenshot_1771349649 Screenshot_1771349655

@dominictb
Copy link
Contributor

@Uzaifm127 How did you test VoiceOver on iOS?

@Uzaifm127
Copy link
Contributor Author

Uzaifm127 commented Feb 17, 2026

@dominictb I used accessibility inspector built in mac.

P.S - Looking into the bug.

@Uzaifm127
Copy link
Contributor Author

Uzaifm127 commented Feb 17, 2026

@dominictb I looked into the bug, this is occuring because we are giving fullDisabled to MenuItem which makes it and it's children disabled.

I found giving fullDisabled as the only way to fix this on Android chrome, this is too confusing as the platform is web (Android chrome) and in mac it is not announcing but with Talkback it is announcing on Android web. I tried every possible way I could.

A help would be appreciable from your side.

cc: @rushatgabhane

@rushatgabhane
Copy link
Member

@Uzaifm127 we could fix the bug on Android web in a follow up, if that helps unblock us.

@Uzaifm127
Copy link
Contributor Author

@dominictb As per @rushatgabhane

@Uzaifm127 we could fix the bug on Android web in a follow up, if that helps unblock us.

I've reverted the changes in MenuItem.tsx and keep the fix for Android native only and implemented your suggestions. You can review now.

Copy link
Contributor

@dominictb dominictb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎀

Copy link
Contributor

@situchan situchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just approving to assign engineer

@melvin-bot melvin-bot bot requested a review from Valforte February 24, 2026 02:33
@Valforte
Copy link
Contributor

Can you merge main to fix conflict so I can review?

@Uzaifm127
Copy link
Contributor Author

@Valforte Resolved the merge conflicts.

I've removed the fix from MenuItem.tsx file as this PR already fixed that.

Copy link
Contributor

@Valforte Valforte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Valforte Valforte merged commit 7475511 into Expensify:main Feb 25, 2026
27 checks passed
@github-actions
Copy link
Contributor

🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/Valforte in version: 9.3.26-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@izarutskaya
Copy link

Hi @Uzaifm127 Is verification required only for Android and iOS apps?

@Uzaifm127
Copy link
Contributor Author

Uzaifm127 commented Feb 25, 2026

@izarutskaya
For this #77496, only android native.
For this #77497, only android and ios.
For this (from PR description) Test 1: Double announcement for switches., on all platforms.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants