fix: Hide from Assistive Tech and Remove Interactive Role by Uzaifm127 · Pull Request #79590 · Expensify/App

Uzaifm127 · 2026-01-14T17:56:50Z

Explanation of Change

Two accessibility issues:

Toggle/checkbox labels announced twice: Text labels next to Switch components were being announced separately from the Switch's accessibilityLabel, causing duplicate announcements.
Plain text elements announced as actionable: MenuItem components with interactive={false} were still receiving accessibility props (role, accessibilityLabel, accessible) that made screen readers announce them as actionable elements.

Fixed Issues

$ #79243
$ #77497
$ #77496
PROPOSAL: #79243 (comment)

Tests

Enable VoiceOver (iOS/Mac) or TalkBack (Android)

First issue: Toggle/checkbox labels announced twice

Navigate to Settings > Preferences
- Swipe through toggle switches ("Receive relevant feature updates" and "Mute all sounds")
- Verify each label is announced only once (from the Switch, not from the Text)
Navigate to Workspace > Tags > Settings
- Swipe through "Requires tag" and "Track billable" switches
- Verify labels are announced only once
Navigate to Workspace > Tags > Tag Settings (open an individual tag)
- Swipe through the "Enable tag" switch
- Verify label is announced only once
Navigate to Workspace > Tags > Import Multi-Level Tags
- Swipe through all three switches ("First row is header", "Independent tags", "GL adjacent column")
- Verify each label is announced only once
Navigate to Workspace > Taxes > Edit Tax
- Swipe through the "Enable" switch
- Verify label is announced only once
Navigate to Workspace > Rules > Prohibited Expenses
- Swipe through prohibited expense toggles (Adult Entertainment, Alcohol, Gambling, Hotel Incidentals, Tobacco)
- Verify each label is announced only once
Navigate to Workspace > Categories > Category Settings
- Swipe through "Enable category" and "Require description" switches
- Verify labels are announced only once
Navigate to Workspace > Distance Rates > Settings
- Swipe through the "Track tax" switch
- Verify label is announced only once
Navigate to Domain > SAML Login Settings
- Swipe through "Enable SAML login" and "Require SAML login" switches
- Verify labels are announced only once
Navigate to Workspace > Report Fields > Value Settings
- Swipe through the "Enable value" switch
- Verify label is announced only once
Navigate to Settings > Profile > Timezone
- Swipe through the "Get location automatically" switch
- Verify label is announced only once

Second issue: Plain text elements announced as actionable

Navigate to Settings > Wallet > Expensify Card
- Swipe to "Virtual card number" (masked card number)
- Verify it's announced as static text without "double-tap to activate" hint
Navigate to Settings > Wallet > Card Details (after revealing card details)
- Swipe through card number, expiration, CVV, and address
- Verify all are announced as static text without actionable hints
Navigate to Workspace > Company Cards > Card Details
- Swipe through card number and available spend
- Verify they're announced as static text without actionable hints
Navigate to Workspace > Expensify Card > Card Details
- Swipe through card number and available spend
- Verify they're announced as static text without actionable hints
Navigate to Workspace > Report Fields > Settings
- Swipe through "Name" and "Type" fields
- Verify they're announced as static text without actionable hints
Navigate to Workspace > Members > Member Details
- Swipe through email/phone number field
- Verify it's announced as static text without actionable hints

Verify that no errors appear in the JS console

Offline tests

N/A - These are accessibility attribute changes that don't affect offline behavior or network requests.

QA Steps

Enable screen reader on device (VoiceOver on iOS/Mac or TalkBack on Android)
Navigate through all affected screens:
- Settings > Preferences
- Workspace > Tags > Settings
- Workspace > Tags > Tag Settings
- Workspace > Tags > Import Multi-Level Tags
- Workspace > Taxes > Edit Tax
- Workspace > Rules > Prohibited Expenses
- Workspace > Categories > Category Settings
- Workspace > Distance Rates > Settings
- Domain > SAML Login
- Workspace > Report Fields > Value Settings
- Settings > Profile > Timezone
- Settings > Wallet > Expensify Card
- Settings > Wallet > Card Details
- Workspace > Company Cards > Card Details
- Workspace > Expensify Card > Card Details
- Workspace > Report Fields > Settings
- Workspace > Members > Member Details
For each screen with toggle switches:
- Swipe through each switch
- Verify the label is announced only once (not duplicated)
For each screen with static text elements (card numbers, amounts, etc.):
- Swipe to static text elements
- Verify they're announced as static text without "double-tap to activate" hints

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A - Accessibility changes

Android: mWeb Chrome

N/A - Accessibility changes

iOS: Native

N/A - Accessibility changes

iOS: mWeb Safari

N/A - Accessibility changes

MacOS: Chrome / Safari

N/A - Accessibility changes

melvin-bot · 2026-01-14T17:56:57Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-01-14T17:57:03Z

@Valforte Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-01-14T18:05:44Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/MenuItem.tsx	`87.50% <100.00%> (+1.71%)`	⬆️
...ages/workspace/categories/CategorySettingsPage.tsx	`0.00% <ø> (ø)`
...ges/workspace/rules/RulesProhibitedDefaultPage.tsx	`0.00% <ø> (ø)`
src/pages/workspace/tags/TagSettingsPage.tsx	`0.00% <ø> (ø)`
...pages/workspace/tags/WorkspaceTagsSettingsPage.tsx	`0.00% <ø> (ø)`
src/pages/domain/Saml/SamlLoginSectionContent.tsx	`0.00% <0.00%> (ø)`
...orkspace/reports/ReportFieldsValueSettingsPage.tsx	`0.00% <0.00%> (ø)`
src/pages/workspace/taxes/WorkspaceEditTaxPage.tsx	`0.00% <0.00%> (ø)`
src/pages/settings/Preferences/PreferencesPage.tsx	`0.00% <0.00%> (ø)`
src/pages/settings/Profile/TimezoneInitialPage.tsx	`0.00% <0.00%> (ø)`
... and 2 more
... and 177 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d3e2e0e659

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/MenuItem.tsx

dominictb · 2026-01-19T15:15:41Z

TS check is failing.

Uzaifm127 · 2026-01-19T16:05:42Z

Fixing...

Uzaifm127 · 2026-01-19T17:23:12Z

@dominictb Fixed.

JmillsExpensify

No product review required.

rushatgabhane · 2026-01-22T21:31:56Z

@Uzaifm127 please fix conflicts, @dominictb lemme know if rest looks okay?

Uzaifm127 · 2026-01-23T07:00:48Z

@rushatgabhane @dominictb

Fixed the conflicts.

dominictb · 2026-01-23T14:30:47Z

I'm checking this. Should be done today

dominictb · 2026-01-26T16:39:03Z

src/components/MenuItem.tsx

                        {(isHovered) => (
                            <PressableWithSecondaryInteraction
-                                onPress={shouldCheckActionAllowedOnPress ? callFunctionIfActionIsAllowed(onPressAction, isAnonymousAction) : onPressAction}
+                                // eslint-disable-next-line react/jsx-props-no-spreading


Let's not disable lint unless we had a very specific reason to do so. If you had one, please add a code comment here explaining.

dominictb · 2026-01-26T16:39:36Z

src/components/MenuItem.tsx

-                                accessible={shouldBeAccessible}
-                                tabIndex={tabIndex}
+                                role={interactive ? role : undefined}
+                                // eslint-disable-next-line react/jsx-props-no-spreading


dominictb · 2026-01-26T17:04:09Z

src/components/MenuItem.tsx

+                                    : {
+                                          accessible: false,
+                                      })}
+                                focusable={interactive}


Do we need to set this prop when we already had tabIndex?

dominictb · 2026-01-26T17:09:34Z

BUG

The accessibility announced twice issue is not fixed for me in workspace Workflows page:

You can see in the screenshot, VoiceOver announced the label twice. Can you check all places we're using Switch/Checkbox having the same issue and fix them all?

dominictb

Please add recordings. You don't have to add recordings for all cases, just the original reported places.

Also please update the QA Steps section to only cover 1-2 places. It's great to see your Tests section should cover all manual test cases but please leave 1-2 cases only for QA Steps to help testing this PR easier.

dominictb · 2026-01-26T17:21:58Z

@Valforte Can you run test builds for this?

Valforte · 2026-01-26T22:45:03Z

Building

github-actions · 2026-01-26T22:45:18Z

🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-26T23:10:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #79590.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-a945aaf4d94a6ec19f310ca7407cc650dcaef434/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-35ff946997b945941c33cf29b76ed18c84bbe29c/index.html

Web 🕸️
https://79590.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Uzaifm127 · 2026-01-27T13:38:08Z

@dominictb Thanks for pointing out.

Checking...

github-actions · 2026-01-28T17:20:42Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

Uzaifm127 · 2026-01-28T17:27:19Z

Extremely sorry everyone,
I was trying to revert the changes in this branch but it reverted something else by mistake.

Closed the PR.

fix: Hide from Assistive Tech and Remove Interactive Role

d3e2e0e

Uzaifm127 requested review from a team as code owners January 14, 2026 17:56

melvin-bot bot assigned Uzaifm127 Jan 14, 2026

melvin-bot bot requested review from JmillsExpensify and dominictb and removed request for a team January 14, 2026 17:56

melvin-bot bot requested review from a team and Valforte and removed request for a team January 14, 2026 17:56

chatgpt-codex-connector bot reviewed Jan 14, 2026

View reviewed changes

src/components/MenuItem.tsx Outdated Show resolved Hide resolved

Uzaifm127 added 6 commits January 15, 2026 00:02

Fixed prettier errors and typescript error

3cad512

Fixed typescript check and added codex suggestion

cb2b505

Resolved merge conflicts

5c07ae2

Removed prop spreading

7173be7

Fix nesting ternary operator lint error

e290d69

Fixed prettier formatting

5b38e4b

fixed typescript failing check

67dcf6b

JmillsExpensify reviewed Jan 20, 2026

View reviewed changes

Uzaifm127 mentioned this pull request Jan 21, 2026

[Due for Payment meow][$500][Accessibility][Tracking] Focus Management #79232

Closed

Resolved merge conflicts

5c84e8a

dominictb suggested changes Jan 26, 2026

View reviewed changes

Revert all the changes

ada56a4

Uzaifm127 requested review from a team, stephanieelliott and tgolen as code owners January 28, 2026 17:20

Uzaifm127 closed this Jan 28, 2026

Uzaifm127 deleted the fix/79243 branch January 28, 2026 17:27

Uzaifm127 mentioned this pull request Jan 29, 2026

Remove interactive role and double announcement for switches #80765

Merged

53 tasks

Conversation

Uzaifm127 commented Jan 14, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 14, 2026

Uh oh!

melvin-bot bot commented Jan 14, 2026

Uh oh!

codecov bot commented Jan 14, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

dominictb commented Jan 19, 2026

Uh oh!

Uzaifm127 commented Jan 19, 2026

Uh oh!

Uzaifm127 commented Jan 19, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

rushatgabhane commented Jan 22, 2026

Uh oh!

Uzaifm127 commented Jan 23, 2026

Uh oh!

dominictb commented Jan 23, 2026

Uh oh!

dominictb Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

dominictb Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

dominictb Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

dominictb commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

dominictb commented Jan 26, 2026

Uh oh!

Valforte commented Jan 26, 2026

Uh oh!

github-actions bot commented Jan 26, 2026

Uh oh!

github-actions bot commented Jan 26, 2026

Uh oh!

Uzaifm127 commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

Uzaifm127 commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Jan 14, 2026 •

edited by github-actions bot

Loading

dominictb commented Jan 26, 2026 •

edited

Loading

Uzaifm127 commented Jan 28, 2026 •

edited

Loading