Fix: Unassigning company card offline removes it optimistically instead of making it strike through by ryntgh · Pull Request #79314 · Expensify/App

ryntgh · 2026-01-12T01:48:30Z

Explanation of Change

This PR sets pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE in the unassignWorkspaceCompanyCard function instead of null in the optimistic data, and adds a skeleton loader while a card is being unassigned, before the card row is displayed

Fixed Issues

$ #78575
PROPOSAL: #78575 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Create a workspace and assign a company card
Go offline
Unassign the card
Verify that the unassigned card is displayed with a strikethrough and greyed-out
Go online
Verify that the card row shows a skeleton loader before the card row is rendered

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-Native.mp4

Android: mWeb Chrome

Android-mWeb.mp4

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-mWeb.mp4

MacOS: Chrome / Safari

MacOS-Chrome.mp4

…ad of making it strike through

codecov · 2026-01-12T01:58:49Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Skeletons/TableRowSkeleton.tsx	`92.30% <100.00%> (-7.70%)`	⬇️
src/libs/actions/CompanyCards.ts	`0.00% <ø> (ø)`
.../companyCards/WorkspaceCompanyCardsTable/index.tsx	`0.00% <ø> (ø)`
src/components/CardFeedIcon.tsx	`0.00% <0.00%> (ø)`
...e/companyCards/WorkspaceCompanyCardDetailsPage.tsx	`0.00% <0.00%> (ø)`
src/components/Skeletons/CardIconSkeleton.tsx	`0.00% <0.00%> (ø)`
src/components/PlaidCardFeedIcon.tsx	`0.00% <0.00%> (ø)`
...mpanyCardsTable/WorkspaceCompanyCardsTableItem.tsx	`0.00% <0.00%> (ø)`
... and 107 files with indirect coverage changes

melvin-bot · 2026-01-12T05:13:20Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ced92cf9e5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-12T05:24:05Z

src/libs/actions/CompanyCards.ts

                value: {
-                    [cardID]: null,
+                    [cardID]: {
+                        ...card,
+                        pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
+                    },


Clear stale errors when retrying unassign

The optimistic merge for unassignWorkspaceCompanyCard spreads the existing card object without clearing errors, so if a previous unassign failed (see failureData setting errors later in the same function), a retry will keep the old error banner visible while the new delete is pending. This makes the UI look like the retry is still failing and can interfere with OfflineWithFeedback’s delete state. Consider explicitly setting errors: null (and any error fields) in the optimistic update when starting a new unassign.

Useful? React with 👍 / 👎.

@ryntgh Could you check this comment please? 👀

After checking, I think this change make sense. I could not test this in offline, but in online mode, I think we need to remove the errors optimistically

This is the current behavior. The error dimissed only after the backend call success

1.mp4

This is the behavior when we clear the errors optimistically

2.mp4

What do you think? @hungvu193

This is the behavior when we clear the errors optimistically

I think this one is better, wdyt?

Agreed, I'll update the PR

trjExpensify

Makes sense that we use pattern B and display strikethrough for pendingDelete. I didn't see it in the vids or tests, but if it fails, is the correct handling being applied? I.e reverts to 100% opacity and an in-line dismissible error message with an RBR path that leads to it?

hungvu193 · 2026-01-14T03:10:27Z

Makes sense that we use pattern B and display strikethrough for pendingDelete. I didn't see it in the vids or tests, but if it fails, is the correct handling being applied? I.e reverts to 100% opacity and an in-line dismissible error message with an RBR path that leads to it?

Yeah, Everything remains the same, we only apply the strikethrough when it's being deleted offline.

hungvu193 · 2026-01-14T03:10:43Z

@ryntgh Any updates here?

ryntgh · 2026-01-14T08:12:46Z

Sorry for the delay, I'll update this today

ryntgh · 2026-01-14T09:31:55Z

Resolved the conflict and updated the PR!

I didn't see it in the vids or tests, but if it fails, is the correct handling being applied?

Yes, it uses the same failure handling as before

hungvu193 · 2026-01-15T03:11:09Z

src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx

    const globalCard = cardList?.[cardID];
    const isCardBeingUnassigned = globalCard?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;
    const card = feedScopedCard ?? (isCardBeingUnassigned ? globalCard : undefined);
+    const isCardPendingDelete = card?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;


We recently added:

const isCardBeingUnassigned = globalCard?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE; const card = feedScopedCard ?? (isCardBeingUnassigned ? globalCard : undefined);

Can you check if we still need this logic here?

Oh, I didn't notice this. I don't think we still need isCardPendingDelete in this case and can use isCardBeingUnassigned instead

I've re-tested and updated the PR!

Thanks. Let me verify these changes

hungvu193 · 2026-01-15T06:21:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-12.at.14.17.21.mov

Android: mWeb Chrome

Screen.Recording.2026-01-12.at.14.13.50.mov

iOS: HybridApp

Screen.Recording.2026-01-12.at.14.07.04.mov

iOS: mWeb Safari

Screen.Recording.2026-01-12.at.14.04.11.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-12.at.13.39.09.mov

carlosmiceli · 2026-01-18T01:03:39Z

All yours @trjExpensify

trjExpensify

Re-approving 👍

OSBotify · 2026-01-20T17:42:20Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.5-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-21T23:06:49Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix: Unassigning company card offline removes it optimistically inste…

0d299d3

…ad of making it strike through

melvin-bot bot assigned ryntgh Jan 12, 2026

ryntgh added 2 commits January 12, 2026 10:59

fix: show NotFoundPage for company cards with pending DELETE action

808eb13

ESLint fix

ced92cf

ryntgh marked this pull request as ready for review January 12, 2026 05:13

ryntgh requested review from a team as code owners January 12, 2026 05:13

melvin-bot bot requested review from hungvu193 and trjExpensify and removed request for a team January 12, 2026 05:13

melvin-bot bot removed the request for review from a team January 12, 2026 05:13

chatgpt-codex-connector bot reviewed Jan 12, 2026

View reviewed changes

ryntgh mentioned this pull request Jan 12, 2026

[$250] Unassigning company card offline removes it optimistically instead of making it strike through #78575

Closed

7 tasks

trjExpensify reviewed Jan 12, 2026

View reviewed changes

hungvu193 mentioned this pull request Jan 13, 2026

[Due for payment 2026-01-21] Company card - RHP shows not here page briefly after Unassign card #78319

Closed

7 tasks

ikevin127 mentioned this pull request Jan 13, 2026

fix: RHP shows not here page briefly after Unassign card #79403

Merged

53 tasks

ryntgh added 2 commits January 14, 2026 16:44

Clearing error optimistically in unassignWorkspaceCompanyCard

8c7eb2f

Merge branch 'main' into issue-78575

70b0658

hungvu193 reviewed Jan 15, 2026

View reviewed changes

Replace isCardPendingDelete with isCardBeingUnassigned

ef4e54f

hungvu193 approved these changes Jan 15, 2026

View reviewed changes

melvin-bot bot requested a review from carlosmiceli January 15, 2026 06:21

carlosmiceli approved these changes Jan 18, 2026

View reviewed changes

trjExpensify approved these changes Jan 20, 2026

View reviewed changes

carlosmiceli merged commit 964ddb9 into Expensify:main Jan 20, 2026
31 of 33 checks passed

This was referenced Jan 20, 2026

Investigate workflow job failing on main: lint / ESLint check #79938

Closed

Investigate workflow job failing on main: lint / ESLint check #79942

Closed

OSBotify mentioned this pull request Jan 20, 2026

Deploy Checklist: New Expensify 2026-01-20 #80009

Closed

85 tasks

Conversation

ryntgh commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Jan 12, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Jan 12, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

hungvu193 Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

ryntgh Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hungvu193 Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

ryntgh Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Jan 14, 2026

Uh oh!

hungvu193 commented Jan 14, 2026

Uh oh!

ryntgh commented Jan 14, 2026

Uh oh!

ryntgh commented Jan 14, 2026

Uh oh!

hungvu193 Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ryntgh Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

hungvu193 Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Jan 15, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

carlosmiceli commented Jan 18, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 20, 2026

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ryntgh commented Jan 12, 2026 •

edited

Loading

codecov bot commented Jan 12, 2026 •

edited by github-actions bot

Loading

ryntgh Jan 14, 2026 •

edited

Loading

hungvu193 Jan 15, 2026 •

edited

Loading