Skip to content

Fix opening an expense report from Reports page shows the same report when open Inbox#79436

Merged
mountiny merged 11 commits intoExpensify:mainfrom
bernhardoj:fix/67122-open-existing-report
Feb 10, 2026
Merged

Fix opening an expense report from Reports page shows the same report when open Inbox#79436
mountiny merged 11 commits intoExpensify:mainfrom
bernhardoj:fix/67122-open-existing-report

Conversation

@bernhardoj
Copy link
Contributor

Explanation of Change

Fixed Issues

$ #67122
PROPOSAL: #67122 (comment)

Tests

Same as QA Steps

  • Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite: have an expense
Web:

  1. In Inbox, open any non-expense report
  2. Open Reports page
  3. Open any expense
  4. Go back to Inbox
  5. Verify it still shows the report from step 1

Android/iOS/mWeb:

  1. Open Reports page
  2. Go back to Inbox
  3. Verify it shows the LHN
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari

Uploading ios mweb.mp4…

MacOS: Chrome / Safari
web.mp4

…7-fix/67122-open-existing-report"

This reverts commit 3be066b, reversing
changes made to d78636c.
@bernhardoj bernhardoj requested review from a team as code owners January 13, 2026 09:29
@melvin-bot melvin-bot bot requested review from JmillsExpensify and aimane-chnaif and removed request for a team January 13, 2026 09:29
@melvin-bot
Copy link

melvin-bot bot commented Jan 13, 2026

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team January 13, 2026 09:29
@bernhardoj
Copy link
Contributor Author

bernhardoj commented Jan 13, 2026

I haven't fixed the regression yet because I need some advice on which approach is the best to fix it.

Expense - Not here page opens in Inbox after deleting report on Reports
Web - Copilot - Not here page opens on Inbox after switching account

We can easily fix both issues by checking if the report still exists, but it means we need to subscribe to the whole report collection in NavigationTabBar/index.ts, which means it will re-render every time any report is updated.

The other approach is:

  1. We remove the report screen from the navigation state when deleting the expense report, and
  2. We remove all report split navigators from the navigation state when switching copilot

@aimane-chnaif @mountiny

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...c/components/Navigation/NavigationTabBar/index.tsx 52.86% <59.09%> (+3.57%) ⬆️
... and 10 files with indirect coverage changes

@mountiny
Copy link
Contributor

I think that we should definitely not do the first approach.

I am not sure about the other two, I am curious if @WojtekBoman faced similar issue before and maybe he would know what to recommend

@adamgrzybowski
Copy link
Contributor

@bernhardoj, If I understand correctly how onyx selectors work, you could modify the first proposed solution and create a selector that will extract only the information you need to make it work (if the report still exists)

@bernhardoj
Copy link
Contributor Author

you could modify the first proposed solution and create a selector that will extract only the information you need to make it work (if the report still exists)

@adamgrzybowski I thought about creating a selector that maps the collection into "another" collection that holds boolean as the value, but I realize it creates a new object each time the selector is called, so it would still re-render.

So, I tried this:

const lastReportRoute = useRootNavigationState((rootState) => {
    if (!rootState) {
        return undefined;
    }
    return getLastRoute(rootState, NAVIGATORS.REPORTS_SPLIT_NAVIGATOR, SCREENS.REPORT);
});
const lastReportRouteReportID = (lastReportRoute?.params as ReportsSplitNavigatorParamList[typeof SCREENS.REPORT])?.reportID;

const doesLastReportExistSelector = useCallback((report: OnyxEntry<Report>) => !!report?.reportID, []);
const [doesLastReportExist] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${lastReportRouteReportID}`, {canBeMissing: true, selector: doesLastReportExistSelector}, [lastReportRouteReportID]);
const [lastReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${lastReportRouteReportID}`, {canBeMissing: true});

useEffect(() => {
    console.log('tab bar', lastReportRouteReportID, doesLastReportExist, lastReport)
}, [lastReportRouteReportID, doesLastReportExist, lastReport])

but somehow the useOnyx is not being recalculated after the report collection is cleared (when switching copilot). Could there be an onyx bug?

(if I only delete the individual report like the steps outlined in #79249, then the useOnyx is recalculated)

@adamgrzybowski
Copy link
Contributor

@bernhardoj Do you need the whole collection as output from the selector? Can't it be a single boolean?

@bernhardoj
Copy link
Contributor Author

const doesLastReportExistSelector = useCallback((report: OnyxEntry) => !!report?.reportID, []);
const [doesLastReportExist] = useOnyx(${ONYXKEYS.COLLECTION.REPORT}${lastReportRouteReportID}, {canBeMissing: true, selector: doesLastReportExistSelector}, [lastReportRouteReportID]);

@adamgrzybowski it's a single booelan

@adamgrzybowski
Copy link
Contributor

Oh, sorry, I didn't notice 😄. In that case, I would contact someone who is an expert in onyx, because this looks like the best solution that should work if we manage to fix this bug.

BTW, is there an imperative way to get information from Onyx? In that case, the Boolean selector could be the one for useRootNavigationState with fetching data inside it. This way, we could avoid rerenders after the state change

@bernhardoj
Copy link
Contributor Author

BTW, is there an imperative way to get information from Onyx?

I don't think there is one.

I would contact someone who is an expert in onyx,

Posted in Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1768666683491279

Copy link
Contributor

@JmillsExpensify JmillsExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! So glad we're fixing this, it's really annoying. ;) Product approved.

@bernhardoj
Copy link
Contributor Author

Pushed the fix, but we need to wait for the onyx fix.

Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(reportID, reportActionID, referrer, backTo));
return;
}
if (isRoutePreloaded(NAVIGATORS.REPORTS_SPLIT_NAVIGATOR)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WojtekBoman @adamgrzybowski is it correct to prioritize the existing report?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yes, but I will review this with @WojtekBoman tomorrow once again and confirm

@mountiny
Copy link
Contributor

mountiny commented Feb 4, 2026

@adamgrzybowski @WojtekBoman can you review please?

@bernhardoj conflicts

@bernhardoj
Copy link
Contributor Author

Fixed

@mountiny
Copy link
Contributor

mountiny commented Feb 4, 2026

Lint

@bernhardoj
Copy link
Contributor Author

@mountiny fixed

@WojtekBoman
Copy link
Contributor

Hey, I'd like to confirm one thing :)

Is this bug reproducible on staging?

Screen.Recording.2026-02-04.at.10.59.43.mov

@bernhardoj
Copy link
Contributor Author

I can repro it on main.

web.mp4

@mountiny
Copy link
Contributor

mountiny commented Feb 5, 2026

@aimane-chnaif can you please test and review?

@aimane-chnaif
Copy link
Contributor

@bernhardoj please merge main

@aimane-chnaif
Copy link
Contributor

aimane-chnaif commented Feb 10, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-02-10.at.12.21.34.pm.mov

@aimane-chnaif
Copy link
Contributor

@chatgpt-codex-connector
Copy link

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Failed to set up container
ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@bernhardoj
Copy link
Contributor Author

@aimane-chnaif done

@melvin-bot melvin-bot bot requested a review from mountiny February 10, 2026 11:41
@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@mountiny mountiny merged commit cd0727f into Expensify:main Feb 10, 2026
30 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #79436.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-cd0727f-74891d0a9192f85385be999de08f9a90c932cea6/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-cd0727f-9c523b4a24501d18f80781d55fc53eb6d3cd66f7/index.html
Android iOS
Web 🕸️
❌ FAILED ❌
The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.17-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants