[NoQA][Sentry] Adds a metric with effective render time of Reports tab by leshniak · Pull Request #79455 · Expensify/App

leshniak · 2026-01-13T12:14:51Z

Explanation of Change

The current metric ManualNavigateToReportsTab includes the time of API requests, which incorporates all network-related conditions into the metric. Although it is a good overall measure of UX, it is a noisy metric for tracking UI issues. This metric measures the time between the points when we already have the data and when we actually display them to the user, to provide a better picture for further analysis.

Fixed Issues

$ #77174
PROPOSAL:

Tests

I've checked using console.log if these points actually measures the desired time.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-01-13T12:15:00Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

Copilot

Pull request overview

This PR adds a new Sentry metric ManualOnLayoutContentReports to measure the effective render time of the Reports tab, specifically tracking the time between when data is available and when it's actually displayed to the user. This provides a cleaner metric for UI performance analysis compared to the existing ManualNavigateToReportsTab metric, which includes network request time.

Changes:

Added new telemetry constant SPAN_ON_LAYOUT_CONTENT_REPORTS
Implemented span lifecycle management in the Search component: started when skeleton completes rendering, ended when actual content renders
Added cancel calls for the new span in all error/empty state paths

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/CONST/index.ts	Adds the new telemetry span constant `SPAN_ON_LAYOUT_CONTENT_REPORTS`
src/components/Search/index.tsx	Implements span lifecycle: starts in `onLayoutSkeleton`, ends in `onLayout`, and cancels in error/empty paths

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-13T12:21:32Z

src/components/Search/index.tsx

+        startSpan(CONST.TELEMETRY.SPAN_ON_LAYOUT_CONTENT_REPORTS, {
+            name: CONST.TELEMETRY.SPAN_ON_LAYOUT_CONTENT_REPORTS,
+            op: CONST.TELEMETRY.SPAN_ON_LAYOUT_CONTENT_REPORTS,
+        });


The span SPAN_ON_LAYOUT_CONTENT_REPORTS is only started in onLayoutSkeleton, which is only called when shouldShowLoadingState is true (line 962). However, if the data is already loaded when the component renders and shouldShowLoadingState is false from the start, the skeleton is never shown, onLayoutSkeleton is never called, and this span is never started. Yet the onLayout callback on line 950 will still try to end this span. This means the metric won't be captured in scenarios where data loads quickly or is already cached, which could be a significant portion of user interactions.

Consider starting the span earlier in the component lifecycle (e.g., where SPAN_ON_LAYOUT_SKELETON_REPORTS is started in NavigationTabBar) or conditionally starting it in the normal render path when shouldShowLoadingState is false, to ensure the metric is captured in all cases.

codecov · 2026-01-13T12:22:38Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`83.76% <ø> (ø)`
...c/components/Navigation/NavigationTabBar/index.tsx	`50.00% <0.00%> (ø)`
src/components/Search/index.tsx	`35.04% <42.85%> (+0.13%)`	⬆️
... and 5 files with indirect coverage changes

leshniak · 2026-01-13T13:28:39Z

I have read the CLA Document and I hereby sign the CLA

joekaufmanexpensify · 2026-01-13T17:11:46Z

No product considerations. Removing my review

huult · 2026-01-14T01:58:36Z

It looks like Reassure Performance Tests / perf-tests (pull_request) is failing. Please try merging main to fix it.

Ping me when this PR is ready.

…-reports-render

leshniak · 2026-01-14T10:06:03Z

@huult done. The check looks fine now.

src/components/Search/index.tsx

huult · 2026-01-14T14:04:20Z

@leshniak Please resolve the conflict.

huult · 2026-01-14T14:04:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-15.at.10.39.05.mp4

Android: mWeb Chrome

Screen.Recording.2026-01-15.at.10.37.56.mp4

iOS: HybridApp

Screen.Recording.2026-01-15.at.10.42.04.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-15.at.09.59.26.mp4

huult · 2026-01-14T15:26:35Z

src/components/Search/index.tsx

+                inputQuery: queryJSON?.inputQuery,
+            });
+        }
+    }, [shouldShowLoadingState]);


Suggested change

}, [shouldShowLoadingState]);

// Exclude `queryJSON?.inputQuery` since it’s only telemetry metadata and would cause the span to start multiple times.

// eslint-disable-next-line react-hooks/exhaustive-deps

}, [shouldShowLoadingState]);

Please add // eslint-disable-next-line react-hooks/exhaustive-deps if we intentionally don’t want to add queryJSON?.inputQuery to the dependency array, and add a comment explaining why this rule is disabled.

src/components/Search/index.tsx

huult · 2026-01-15T03:23:25Z

Screen.Recording.2026-01-15.at.09.59.26.mov

It looks like it works. Currently, we measure the duration only when data is available, empty and error states are skipped.

…-reports-render

leshniak · 2026-01-15T11:58:20Z

I've addressed the comments, conflicts are fixed too.

huult

LGTM

huult · 2026-01-15T13:48:11Z

@leshniak please resovle the conflict

…-reports-render

leshniak · 2026-01-15T15:54:20Z

@leshniak please resovle the conflict

Resolved

OSBotify · 2026-01-15T17:47:00Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.3-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-16T23:17:02Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.3-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Copilot AI review requested due to automatic review settings January 13, 2026 12:14

leshniak requested review from a team as code owners January 13, 2026 12:14

melvin-bot bot assigned leshniak Jan 13, 2026

melvin-bot bot requested review from huult, joekaufmanexpensify and rlinoz January 13, 2026 12:14

Copilot started reviewing on behalf of leshniak January 13, 2026 12:15 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

leshniak force-pushed the sentry/effective-reports-render branch 2 times, most recently from e424710 to 5e7174c Compare January 13, 2026 13:07

adds a metric with effective render time of Reports tab

4134d24

leshniak force-pushed the sentry/effective-reports-render branch from 5e7174c to 4134d24 Compare January 13, 2026 13:27

CLABotify added a commit to Expensify/CLA that referenced this pull request Jan 13, 2026

@leshniak has signed the CLA in Expensify/App#79455

3adecd8

adds parentSpan to ManualOnLayoutSkeletonReports

892b14c

joekaufmanexpensify removed their request for review January 13, 2026 17:11

Merge branch 'main' of github.com:Expensify/App into sentry/effective…

778deb1

…-reports-render

rlinoz reviewed Jan 14, 2026

View reviewed changes

src/components/Search/index.tsx Outdated Show resolved Hide resolved

huult reviewed Jan 14, 2026

View reviewed changes

huult reviewed Jan 15, 2026

View reviewed changes

src/components/Search/index.tsx Outdated Show resolved Hide resolved

huult reviewed Jan 15, 2026

View reviewed changes

src/components/Search/index.tsx Outdated Show resolved Hide resolved

huult reviewed Jan 15, 2026

View reviewed changes

src/components/Search/index.tsx Outdated Show resolved Hide resolved

leshniak added 2 commits January 15, 2026 12:53

remove redundant cancelSpan(), add comments

be83dbf

Merge branch 'main' of github.com:Expensify/App into sentry/effective…

1120dbf

…-reports-render

fixed prettier

1a4dc42

rlinoz requested a review from huult January 15, 2026 12:04

huult approved these changes Jan 15, 2026

View reviewed changes

melvin-bot bot requested a review from rlinoz January 15, 2026 12:12

Merge branch 'main' of github.com:Expensify/App into sentry/effective…

d9de043

…-reports-render

rlinoz approved these changes Jan 15, 2026

View reviewed changes

rlinoz merged commit b1e6af2 into Expensify:main Jan 15, 2026
29 checks passed

OSBotify mentioned this pull request Jan 15, 2026

Deploy Checklist: New Expensify 2026-01-15 #79701

Closed

65 tasks

huult mentioned this pull request Jan 29, 2026

[Due for payment 2026-03-13] [Due for payment 2026-03-11] [Tracking][Metrics] Improve ManualNavigateToReports #77174

Open

rlinoz mentioned this pull request Jan 30, 2026

[Awaiting payment 2026-01-26] Track effective render time of the Reports tab #81068

Closed

Conversation

leshniak commented Jan 13, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 13, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

leshniak commented Jan 13, 2026

Uh oh!

joekaufmanexpensify commented Jan 13, 2026

Uh oh!

huult commented Jan 14, 2026

Uh oh!

leshniak commented Jan 14, 2026

Uh oh!

Uh oh!

huult commented Jan 14, 2026

Uh oh!

huult commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

leshniak Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

huult commented Jan 15, 2026

Uh oh!

leshniak commented Jan 15, 2026

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

huult commented Jan 15, 2026

Uh oh!

leshniak commented Jan 15, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 15, 2026

Uh oh!

OSBotify commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions bot commented Jan 13, 2026 •

edited

Loading

codecov bot commented Jan 13, 2026 •

edited by github-actions bot

Loading

huult commented Jan 14, 2026 •

edited

Loading