feat: Add frontend error for card feed backend load issue by chrispader · Pull Request #79928 · Expensify/App

chrispader · 2026-01-19T20:48:03Z

Explanation of Change

Adds a frontend fix for failing backend OpenPolicyCompanyCardsFeed and OpenPolicyCompanyCardsPage API requests. This PR adds logic that if any of the requests fails, will add an error to the workspace and or card feed and show it appropriately in the UI.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/587676
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

OpenPolicyCompanyCardsPage error (all card feeds affected):

Screen.Recording.2026-01-20.at.12.36.26.mov

OpenPolicyCompanyCardsFeed error (only one specific feed affected):

Screen.Recording.2026-01-20.at.12.36.01.mov

melvin-bot · 2026-01-19T20:48:09Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-01-19T20:59:53Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`84.03% <ø> (ø)`
src/components/BlockingViews/BlockingView.tsx	`100.00% <100.00%> (ø)`
src/components/Search/index.tsx	`35.47% <ø> (ø)`
src/hooks/useAssignCard.ts	`86.48% <ø> (ø)`
src/hooks/useCardFeeds.tsx	`87.50% <100.00%> (+1.78%)`	⬆️
src/hooks/useCompanyCards.ts	`100.00% <ø> (ø)`
src/styles/index.ts	`45.14% <ø> (ø)`
src/styles/variables.ts	`100.00% <ø> (ø)`
src/components/BlockingViews/FullPageErrorView.tsx	`0.00% <0.00%> (ø)`
src/libs/CardFeedUtils.ts	`87.55% <44.44%> (-1.78%)`	⬇️
... and 3 more
... and 10 files with indirect coverage changes

melvin-bot · 2026-01-19T22:18:54Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chrispader · 2026-01-19T22:19:51Z

@carlosmiceli @joekaufmanexpensify ready for review!

chatgpt-codex-connector

💡 Codex Review

App/src/libs/actions/CompanyCards.ts

Lines 813 to 817 in 27259c8

    
           onyxMethod: Onyx.METHOD.MERGE, 
        
           key: `${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${domainOrWorkspaceAccountID}`, 
        
           value: { 
        
               isLoading: true, 
        
           },

Clear workspace feed errors when retrying load

After a failed OpenPolicyCompanyCardsPage call, the workspace error remains in Onyx. On a retry, the optimistic update sets isLoading: true but does not clear errors, so hasWorkspaceFeedsError stays true while the request is in flight. In WorkspaceCompanyCardsTable, that error state suppresses the loading skeleton ((isLoadingPage || …) && !hasWorkspaceFeedsError) and the error row is also hidden while loading, which can leave the page blank during a retry. Consider clearing errors in the optimistic update to avoid hiding the loading state when a retry is happening.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Expensify#79928

chrispader · 2026-01-19T22:55:14Z

Waiting for oppinions on #76438 (comment), after that we can run the translations script to remove TypeScript errors.

JmillsExpensify

Updates look good and consistent with RBR patterns. Product approved.

jjcoffee · 2026-01-21T16:18:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

desktop-chrome-2026-01-21_17.41.10.mp4

jjcoffee · 2026-01-21T17:59:05Z

BUG? On the Android app, the Try again button is too low.

…-ui-fix

chrispader · 2026-01-23T14:28:59Z

BUG? On the Android app, the Try again button is too low.

@jjcoffee Fixed!

carlosmiceli · 2026-01-26T18:16:34Z

@chrispader typecheck test failing 🙇

…-ui-fix

chrispader · 2026-01-27T14:45:21Z

@carlosmiceli this PR should be ready now. Resolved merge conflicts

OSBotify · 2026-01-27T17:05:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

MarioExpensify · 2026-01-27T18:06:23Z

Hey folks, it seems I can't open the Company Cards page anymore after this PR.

CC: @carlosmiceli @chrispader

carlosmiceli · 2026-01-27T18:13:47Z

@MarioExpensify damn, looking into it with Chris, will get a revert ready in the meantime.

MarioExpensify · 2026-01-27T18:14:58Z

Awesome, thank you guys!! @carlosmiceli I approved the revert, feel free to merge

MarioExpensify · 2026-01-27T18:55:36Z

Revert merged.

OSBotify · 2026-01-27T20:12:06Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.10-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2026-01-27T20:36:42Z

@chrispader do we need QA for this?

carlosmiceli · 2026-01-27T23:09:47Z

@IuliiaHerets this was reverted.

carlosmiceli · 2026-01-27T23:14:27Z

@MarioExpensify could you provide more information on how you got to this error, sir? It'll probably help @chrispader diagnose what was missing from the fix.

MarioExpensify · 2026-01-28T00:47:56Z

@carlosmiceli sorry, just saw your comment here. I simply headed out to the Company Cards page and it failed to open. Here are the repro steps:

Login
Create a new Workspace
Enable Company Cards
Head to Company Cards Page

The error showed up every single time I tried to open it. Reverting fixed the issue.

IuliiaHerets · 2026-01-28T08:33:40Z

@carlosmiceli, so can we check it off from the list?

chrispader · 2026-01-28T12:05:48Z

Follow-up PR for after revert is up here: #80734

@carlosmiceli, so can we check it off from the list?

@IuliiaHerets yes, we'll have to QA the above PR instead once it's merged

OSBotify · 2026-01-28T22:57:18Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.10-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned chrispader Jan 19, 2026

feat: add frontend error for card feed backend load issue

262ed5b

chrispader force-pushed the @chrispader/company-card-feeds-backend-error-ui-fix branch from b9117f6 to 262ed5b Compare January 19, 2026 20:50

chrispader added 2 commits January 19, 2026 22:12

fix: improve feed and all feed errors

35ebda1

fix: don't show empty state if error

27259c8

chrispader changed the title ~~[WIP] feat: Add frontend error for card feed backend load issue~~ feat: Add frontend error for card feed backend load issue Jan 19, 2026

chrispader marked this pull request as ready for review January 19, 2026 22:18

chrispader requested review from a team as code owners January 19, 2026 22:18

melvin-bot bot requested review from JmillsExpensify and jjcoffee and removed request for a team January 19, 2026 22:18

chrispader added 3 commits January 19, 2026 22:19

fix: prettier

771ae47

fix: ESLint

dfca6c6

fix: expose new type

261d987

chrispader mentioned this pull request Jan 19, 2026

fix: Handle company Cards errors and initial loading states #78305

Merged

53 tasks

chatgpt-codex-connector bot reviewed Jan 19, 2026

View reviewed changes

chrispader added a commit to margelo/Expensify that referenced this pull request Jan 19, 2026

refactor: extract card feed loading error logic into separate PR

db3748a

Expensify#79928

fix: prettier

4c3b0e4

chrispader mentioned this pull request Jan 19, 2026

[due for payment] [$250] Broken company card connection error not displayed correctly #76438

Closed

16 tasks

JmillsExpensify previously approved these changes Jan 20, 2026

View reviewed changes

chrispader added 3 commits January 20, 2026 12:08

feat: implement better error UI

7f01e8f

fix: card feed API request never called

286cbf2

fix: add title and fix loading states

84cb248

chrispader added 2 commits January 23, 2026 12:11

Merge branch 'main' into @chrispader/company-card-feeds-backend-error…

d71f518

…-ui-fix

fix: button not centered on Android

04e05d7

chore: run translations script

f218909

chrispader added 2 commits January 27, 2026 15:43

Merge branch 'main' into @chrispader/company-card-feeds-backend-error…

f3c8f2b

…-ui-fix

fix: TS errors

e3768c8

fix: TS error

022587e

carlosmiceli approved these changes Jan 27, 2026

View reviewed changes

carlosmiceli merged commit 451bcfb into Expensify:main Jan 27, 2026
31 checks passed

carlosmiceli mentioned this pull request Jan 27, 2026

Revert "feat: Add frontend error for card feed backend load issue" #80643

Merged

OSBotify mentioned this pull request Jan 27, 2026

Deploy Checklist: New Expensify 2026-01-27 #80656

Closed

70 tasks

chrispader mentioned this pull request Jan 28, 2026

feat: Add frontend error for card feed backend load issue (AFTER REVERT) #80734

Merged

53 tasks

btkcodedev mentioned this pull request Jan 31, 2026

[Due for payment 2026-03-04] [$250] Company card - Company cards page loads each time opening it, error when opened offline #81080

Closed

7 tasks

	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${domainOrWorkspaceAccountID}`,
	value: {
	isLoading: true,
	},

Conversation

chrispader commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 19, 2026

Uh oh!

codecov bot commented Jan 19, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Jan 19, 2026

Uh oh!

chrispader commented Jan 19, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chrispader commented Jan 19, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

jjcoffee commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jjcoffee commented Jan 21, 2026

Uh oh!

chrispader commented Jan 23, 2026

Uh oh!

carlosmiceli commented Jan 26, 2026

Uh oh!

chrispader commented Jan 27, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

MarioExpensify commented Jan 27, 2026

Uh oh!

carlosmiceli commented Jan 27, 2026

Uh oh!

MarioExpensify commented Jan 27, 2026

Uh oh!

MarioExpensify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

IuliiaHerets commented Jan 27, 2026

Uh oh!

carlosmiceli commented Jan 27, 2026

Uh oh!

carlosmiceli commented Jan 27, 2026

Uh oh!

MarioExpensify commented Jan 28, 2026

Uh oh!

IuliiaHerets commented Jan 28, 2026

Uh oh!

chrispader commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

chrispader commented Jan 19, 2026 •

edited

Loading

codecov bot commented Jan 19, 2026 •

edited by github-actions bot

Loading

jjcoffee commented Jan 21, 2026 •

edited

Loading

chrispader commented Jan 28, 2026 •

edited

Loading