feat: Add frontend error for card feed backend load issue (AFTER REVERT) by chrispader · Pull Request #80734 · Expensify/App

chrispader · 2026-01-28T11:52:11Z

Explanation of Change

Adds a frontend fix for failing backend OpenPolicyCompanyCardsFeed and OpenPolicyCompanyCardsPage API requests. This PR adds logic that if any of the requests fails, will add an error to the workspace and or card feed and show it appropriately in the UI.

Fixed Issues

https://github.com/Expensify/Expensify/issues/587676
$ https://github.com/Expensify/Expensify/issues/594856
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Preparation:

Log in with an account
Go to Account -> Troubleshoot
Open dev menu -> Simulate failing network requests
Clear and reset Onyx data

Test case 1:

Do the above preparation steps.
Create a new workspace and go to "Company cards" tab
Make sure that the new error UI is shown
Disable "Simulate failing network requests"
Tab out and back into Company cards tab
Make sure that the new error UI is NOT shown

Test case 2:

Do the above preparation steps.
Open an existing workspace with a card feed and go to "Company cards" tab
Make sure that the new error UI is shown
Disable "Simulate failing network requests"
Tab out and back into Company cards tab
Make sure that the new error UI is NOT shown

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

OpenPolicyCompanyCardsPage error (all card feeds affected):

Screen.Recording.2026-01-20.at.12.36.26.mov

OpenPolicyCompanyCardsFeed error (only one specific feed affected):

Screen.Recording.2026-01-20.at.12.36.01.mov

This reverts commit 52e940a.

melvin-bot · 2026-01-28T11:52:17Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

chrispader · 2026-01-28T12:03:11Z

The error reported by @MarioExpensify has been fixed in the latest commit:

Screen.Recording.2026-01-28.at.13.02.03.mov

The issue was that the error was set in the finallyData instead of failureData, therefore the user would always see the error.

melvin-bot · 2026-01-28T12:04:38Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-01-28T12:12:50Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`87.39% <ø> (+3.36%)`	⬆️
src/components/BlockingViews/BlockingView.tsx	`100.00% <100.00%> (ø)`
src/components/Search/index.tsx	`31.74% <ø> (-2.09%)`	⬇️
src/hooks/useAssignCard.ts	`86.48% <ø> (ø)`
src/hooks/useCardFeedErrors.ts	`100.00% <ø> (ø)`
src/hooks/useCardFeeds.tsx	`87.50% <100.00%> (+1.78%)`	⬆️
src/hooks/useCompanyCards.ts	`100.00% <ø> (ø)`
src/libs/CardFeedUtils.ts	`89.69% <100.00%> (+0.36%)`	⬆️
...sTable/WorkspaceCompanyCardsTableHeaderButtons.tsx	`0.00% <ø> (ø)`
src/styles/index.ts	`45.14% <ø> (ø)`
... and 6 more
... and 85 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9637762e93

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-01-28T12:40:28Z

src/pages/workspace/companyCards/WorkspaceCompanyCardsTable/index.tsx

+        feedErrorReloadAction = onReloadFeed;
+    }
+
+    const isLoadingFeed = (!feedName && isInitiallyLoadingFeeds) || !isPolicyLoaded || isLoadingOnyxValue(lastSelectedFeedMetadata) || !!selectedFeedStatus?.isLoading;


Avoid hiding cached cards when read is dropped offline

isLoadingFeed now depends on selectedFeedStatus?.isLoading, which is set optimistically by openPolicyCompanyCardsFeed. Because API.read requests are discarded when the app is offline, that flag never clears in offline mode, so showCards stays false and the cached cards list is hidden indefinitely until a reconnect triggers another read. This regression will show a blank page for offline users who already have cached cards. Consider skipping the selectedFeedStatus.isLoading gate when isOffline, or using a finallyData/offline guard so the loading flag doesn’t stick.

Useful? React with 👍 / 👎.

dukenv0307 · 2026-01-28T16:09:52Z

Should we show the error page in offline mode? Currently, we don't show the error on the Expensify card page, so if we show the error in company card page, it can cause the inconsistency

Screen.Recording.2026-01-28.at.23.07.21.mov

shawnborton · 2026-01-28T16:09:58Z

cc @Expensify/design - does the magnifying glass look a little big here?

I feel like we use it elsewhere and I recall seeing @dannymcclain provide specific dimensions for it, in case we want to make sure this one is using the same size too.

dukenv0307 · 2026-01-28T16:11:27Z

Bug:

Open the workspace that doesn't have a company card
Open the company card page
Observe that the empty view is displayed along with the loading view

Screen.Recording.2026-01-28.at.23.07.52.mov

chrispader · 2026-01-28T16:52:21Z

cc @Expensify/design - does the magnifying glass look a little big here?

I feel like we use it elsewhere and I recall seeing @dannymcclain provide specific dimensions for it, in case we want to make sure this one is using the same size too.

@shawnborton @Expensify/design sorry the screenshots for this PR are outdated. This is actually how it looks like, as this has been fixed in the previous PR already:

#79928 (comment)

chrispader · 2026-01-28T17:15:26Z

Bug:

Open the workspace that doesn't have a company card

Open the company card page

Observe that the empty view is displayed along with the loading view

Screen.Recording.2026-01-28.at.23.07.52.mov

fixed! Thanks for the catch! 🙌🏼

dubielzyk-expensify · 2026-01-28T17:19:53Z

@shawnborton @Expensify/design sorry the screenshots for this PR are outdated. This is actually how it looks like, as this has been fixed in the previous PR already:

I gave the same feedback as Shawn in this other PR and we ended up fixing it. Why isn't it applied here? This was where we landed then:

chrispader · 2026-01-28T17:30:40Z

@shawnborton @Expensify/design sorry the screenshots for this PR are outdated. This is actually how it looks like, as this has been fixed in the previous PR already:

I gave the same feedback as Shawn in this other PR and we ended up fixing it. Why isn't it applied here?

It is applied here actually. This is how it looks like right now:

chrispader · 2026-01-28T17:32:20Z

@dukenv0307 feel free to finish review on this! 🙌🏼

dukenv0307 · 2026-01-28T17:33:47Z

on it now

dukenv0307 · 2026-01-28T17:37:19Z

@chrispader Is it expected to show the error in offline mode? I mentioned this issue here

shawnborton · 2026-01-28T19:10:11Z

Wonderful, thanks for confirming!

chrispader · 2026-01-28T21:09:54Z

@chrispader Is it expected to show the error in offline mode? I mentioned this issue here

@dukenv0307 addressed your comment. This error will not show in offline mode, we'll just show what data we have in store locally.

dukenv0307 · 2026-01-29T03:28:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-29.at.10.27.03.mov

Android: mWeb Chrome

Screen.Recording.2026-01-29.at.10.23.35.mov

iOS: HybridApp

Screen.Recording.2026-01-29.at.10.27.54.mov

iOS: mWeb Safari

Screen.Recording.2026-01-29.at.10.22.24.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-29.at.10.21.31.mov

dukenv0307

LGTM

melvin-bot · 2026-01-29T03:29:14Z

🎯 @dukenv0307, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #80845.

OSBotify · 2026-01-29T04:05:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-30T22:17:56Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.11-16 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jponikarchuk · 2026-01-31T19:31:54Z

This PR failing because of the issue
This issue is reproducible in: All platforms

OSBotify · 2026-02-05T20:23:47Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Ollyws · 2026-02-26T13:49:13Z

src/pages/workspace/companyCards/WorkspaceCompanyCardsTable/index.tsx

-    const isLoadingFeed = (!feedName && isInitiallyLoadingFeeds) || !isPolicyLoaded || isLoadingOnyxValue(lastSelectedFeedMetadata);

+    const areWorkspaceCardFeedsLoading = !!workspaceCardFeedsStatus?.[domainOrWorkspaceAccountID]?.isLoading;
+    const workspaceCardFeedsErrors = workspaceCardFeedsStatus?.[domainOrWorkspaceAccountID]?.errors;


This was causing the error to be failed to be shown when the backend request failed #81115 which we fixed in #81978

Reapply "feat: Add frontend error for card feed backend load issue"

7f5fcf6

This reverts commit 52e940a.

melvin-bot bot assigned chrispader Jan 28, 2026

fix: workspace card feed error is set in finallyData

9637762

chrispader mentioned this pull request Jan 28, 2026

feat: Add frontend error for card feed backend load issue #79928

Merged

53 tasks

chrispader marked this pull request as ready for review January 28, 2026 12:04

chrispader requested review from a team as code owners January 28, 2026 12:04

melvin-bot bot requested review from dukenv0307 and heyjennahay and removed request for a team and heyjennahay January 28, 2026 12:04

chrispader mentioned this pull request Jan 28, 2026

Fix company cards endless skeleton for domain feeds #79937

Merged

53 tasks

chatgpt-codex-connector bot reviewed Jan 28, 2026

View reviewed changes

MarioExpensify previously approved these changes Jan 28, 2026

View reviewed changes

chrispader added 4 commits January 28, 2026 18:07

fix: loading state shown above empty state view

1370463

fix: don't show error while loading

8930dbd

fix: improve spacing of header skeleton

8f76cb9

fix: simplify loading states

7ced657

chrispader dismissed MarioExpensify’s stale review via 8f76cb9 January 28, 2026 17:14

chrispader added 2 commits January 28, 2026 21:57

fix: add workspace errors to cardFeedErrors

adf9a76

fix: handle offline behavior

6f6a895

fix: TS error

dc8b58c

dukenv0307 approved these changes Jan 29, 2026

View reviewed changes

melvin-bot bot mentioned this pull request Jan 29, 2026

[Issue payment feb 11] Payment issue for E/App PR#80734 #80845

Closed

carlosmiceli approved these changes Jan 29, 2026

View reviewed changes

carlosmiceli merged commit 106bca8 into Expensify:main Jan 29, 2026
33 checks passed

OSBotify mentioned this pull request Jan 30, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Closed

mitarachim mentioned this pull request Jan 31, 2026

[Due for payment 2026-03-04] [$250] Company card - Company cards page loads each time opening it, error when opened offline #81080

Closed

7 tasks

jponikarchuk mentioned this pull request Jan 31, 2026

[Due for payment 2026-02-25] Company Cards - Error is not shown when navigated to Company Cards page #81115

Closed

7 tasks

joekaufmanexpensify mentioned this pull request Feb 4, 2026

[due for payment] [$250] Broken company card connection error not displayed correctly #76438

Closed

16 tasks

NJ-2020 mentioned this pull request Feb 17, 2026

fix: company cards page (skeleton loader + error state) #81485

Merged

53 tasks

Ollyws mentioned this pull request Feb 18, 2026

Fix Company Cards error UI not shown with invalid workspace account ID #81978

Merged

53 tasks

Ollyws reviewed Feb 26, 2026

View reviewed changes

Conversation

chrispader commented Jan 28, 2026 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 28, 2026

Uh oh!

chrispader commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot bot commented Jan 28, 2026

Uh oh!

codecov bot commented Jan 28, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Jan 28, 2026

Uh oh!

shawnborton commented Jan 28, 2026

Uh oh!

dukenv0307 commented Jan 28, 2026

Uh oh!

chrispader commented Jan 28, 2026

Uh oh!

chrispader commented Jan 28, 2026

Uh oh!

dubielzyk-expensify commented Jan 28, 2026

Uh oh!

chrispader commented Jan 28, 2026

Uh oh!

chrispader commented Jan 28, 2026

Uh oh!

dukenv0307 commented Jan 28, 2026

Uh oh!

dukenv0307 commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Jan 28, 2026

Uh oh!

chrispader commented Jan 28, 2026

Uh oh!

dukenv0307 commented Jan 29, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jan 29, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 29, 2026

Uh oh!

OSBotify commented Jan 30, 2026

Uh oh!

jponikarchuk commented Jan 31, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

Ollyws Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

chrispader commented Jan 28, 2026 •

edited by mountiny

Loading

chrispader commented Jan 28, 2026 •

edited

Loading

codecov bot commented Jan 28, 2026 •

edited by github-actions bot

Loading

dukenv0307 commented Jan 28, 2026 •

edited

Loading