fix: Console error when removing workspace member offline by handling React.Fragment by samranahm · Pull Request #79933 · Expensify/App

samranahm · 2026-01-19T22:48:22Z

Explanation of Change

Fixed Issues

$ #79220
PROPOSAL: #79220 (comment)

Tests

Go to workspace > Members page
Invite new member if no other member exist in workspace
Go offline
Tap invited member and remove them from workspace offline
Verify strikethrough style applied on recently removed member in members page
Verify there is no Console error "Invalid prop style supplied to React.Fragment. React.Fragment can only have key and children props."

Tap Remove from confirm modal

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.Native.mov

Android: mWeb Chrome

Android.mWeb.Chrome.mov

iOS: Native

IOS.Native.mov

iOS: mWeb Safari

IOS.mWeb.Safari.mov

MacOS: Chrome / Safari

macOS.chrome.mp4

Copilot

Pull request overview

This PR fixes a console error that occurred when removing workspace members while offline. The error "Invalid prop style supplied to React.Fragment" was caused by the applyStrikeThrough function attempting to apply style props to React.Fragment elements, which only accept key and children props.

Changes:

Added special handling for React.Fragment elements in the OfflineWithFeedback component's strikethrough logic
The fix recreates Fragments with only valid props (key and children) and recursively applies strikethrough to their children

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-19T22:53:57Z

src/components/OfflineWithFeedback.tsx

+            if (child.type === React.Fragment) {
+                const childProps = child.props as {children?: React.ReactNode};
+                return React.createElement(React.Fragment, {key: child.key}, applyStrikeThrough(childProps.children));
+            }


The PR description mentions that unit tests were added for this fix (checklist item "I added [unit tests]" is checked). However, no test file changes are visible in this diff. Consider adding unit tests that verify the React.Fragment handling works correctly, such as:

A test that verifies strikethrough is correctly applied to children within a React.Fragment

A test that confirms no console errors are thrown when processing React.Fragment children

A test that ensures the key prop is preserved when recreating the Fragment

This would help prevent future regressions and validate the fix comprehensively.

codecov · 2026-01-19T22:57:31Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/OfflineWithFeedback.tsx	`82.14% <0.00%> (-3.05%)`	⬇️
... and 8 files with indirect coverage changes

truph01 · 2026-01-23T11:12:11Z

@samranahm Could you help merge main?

samranahm · 2026-01-23T11:24:04Z

Sure.

samranahm · 2026-01-23T12:14:54Z

@truph01 All yours! 🙌

heyjennahay

Product review not required

truph01 · 2026-01-27T03:32:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-27.at.10.32.33.mov

Android: mWeb Chrome

Screen.Recording.2026-01-27.at.10.29.31.mov

iOS: HybridApp

Screen.Recording.2026-01-27.at.10.30.57.mov

iOS: mWeb Safari

Screen.Recording.2026-01-27.at.10.17.21.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-27.at.10.09.05.mov

OSBotify · 2026-01-27T17:50:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-27T20:12:10Z

🚀 Deployed to staging by https://github.com/amyevans in version: 9.3.10-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-28T22:57:21Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.10-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: console error when removing workspace member offline

28db7fc

Copilot AI review requested due to automatic review settings January 19, 2026 22:48

samranahm requested review from a team as code owners January 19, 2026 22:48

melvin-bot bot assigned samranahm Jan 19, 2026

melvin-bot bot requested review from amyevans, heyjennahay and truph01 January 19, 2026 22:48

Copilot started reviewing on behalf of samranahm January 19, 2026 22:48 View session

samranahm mentioned this pull request Jan 19, 2026

[$250] Dev: Console error when remove workspace member offline #79220

Closed

7 tasks

Copilot AI reviewed Jan 19, 2026

View reviewed changes

samranahm changed the title ~~fix: Console error when removing workspace member offline by handling React.Fragment in OfflineWithFeedback~~ fix: Console error when removing workspace member offline by handling React.Fragment Jan 21, 2026

Merge branch 'Expensify:main' into 79220/console-error-member-remove

5e38a80

heyjennahay reviewed Jan 26, 2026

View reviewed changes

heyjennahay removed the request for review from a team January 26, 2026 12:29

truph01 approved these changes Jan 27, 2026

View reviewed changes

amyevans approved these changes Jan 27, 2026

View reviewed changes

amyevans merged commit 16662fd into Expensify:main Jan 27, 2026
30 of 31 checks passed

OSBotify mentioned this pull request Jan 27, 2026

Deploy Checklist: New Expensify 2026-01-27 #80656

Closed

70 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Console error when removing workspace member offline by handling React.Fragment#79933

fix: Console error when removing workspace member offline by handling React.Fragment#79933
amyevans merged 2 commits intoExpensify:mainfrom
samranahm:79220/console-error-member-remove

samranahm commented Jan 19, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

codecov bot commented Jan 19, 2026 •

edited by github-actions bot

Loading

Uh oh!

truph01 commented Jan 23, 2026

Uh oh!

samranahm commented Jan 23, 2026

Uh oh!

samranahm commented Jan 23, 2026

Uh oh!

heyjennahay left a comment

Uh oh!

truph01 commented Jan 27, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

samranahm commented Jan 19, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 19, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

truph01 commented Jan 23, 2026

Uh oh!

samranahm commented Jan 23, 2026

Uh oh!

samranahm commented Jan 23, 2026

Uh oh!

heyjennahay left a comment

Choose a reason for hiding this comment

Uh oh!

truph01 commented Jan 27, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Jan 19, 2026 •

edited by github-actions bot

Loading