Skip to content

fix: Console error when removing workspace member offline by handling React.Fragment #79933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amyevans merged 2 commits into from
Jan 27, 2026
Merged

fix: Console error when removing workspace member offline by handling React.Fragment #79933

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28db7fc
fix: console error when removing workspace member offline
samranahm Jan 19, 2026
5e38a80
Merge branch 'Expensify:main' into 79220/console-error-member-remove
samranahm Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/components/OfflineWithFeedback.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ function OfflineWithFeedback({
return child;
}

if (child.type === React.Fragment) {
const childProps = child.props as {children?: React.ReactNode};
return React.createElement(React.Fragment, {key: child.key}, applyStrikeThrough(childProps.children));
}
Comment on lines +116 to +119
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description mentions that unit tests were added for this fix (checklist item "I added [unit tests]" is checked). However, no test file changes are visible in this diff. Consider adding unit tests that verify the React.Fragment handling works correctly, such as:

  1. A test that verifies strikethrough is correctly applied to children within a React.Fragment
  2. A test that confirms no console errors are thrown when processing React.Fragment children
  3. A test that ensures the key prop is preserved when recreating the Fragment

This would help prevent future regressions and validate the fix comprehensively.

Copilot uses AI. Check for mistakes.

type ChildComponentProps = ChildrenProps & {style?: AllStyles};
const childProps = child.props as ChildComponentProps;
const props: StrikethroughProps = {
Expand Down
Loading