[CP Staging] Revert #78634 by mjasikowski · Pull Request #80318 · Expensify/App

mjasikowski · 2026-01-23T08:58:03Z

Reverts #78634 to fix deploy blockers:

Chat - Whisper to invite member reappears after inviting member to submit expenses #80292
Expense - Transaction thread is blank when quickly opening expense after splitting #80300
LHN - Self DM preview show HTML tags when description has mark down after removing from report #80302
Expense - Expense preview persists and opens not here page after deleting moved IOU expense #80305
Expense - After selecting category from Concierge message, Concierge message becomes blank #80293 (possibly)
Expense- Expense preview disappears instead of showing strikethrough after deleting it offline #80307
Expense - Report shows skeleton loader when opening unreported expense for the first time #80281 (possibly)
Expense - Expense briefly disappears from background when deleting expense #80288 (possibly)

Straight revert

melvin-bot · 2026-01-23T08:58:41Z

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-01-23T09:08:03Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
...tachments/AttachmentCarousel/extractAttachments.ts	`70.83% <100.00%> (+0.24%)`	⬆️
src/components/LHNOptionsList/LHNOptionsList.tsx	`87.34% <100.00%> (+8.77%)`	⬆️
src/components/LHNOptionsList/OptionRowLHNData.tsx	`86.36% <ø> (+3.75%)`	⬆️
src/components/ParentNavigationSubtitle.tsx	`78.78% <100.00%> (+21.21%)`	⬆️
src/components/Search/SearchAutocompleteList.tsx	`32.01% <ø> (-0.20%)`	⬇️
src/hooks/useSearchSelector.base.ts	`0.00% <ø> (-20.00%)`	⬇️
src/libs/SearchUIUtils.ts	`59.86% <100.00%> (+44.61%)`	⬆️
src/libs/SidebarUtils.ts	`79.91% <100.00%> (+0.51%)`	⬆️
...rc/libs/actions/OnyxDerived/ONYX_DERIVED_VALUES.ts	`100.00% <ø> (ø)`
... and 11 more
... and 165 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f741c4b78

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-23T09:09:05Z

src/components/Attachments/AttachmentCarousel/extractAttachments.ts

    const actions = [...(parentReportAction ? [parentReportAction] : []), ...getSortedReportActions(Object.values(reportActions ?? {}))];
-    for (const action of actions) {
-        if (!isReportActionVisible(action, reportID, canUserPerformAction, visibleReportActionsData) || isMoneyRequestAction(action)) {
+    for (const [key, action] of actions.entries()) {
+        if (!shouldReportActionBeVisible(action, key, canUserPerformAction) || isMoneyRequestAction(action)) {


Pass reportActionID to visibility check

shouldReportActionBeVisible relies on its key to detect deprecated actions via isReportActionDeprecated, which compares String(reportAction.sequenceNumber) to the key. Here the key comes from actions.entries() so it is just the array index, not the reportActionID, meaning any action whose sequenceNumber happens to equal its position will be treated as deprecated and skipped. In reports with sequential sequenceNumbers this can drop otherwise-visible actions and their attachments. Use action.reportActionID (or the original reportActions object key) instead of the index.

Useful? React with 👍 / 👎.

mountiny

Straight revert

melvin-bot · 2026-01-23T13:26:44Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mountiny · 2026-01-23T13:27:02Z

Straight revert

…4-feat/visible-report-actions-derived" This reverts commit df8d273, reversing changes made to a5e4a32.

…port-actions-derived [CP Staging] Revert #78634 (cherry picked from commit df8d273) (cherry-picked to staging by mountiny)

OSBotify · 2026-01-23T17:54:26Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.7-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-23T22:06:10Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.7-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2026-01-23T22:35:19Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.8-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-26T21:57:27Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.8-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-30T22:16:59Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.11-16 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T20:20:20Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Revert "new Onyx Derived Value VISIBLE_REPORT_ACTIONS"

8f741c4

mjasikowski requested review from a team as code owners January 23, 2026 08:58

melvin-bot bot assigned mjasikowski Jan 23, 2026

melvin-bot bot requested review from JmillsExpensify and inimaga and removed request for a team January 23, 2026 08:58

mjasikowski changed the title ~~Revert "new Onyx Derived Value VISIBLE_REPORT_ACTIONS"~~ [CP Staging] Revert #80318 Jan 23, 2026

mjasikowski changed the title ~~[CP Staging] Revert #80318~~ [CP Staging] Revert #78634 Jan 23, 2026

youssef-lr approved these changes Jan 23, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Jan 23, 2026

View reviewed changes

BartekObudzinski mentioned this pull request Jan 23, 2026

Whisper to invite member reappears after inviting #80319

Closed

53 tasks

mountiny approved these changes Jan 23, 2026

View reviewed changes

mountiny merged commit df8d273 into main Jan 23, 2026
31 of 40 checks passed

mountiny deleted the revert-78634-feat/visible-report-actions-derived branch January 23, 2026 13:26

melvin-bot bot added the Emergency label Jan 23, 2026

mountiny removed the Emergency label Jan 23, 2026

github-actions bot mentioned this pull request Jan 23, 2026

Investigate workflow job failing on main: lint / ESLint check #80339

Closed

OSBotify pushed a commit that referenced this pull request Jan 23, 2026

Merge pull request #80318 from Expensify/revert-78634-feat/visible-re…

f424e43

…port-actions-derived [CP Staging] Revert #78634 (cherry picked from commit df8d273) (cherry-picked to staging by mountiny)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jan 23, 2026

OSBotify mentioned this pull request Jan 23, 2026

Deploy Checklist: New Expensify 2026-01-22 #80277

Closed

63 tasks

chuckdries mentioned this pull request Jan 23, 2026

Expense - Expense preview persists and opens not here page after deleting moved IOU expense #80305

Closed

7 tasks

OSBotify mentioned this pull request Jan 30, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Closed

Conversation

mjasikowski commented Jan 23, 2026 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot bot commented Jan 23, 2026

Uh oh!

codecov bot commented Jan 23, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot bot commented Jan 23, 2026

Uh oh!

mountiny commented Jan 23, 2026

Uh oh!

OSBotify commented Jan 23, 2026

Uh oh!

OSBotify commented Jan 23, 2026

Uh oh!

OSBotify commented Jan 23, 2026

Uh oh!

OSBotify commented Jan 26, 2026

Uh oh!

OSBotify commented Jan 30, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mjasikowski commented Jan 23, 2026 •

edited by mountiny

Loading

codecov bot commented Jan 23, 2026 •

edited by github-actions bot

Loading