Whisper to invite member reappears after inviting#80319
Closed
BartekObudzinski wants to merge 1 commit intoExpensify:mainfrom
Closed
Whisper to invite member reappears after inviting#80319BartekObudzinski wants to merge 1 commit intoExpensify:mainfrom
BartekObudzinski wants to merge 1 commit intoExpensify:mainfrom
Conversation
…sible utility function, improving code clarity and maintainability.
Contributor
Author
Screen.Recording.2026-01-23.at.10.02.50.mov |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
Author
|
Closing this because looks like we're going for a revert as there are multiple blockers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed a bug in isReportActionVisible function which defaulted to true when an action wasn't yet in the derived value cache, causing temporarily showing actions that should be hidden (e.g., resolved whispers). Now when an action is not in cache, the function falls back to shouldReportActionBeVisible which properly checks all visibility conditions at runtime.
Fixed Issues
$ #80292
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-23.at.10.48.28.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-01-23.at.10.35.35.mov
iOS: mWeb Safari
Screen.Recording.2026-01-23.at.10.40.54.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-23.at.10.02.50.mov