fix: the selected option is announced without selected/not selected state by daledah · Pull Request #80467 · Expensify/App

daledah · 2026-01-26T04:58:43Z

Explanation of Change

Fixed Issues

$ #74845
PROPOSAL: #74845 (comment)

Tests

For iOS simulator I used Xcode > Open Developer Tool > Accessibility Inspector
For Android simulator > go to Settings -> Accessibility -> Toggle the "Use TalkBack" switch to On

Go to Account -> Profile -> choose timezone
Turn off automatically determine your location
Choose timezone
Focus the selected item
Verify that: Screen readers should announce the selected state

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…tate

melvin-bot · 2026-01-27T17:02:24Z

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-01-27T17:02:30Z

@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify

Why is this NoQA?

linhvovan29546 · 2026-01-28T04:29:34Z

@daledah We need to QA for this issue. Please add a recording and include test steps for both iOS and Android. For Android, enable TalkBack and for iOS, enable VoiceOver.

daledah · 2026-01-28T07:58:41Z

@linhvovan29546 Can you share with me how you used VoiceOver and TalkBack to test in this PR?

linhvovan29546 · 2026-01-28T09:35:55Z

Can you share with me how you used VoiceOver and TalkBack to test in this PR?

Android: If you don’t know how to enable TalkBack, please follow these steps:

Open the Settings app on the emulator/device.
Scroll down and tap Accessibility.
Tap TalkBack.
Toggle the "Use TalkBack" switch to On.

Screen.Recording.2026-01-28.at.15.42.36.mov

iOS: For the simulator, use Accessibility Inspector.

Screen.Recording.2026-01-28.at.15.47.56.mov

Web: You can use this tool to testing

neil-marcellini

(Neil's AI Agent)

LGTM! This accessibility fix properly announces the selected state for list items:

Uses the semantic option role instead of button role for list items
Adds accessibilityState={{selected: item.isSelected}} and aria-selected to the PressableWithFeedback, so screen readers announce "selected" or "not selected" appropriately
Removes the duplicate accessibilityState from the inner View

The change is minimal and focused on improving screen reader experience.

Neil

I have manually reviewed this PR as well.

daledah · 2026-02-02T18:01:26Z

thanks @linhvovan29546. l added the steps and the screenshots for the ios and ios mweb. But i don't have TalkBack option in my android simulator. Could you please test it on your end?

Screen.Recording.2026-02-03.at.01.00.35.mov

linhvovan29546 · 2026-02-04T02:08:13Z

src/components/SelectionList/ListItem/BaseListItem.tsx

                // eslint-disable-next-line react/jsx-props-no-spreading
                {...bind}
+                sentryLabel={CONST.SENTRY_LABEL.BASE_LIST_ITEM.OPTION}
+                accessibilityState={{selected: item.isSelected}}


@daledah Could you please apply a similar change to src/components/SelectionListWithSections/BaseListItem.tsx? They are the same.

linhvovan29546 · 2026-02-04T12:46:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-04.at.19.52.21.mov

Android: mWeb Chrome

Screen.Recording.2026-02-04.at.19.36.41.mov

iOS: HybridApp

Screen.Recording.2026-02-04.at.19.23.22.mov

iOS: mWeb Safari

Screen.Recording.2026-02-04.at.19.33.18.mov

MacOS: Chrome / Safari

linhvovan29546

Tests
For iOS simulator I used Xcode > Open Developer Tool > Accessibility Inspector
For Android simulator > go to Settings -> Accessibility -> Toggle the "Use TalkBack" switch to On

Please add the suggested tests for web as well, using Chrome + JAWS.

daledah · 2026-02-06T09:04:26Z

@linhvovan29546 looks like the bug is fixed in this PR. Should we put our PR on hold or close it?

linhvovan29546 · 2026-02-06T14:29:39Z

This issue focuses on the web. The PR above only handles the native side and is missing an implementation for web. We still need this PR to fix the issue on web, but the fix should be based on that PR

linhvovan29546 · 2026-02-06T22:13:55Z

After rechecked again, I think we can hold this PR and then request retest, since it looks like the issue is resolved by the PR above

github-actions · 2026-02-24T15:27:01Z

Code Review

This PR adds aria-selected and role="option" to BaseListItem so screen readers announce the selected state. The ARIA improvement is welcome, but there are a few concerns:

1. Missing `role="listbox"` on the parent container

role="option" requires a parent element with role="listbox" per the WAI-ARIA spec. I don't see a corresponding role="listbox" on the SelectionList container. Without it, screen readers may not correctly interpret the option role or aria-selected attribute.

2. Hardcoded `role="option"` overrides `accessibilityRole` prop for all callers

The previous code respected the accessibilityRole prop passed by callers:

role={accessible === false ? CONST.ROLE.PRESENTATION : accessibilityRole}

This PR removes that conditional and unconditionally sets role={CONST.ROLE.OPTION}. However, MultiSelectListItem passes accessibilityRole={CONST.ROLE.CHECKBOX} and RadioListItem forwards its accessibilityRole prop — both are now silently ignored.

This is a potential regression: checkbox and radio list items will be announced as "option" instead of "checkbox"/"radio", and the accessibilityState.checked logic (line 91-92) that depends on accessibilityRole being CHECKBOX or RADIO will still set checked on an element with role="option" — semantically incorrect.

3. Semantic change: `isFocused` vs `item.isSelected`

The removed accessibilityState={{selected: !!isFocused}} on the inner View communicated focus state. The new aria-selected={item.isSelected} communicates selection state. These are different concepts — removing the focus announcement may degrade keyboard navigation accessibility.

Suggestion

Keep the conditional role assignment so that checkbox/radio list items retain their proper ARIA roles, and only default to role="option" when no custom accessibilityRole is provided. Also add role="listbox" to the parent SelectionList container.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 55e1f69d8b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-24T15:31:43Z

src/components/SelectionList/ListItem/BaseListItem.tsx

                disabled={isDisabled && !item.isSelected}
                interactive={item.isInteractive}
                accessibilityLabel={item.accessibilityLabel ?? [item.text, item.text !== item.alternateText ? item.alternateText : undefined].filter(Boolean).join(', ')}
+                role={CONST.ROLE.OPTION}


Respect caller role when rendering selection list rows

Do not hardcode role to option here; BaseListItem still computes state from accessibilityRole, and callers like MultiSelectListItem explicitly pass CONST.ROLE.CHECKBOX so screen readers announce checked/unchecked semantics. With this change every row is exposed as an option, so checkbox/radio roles are lost and assistive tech can stop announcing the intended control state for multi-select flows.

Useful? React with 👍 / 👎.

I agree that we need to fix this.

neil-marcellini · 2026-02-24T22:50:00Z

src/components/SelectionList/ListItem/BaseListItem.tsx

                disabled={isDisabled && !item.isSelected}
                interactive={item.isInteractive}
                accessibilityLabel={item.accessibilityLabel ?? [item.text, item.text !== item.alternateText ? item.alternateText : undefined].filter(Boolean).join(', ')}
+                role={CONST.ROLE.OPTION}


I agree that we need to fix this.

linhvovan29546

@daledah Please also see my comment: #80467 (comment) as well

src/components/SelectionList/ListItem/BaseListItem.tsx

daledah · 2026-03-05T09:15:54Z

We have the new PR here

fix: the selected option is announced without selected/not selected s…

7c91abd

…tate

melvin-bot bot assigned daledah Jan 26, 2026

daledah changed the title ~~fix: the selected option is announced without selected/not selected s…~~ fix: the selected option is announced without selected/not selected state Jan 26, 2026

daledah changed the title ~~fix: the selected option is announced without selected/not selected state~~ [noQA] fix: the selected option is announced without selected/not selected state Jan 27, 2026

daledah marked this pull request as ready for review January 27, 2026 17:02

daledah requested review from a team as code owners January 27, 2026 17:02

melvin-bot bot requested review from a team, linhvovan29546 and trjExpensify and removed request for a team January 27, 2026 17:02

melvin-bot bot requested review from neil-marcellini and removed request for a team January 27, 2026 17:02

trjExpensify reviewed Jan 28, 2026

View reviewed changes

Merge branch 'main' into fix/74845

e0a1382

neil-marcellini previously approved these changes Feb 2, 2026

View reviewed changes

daledah changed the title ~~[noQA] fix: the selected option is announced without selected/not selected state~~ fix: the selected option is announced without selected/not selected state Feb 2, 2026

fix lint

affb5a9

daledah dismissed neil-marcellini’s stale review via affb5a9 February 2, 2026 17:59

neil-marcellini previously approved these changes Feb 3, 2026

View reviewed changes

linhvovan29546 suggested changes Feb 4, 2026

View reviewed changes

neil-marcellini marked this pull request as draft February 9, 2026 17:55

resolve conflict

55e1f69

daledah dismissed neil-marcellini’s stale review via 55e1f69 February 24, 2026 15:13

daledah marked this pull request as ready for review February 24, 2026 15:22

chatgpt-codex-connector bot reviewed Feb 24, 2026

View reviewed changes

neil-marcellini requested changes Feb 24, 2026

View reviewed changes

linhvovan29546 suggested changes Feb 25, 2026

View reviewed changes

src/components/SelectionList/ListItem/BaseListItem.tsx Show resolved Hide resolved

Merge branch 'main' into fix/74845

b70fcb8

neil-marcellini marked this pull request as draft February 26, 2026 18:56

daledah closed this Mar 5, 2026

Conversation

daledah commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 27, 2026

Uh oh!

melvin-bot bot commented Jan 27, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 commented Jan 28, 2026

Uh oh!

daledah commented Jan 28, 2026

Uh oh!

linhvovan29546 commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neil-marcellini left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

(Neil's AI Agent)

Neil

Uh oh!

daledah commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linhvovan29546 Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

linhvovan29546 left a comment

Choose a reason for hiding this comment

Uh oh!

daledah commented Feb 6, 2026

Uh oh!

linhvovan29546 commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linhvovan29546 commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 24, 2026

Code Review

1. Missing role="listbox" on the parent container

2. Hardcoded role="option" overrides accessibilityRole prop for all callers

3. Semantic change: isFocused vs item.isSelected

Suggestion

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

daledah commented Mar 5, 2026

Uh oh!

Reviewers

daledah commented Jan 26, 2026 •

edited

Loading

linhvovan29546 commented Jan 28, 2026 •

edited

Loading

neil-marcellini left a comment •

edited

Loading

daledah commented Feb 2, 2026 •

edited

Loading

linhvovan29546 commented Feb 4, 2026 •

edited

Loading

linhvovan29546 commented Feb 6, 2026 •

edited

Loading

linhvovan29546 commented Feb 6, 2026 •

edited

Loading

1. Missing `role="listbox"` on the parent container

2. Hardcoded `role="option"` overrides `accessibilityRole` prop for all callers

3. Semantic change: `isFocused` vs `item.isSelected`