Revert PR 8013, which introduced a bug#8054
Merged
TomatoToaster merged 1 commit intomainfrom Mar 9, 2022
Merged
Conversation
TomatoToaster
approved these changes
Mar 9, 2022
Contributor
|
|
OSBotify
pushed a commit
that referenced
this pull request
Mar 9, 2022
…ression Revert PR 8013, which introduced a bug (cherry picked from commit e3c33ed)
This was referenced Mar 9, 2022
Contributor
|
🚀 Cherry-picked to staging by @TomatoToaster in version: 1.1.41-6 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Contributor
|
🚀 Deployed to production by @francoisl in version: 1.1.41-6 🚀
|
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Reverts a PR which was accidentally cherry-picked. See this Slack thread for much more details: https://expensify.slack.com/archives/C03TQ48KC/p1646832274218809
IT IS EXPECTED THAT THE ROOM AVATAR DOES NOT DISPLAY! This PR simply reverts the breaking changes.
Fixed Issues
$ #8040
Tests
Test that the issue is fixed
PR Review Checklist
Contributor (PR Author) Checklist
main### Fixed Issuessection abovesrc/languages/*files (if applicable)Styling.md) for all style edits I madeSTYLE.md)Avatar, I verified the components usingAvatarare working as expected)mainbranch)PR Reviewer Checklist
main### Fixed Issuessection abovesrc/languages/*files (if applicable)STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)mainbranch)QA Steps