feat: implement `SearchBarChart` component by mateuuszzzzz · Pull Request #80658 · Expensify/App

mateuuszzzzz · 2026-01-27T19:47:22Z

Explanation of Change

This PR introduces the SearchBarChart component as part of the Insights project, enabling a bar chart visualization in the search view when the user types view:bar withgroup-by.

New Charts infrastructure:

Added a reusable BarChart component built on top of Victory Native and @shopify/react-native-skia, with platform-specific entry points for web and native
Created supporting components: ChartHeader (displays title and selected value), ChartTooltip (shows details on bar hover/press)
Implemented custom hooks for chart interactions (useChartInteractions,useChartInteractionState), label formatting (useChartLabelFormats), and label layout (useChartLabelLayout)
Added a chart color palette system and shared constants/types

Search integration:

Added SearchChartView which fetches search data and transforms it into
chart-compatible format, grouping results by category with currency-based
Y-axis values
The chart is conditionally rendered in the Search component when
queryJSON.view === 'bar'
Added currency formatting utilities in CurrencyUtils for axis labels

Fixed Issues

$ #80534
PROPOSAL:

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13830

Tests

Render bar chart with type:expense group-by:category view:bar - verify bars display correctly
Hover over bar (web) - verify tooltip shows <category> • <amount> (<percentage>)
Click/tap on bar - verify navigation to filtered search type:expense category:"<selected>"
Test with 5 bars, 20 bars, 50+ bars - verify X-axis labels rotate/truncate/skip appropriately and there is no overlap.

Offline tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-01-27T19:47:29Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2026-01-27T20:06:17Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Charts/constants.ts	`100.00% <100.00%> (ø)`
src/components/Charts/font/index.native.ts	`100.00% <100.00%> (ø)`
src/libs/SearchQueryUtils.ts	`70.55% <100.00%> (+0.07%)`	⬆️
src/styles/index.ts	`42.47% <ø> (ø)`
src/components/Charts/BarChart/index.native.tsx	`50.00% <50.00%> (ø)`
src/components/Charts/font/index.ts	`0.00% <0.00%> (ø)`
src/components/Charts/ChartHeader.tsx	`33.33% <33.33%> (ø)`
src/libs/DateUtils.ts	`63.81% <0.00%> (-0.36%)`	⬇️
src/components/Charts/chartColors.ts	`71.42% <71.42%> (ø)`
src/components/Search/index.tsx	`30.09% <20.00%> (-0.12%)`	⬇️
... and 10 more
... and 11 files with indirect coverage changes

github-actions · 2026-01-28T01:02:14Z

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

puneetlath · 2026-01-28T01:32:12Z

@Expensify/design this is our first chart! Mind giving the ad-hoc a spin and sharing your feedback?

puneetlath · 2026-01-28T01:46:32Z

Looks like it's crashing on web but mobile is working. To test it, type this into the Reports page search type:expense group-by:category view:bar

shawnborton · 2026-01-28T05:58:48Z

Dang, excited to see this on web! But will take mobile for a spin in the meantime.

shawnborton · 2026-01-28T06:09:03Z

Hmm I can't seem to sign in on the mobile adhoc build, I keep getting an "invalid authentication code" even though I'm pasting directly from the authenticator app. So 2FA seems broken for some reason, though my Expensify magic code is working. Not sure if that's a separate problem on main somewhere.

trjExpensify · 2026-01-28T17:14:31Z

@shawnborton on the iOS adhoc build app I can sign-in with Google to bypass magic code/2FA etc.

trjExpensify · 2026-01-28T17:17:13Z

I saw a bar chart on mobile! I can't scroll the page when it's rendered though, so it's hard to check it out properly at this point.

dubielzyk-expensify · 2026-01-28T17:32:43Z

Yeah, the padding on mobile is also too big. The card itself should also have 20px padding on mobile. Currently it's 32px:

Still find those vertical labels to be a bit weird

dubielzyk-expensify · 2026-01-28T17:46:21Z

(Sidenote: I think maybe we leave it for now until we can test more, but I've started some explorations in Figma on how to better show negative values on the chart)

shawnborton · 2026-01-28T19:13:18Z

Should we consider making charts horizontally scrollable on mobile when they have > X bars? Otherwise they feel pretty poor and illegible.

Agree that the axis labels are feeling pretty odd as well.

dannymcclain · 2026-01-28T19:18:17Z

Should we consider making charts horizontally scrollable on mobile when they have > X bars? Otherwise they feel pretty poor and illegible.

I think the plan is to figure this out after V1 👍

github-actions · 2026-01-29T22:30:47Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80658 Mobile-Expensify PR Expensify/Mobile-Expensify#13830.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
https://80658.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ShridharGoel · 2026-01-29T22:31:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

neil-marcellini

One thing to change

src/components/Charts/BarChart/BarChartContent.tsx

ShridharGoel · 2026-01-29T22:37:17Z

It crashes on native iOS and Android.

Screen.Recording.2026-01-30.at.4.06.31.AM.mov

mateuuszzzzz · 2026-01-29T22:38:34Z

It crashes on native.

Screen.Recording.2026-01-30.at.4.06.31.AM.mov

I think you need to rebuild your app. This error states that native module cannot be found so probably you haven't compiled it yet

ShridharGoel · 2026-01-29T22:39:17Z

Makes sense, I'll check by creating a fresh build.

github-actions · 2026-01-29T22:43:57Z

🚧 @trjExpensify has triggered a test Expensify/App build. You can view the workflow run here.

ShridharGoel · 2026-01-29T22:46:26Z

The last few labels are not showing (or maybe there are skips in between but the spacing is not proper).

trjExpensify · 2026-01-29T22:52:17Z

@ShridharGoel that one is something we're going to patch upstream, so @mateuuszzzzz will create a separate issue for it shortly.

github-actions · 2026-01-29T23:05:54Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80658 Mobile-Expensify PR Expensify/Mobile-Expensify#13830.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-baadf55-68f7a31dd211162930476455e466a2256b933f66/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-baadf55-51325f91fc8db48ad948069ae59df5bd1eb4ebca/index.html

Web 🕸️
⏩ SKIPPED ⏩
The build for Web was skipped

👀 View the workflow run that generated this build 👀

OSBotify · 2026-01-30T00:09:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-30T22:17:41Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.3.11-16 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T20:22:47Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

mateuuszzzzz added 2 commits January 27, 2026 10:51

Add dependencies

a07371b

Update configs and setup scripts

cb5844a

melvin-bot bot assigned mateuuszzzzz Jan 27, 2026

mateuuszzzzz added 7 commits January 27, 2026 13:19

Add base components

7f51cc6

Add BarChart component

50ba43e

Merge branch 'main' into add-search-bar-chart-component

338ea76

Integrate BarChart with search

4d0dd7a

Fix handling of negative values and chart rendering logic

a99d945

Fix interactions hooks and currency rendering logic

3538bf3

Fix X label rendering logic

98e8ce6

mateuuszzzzz changed the title ~~feat: Implement SearchBarChart component~~ feat: implement SearchBarChart component Jan 28, 2026

mateuuszzzzz added 2 commits January 27, 2026 16:45

Fix font loading on native

20f9c24

Fix margin

c898979

Update Podfile.lock

3850c6a

This comment has been minimized.

Sign in to view

mateuuszzzzz added 2 commits January 28, 2026 12:10

Run prettier

b3d8b64

Fix padding on mobile

0023402

neil-marcellini requested changes Jan 29, 2026

View reviewed changes

src/components/Charts/BarChart/BarChartContent.tsx Outdated Show resolved Hide resolved

Fix tooltip data for negative values

9c8cd70

Fix formatting

b9a9773

Merge branch 'main' into add-search-bar-chart-component

7c842f0

Add new group-by entries in config

a7fb202

neil-marcellini approved these changes Jan 29, 2026

View reviewed changes

neil-marcellini mentioned this pull request Jan 29, 2026

Date range is not auto-set to last month when using group-by in search #80958

Closed

ShridharGoel approved these changes Jan 29, 2026

View reviewed changes

melvin-bot bot requested a review from neil-marcellini January 29, 2026 23:53

neil-marcellini merged commit 1421019 into Expensify:main Jan 29, 2026
39 of 40 checks passed

github-actions bot mentioned this pull request Jan 30, 2026

Investigate workflow job failing on main: build (Debug, true) #80964

Closed

OSBotify mentioned this pull request Jan 30, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Closed

mitarachim mentioned this pull request Jan 31, 2026

[Due for payment - Feb 20th] [$250] Reports - Tooltip is cut off at the right end of the chart #81082

Closed

7 tasks

jponikarchuk mentioned this pull request Jan 31, 2026

Reports - view:bar is not included in the saved search name #81095

Open

7 tasks

OSBotify mentioned this pull request Jan 31, 2026

Reports - Clicking on amounts on the left side of chart on "Bar" view, leads to an expense #81099

Closed

7 tasks

This was referenced Jan 31, 2026

Expense - In view:bar, rupee symbol is not displayed correctly. #81112

Closed

Report - Expense report bar view displays “Oops something went wrong” #81149

Closed

[Insights] Bar chart displays Euro amounts using Indian number formatting #81192

Closed

Conversation

mateuuszzzzz commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

codecov bot commented Jan 27, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

This comment has been minimized.

puneetlath commented Jan 28, 2026

Uh oh!

puneetlath commented Jan 28, 2026

Uh oh!

shawnborton commented Jan 28, 2026

Uh oh!

shawnborton commented Jan 28, 2026

Uh oh!

trjExpensify commented Jan 28, 2026

Uh oh!

trjExpensify commented Jan 28, 2026

Uh oh!

dubielzyk-expensify commented Jan 28, 2026

Uh oh!

dubielzyk-expensify commented Jan 28, 2026

Uh oh!

shawnborton commented Jan 28, 2026

Uh oh!

dannymcclain commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

ShridharGoel commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ShridharGoel commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mateuuszzzzz commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShridharGoel commented Jan 29, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

ShridharGoel commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trjExpensify commented Jan 29, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 30, 2026

Uh oh!

OSBotify commented Jan 30, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

mateuuszzzzz commented Jan 27, 2026 •

edited

Loading

codecov bot commented Jan 27, 2026 •

edited by github-actions bot

Loading

ShridharGoel commented Jan 29, 2026 •

edited

Loading

ShridharGoel commented Jan 29, 2026 •

edited

Loading

mateuuszzzzz commented Jan 29, 2026 •

edited

Loading

ShridharGoel commented Jan 29, 2026 •

edited

Loading