-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feat: implement SearchBarChart component
#80658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
neil-marcellini
merged 47 commits into
Expensify:main
from
software-mansion-labs:add-search-bar-chart-component
Jan 29, 2026
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
a07371b
Add dependencies
mateuuszzzzz cb5844a
Update configs and setup scripts
mateuuszzzzz 7f51cc6
Add base components
mateuuszzzzz 50ba43e
Add BarChart component
mateuuszzzzz 338ea76
Merge branch 'main' into add-search-bar-chart-component
mateuuszzzzz 4d0dd7a
Integrate BarChart with search
mateuuszzzzz a99d945
Fix handling of negative values and chart rendering logic
mateuuszzzzz 3538bf3
Fix interactions hooks and currency rendering logic
mateuuszzzzz 98e8ce6
Fix X label rendering logic
mateuuszzzzz 20f9c24
Fix font loading on native
mateuuszzzzz c898979
Fix margin
mateuuszzzzz 3850c6a
Update Podfile.lock
mateuuszzzzz b3d8b64
Run prettier
mateuuszzzzz 0023402
Fix padding on mobile
mateuuszzzzz 519bde9
Fix ts error
mateuuszzzzz d1605fe
Add new words to cspell.json
mateuuszzzzz 1c930b9
Merge branch 'main' into add-search-bar-chart-component
mateuuszzzzz 9318793
Fix utility types
mateuuszzzzz 8c8f9de
Move titles to en.ts
mateuuszzzzz 2c7e504
Remove useChartColors hook and move to non-reactive solution
mateuuszzzzz 588aeb0
Add newline in proguard-rules.pro
mateuuszzzzz 4774f99
Move chart header up and make activity indicator themed
mateuuszzzzz 02a55c8
Rely on labels height when adding extra height
mateuuszzzzz eabf74f
Fix font path to use alias
mateuuszzzzz 247083c
Merge branch 'main' into add-search-bar-chart-component
mateuuszzzzz 7f443c8
Use useMemoizedLazyExpensifyIcons
mateuuszzzzz a360f78
Use Skia DataSourceParam for fonts
mateuuszzzzz 6346cb6
Add comment explaining why ESLint rule in SearchChartView is disabled
mateuuszzzzz fca5477
Add auto-generated translations
mateuuszzzzz 78c99e4
Add spanish translations
mateuuszzzzz 2e22ec0
Fix query utils regression
mateuuszzzzz 7f6f2f0
Fix tests
mateuuszzzzz 97238b4
Fix chart types
mateuuszzzzz 5b04b31
Add jest mocks
mateuuszzzzz b98390f
Fix mocks and unify behaviour of chart scroll and table scroll on mobile
mateuuszzzzz 5c565d6
Use DateUtils instead of custom date range implementation
mateuuszzzzz fe9eabd
Add warning on failure of buildSearchQueryJSON
mateuuszzzzz ebe2071
Make sure we fallback to category group-by when we don't use it expli…
mateuuszzzzz 6fbc6e7
Remove unused constants
mateuuszzzzz 8872a36
Use convertToFrontendAmountAsInteger instead of custom implementation
mateuuszzzzz 03d7bab
Add percentage value to tooltip
mateuuszzzzz 492ab92
Fix tests to respect default group-by fallback when view param is used
mateuuszzzzz c745a1b
Fix issue with domain clipping when only positive values are rendered
mateuuszzzzz 9c8cd70
Fix tooltip data for negative values
mateuuszzzzz b9a9773
Fix formatting
mateuuszzzzz 7c842f0
Merge branch 'main' into add-search-bar-chart-component
mateuuszzzzz a7fb202
Add new group-by entries in config
mateuuszzzzz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -820,6 +820,8 @@ | |
| "Wooo", | ||
| "Splittable", | ||
| "pgrep", | ||
| "skia", | ||
| "canvaskit", | ||
| "Invoicify" | ||
| ], | ||
| "ignorePaths": [ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.