Add support for view:line and view:pie by puneetlath · Pull Request #80768 · Expensify/App

puneetlath · 2026-01-28T18:23:56Z

Explanation of Change

Adds support for view:line and view:pie in the query language, with auto-complete support.

Fixed Issues

$ #80760
$ #80762

Tests

Go to Reports > Expenses
Type type:expense group-by:category into the search bar
Type view:
You should see auto-complete options for table, line, bar, pie
Selecting any of the options (or typing it without selecting) should highlight it in blue
Type something like view:banana
It should not highlight and still render the normal table view

Verify that no errors appear in the JS console

Offline tests

Same as online tests.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

CleanShot.2026-01-28.at.12.05.14.mp4

- Add LINE: 'line' and PIE: 'pie' to CONST.SEARCH.VIEW - Add VIEW: 'view' to CONST.SEARCH.SEARCH_USER_FRIENDLY_KEYS Part of implementing view:line and view:pie support in search query language

- Add test cases for view:line parameter parsing - Add test cases for view:pie parameter parsing - Tests verify that view values are correctly parsed in search queries

- Add viewAutocompleteList useMemo to generate view suggestions - Add VIEW case to autocompleteSuggestions switch in SearchAutocompleteList - Add userFriendlyViewList constant for validation - Add VIEW validation case in filterOutRangesWithCorrectValue function This enables autocomplete suggestions for view values (table, bar, line, pie) when users type 'view:' in the search query.

- Add tests for view:bar, view:line, and view:pie in getQueryWithUpdatedValues - Fix buildSearchQueryString to preserve view when it differs from default - View parameter is now correctly preserved when query is updated Tests verify that view values are correctly parsed and preserved in search queries.

- Add test to verify all view values (table, bar, line, pie) are included - Add test to verify view values are correctly mapped to user-friendly values - Tests ensure view autocomplete suggestions work correctly These tests verify that the view autocomplete list generation logic correctly includes all four view types and maps them properly.

- Add 'view' to autocompleteKey rule in autocompleteParser.peggy - Regenerate autocompleteParser.js - This enables autocomplete suggestions to appear when typing 'view:' Previously, view was missing from the autocompleteKey rule, so the parser didn't recognize 'view:' as a key that should trigger autocomplete suggestions. Now autocomplete works for view: just like it does for group-by:

- Fix nullish coalescing operator usage in buildSearchQueryString - Replace require() with proper import for getUserFriendlyValue in tests - All lint errors resolved, tests passing

…utocomplete validation - Add 7 tests for buildSearchQueryString covering view parameter edge cases - Add 8 tests for view filter validation in parseForLiveMarkdown - Cover all view types (table, bar, line, pie) individually - Tests verify view is included/excluded correctly based on rawFilterList and default values

- Add VIEW to SearchFilterKey type to fix TypeScript errors in switch statements - Add VIEW filter key to FILTER_KEYS constant - Add VIEW property to SearchAdvancedFiltersForm type definition - Resolves typecheck errors in SearchAutocompleteUtils and SearchAutocompleteList

melvin-bot · 2026-01-28T20:08:54Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/Search/SearchAutocompleteList.tsx

ShridharGoel · 2026-01-28T20:41:54Z

view:line gets removed when any other filter is applied. Is that expected?

Screen.Recording.2026-01-29.at.2.10.30.AM.mov

ShridharGoel · 2026-01-28T20:48:53Z

Bug: view:line does not show in recent search. The whole query shows, but the view:line part is omitted.

This is probably because buildUserReadableQueryString omits view in the fallback path (when rawFilterList is absent).

Screen.Recording.2026-01-29.at.2.16.49.AM.mov

ShridharGoel · 2026-01-28T20:49:46Z

view is not supposed to be a part of the advanced filters list, right?

- Add viewAutocompleteList to dependency array to satisfy ESLint exhaustive-deps rule - Ensures hook correctly tracks all dependencies for maintainability - Consistent with other autocomplete lists (groupByAutocompleteList, statusAutocompleteList)

puneetlath · 2026-01-28T21:44:12Z

view is not supposed to be a part of the advanced filters list, right?

Are you referring to this modal? If so, it's expected that it doesn't show there for now.

ShridharGoel · 2026-01-28T21:45:32Z

Are you referring to this modal? If so, it's expected that it doesn't show there for now.

Yes, thanks for the confirmation.

puneetlath · 2026-01-28T21:56:38Z

Working on the other two issues.

puneetlath · 2026-01-28T22:32:35Z

Ok, so I looked into the other two and they have to do with the fact that this isn't an in-product filter and only available when you enter manually. So they should get addressed in #80779. So I think you can proceed @ShridharGoel

trjExpensify

Core PR for a WN project, no qualms from me! 👍

trjExpensify · 2026-01-28T23:43:52Z

@cristipaval or @neil-marcellini can you take the internal review with the context?

srikarparsi

Looks good to me as well. @ShridharGoel would you be able to complete the reviewer checklist?

ShridharGoel · 2026-01-29T02:12:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-29.at.1.56.34.AM.mov

melvin-bot · 2026-01-29T02:13:24Z

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

puneetlath · 2026-01-29T02:14:34Z

We've got plenty of reviews, so going to merge.

OSBotify · 2026-01-29T02:23:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-30T22:18:08Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.11-16 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jponikarchuk · 2026-01-31T14:46:52Z

This PR failing because of the issue
This issue is reproducible in: All platforms

1.mp4

OSBotify · 2026-02-05T20:24:20Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

puneetlath added 4 commits January 28, 2026 09:55

feat: add LINE and PIE constants to SEARCH.VIEW

b0830d6

- Add LINE: 'line' and PIE: 'pie' to CONST.SEARCH.VIEW - Add VIEW: 'view' to CONST.SEARCH.SEARCH_USER_FRIENDLY_KEYS Part of implementing view:line and view:pie support in search query language

test: add tests for view:line and view:pie parsing

0df21b1

- Add test cases for view:line parameter parsing - Add test cases for view:pie parameter parsing - Tests verify that view values are correctly parsed in search queries

puneetlath self-assigned this Jan 28, 2026

puneetlath added 3 commits January 28, 2026 10:24

fix: resolve lint errors in view parameter implementation

339ae40

- Fix nullish coalescing operator usage in buildSearchQueryString - Replace require() with proper import for getUserFriendlyValue in tests - All lint errors resolved, tests passing

This comment was marked as resolved.

Sign in to view

puneetlath added 3 commits January 28, 2026 10:44

prettier

296e070

puneetlath requested a review from ShridharGoel January 28, 2026 20:06

puneetlath marked this pull request as ready for review January 28, 2026 20:08

puneetlath requested review from a team as code owners January 28, 2026 20:08

melvin-bot bot requested review from srikarparsi and trjExpensify and removed request for a team January 28, 2026 20:08

melvin-bot bot removed the request for review from a team January 28, 2026 20:08

ShridharGoel reviewed Jan 28, 2026

View reviewed changes

src/components/Search/SearchAutocompleteList.tsx Show resolved Hide resolved

trjExpensify approved these changes Jan 28, 2026

View reviewed changes

cristipaval approved these changes Jan 28, 2026

View reviewed changes

srikarparsi approved these changes Jan 29, 2026

View reviewed changes

ShridharGoel approved these changes Jan 29, 2026

View reviewed changes

melvin-bot bot requested a review from mjasikowski January 29, 2026 02:13

puneetlath merged commit 4001075 into main Jan 29, 2026
34 of 38 checks passed

puneetlath deleted the puneet-view-line-pie branch January 29, 2026 02:14

trjExpensify mentioned this pull request Jan 29, 2026

feat: implement SearchBarChart component #80658

Merged

51 tasks

OSBotify mentioned this pull request Jan 30, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Closed

jponikarchuk mentioned this pull request Jan 31, 2026

Web - Reports - "Pie" and "Line" autocomplete options not displayed #81108

Closed

7 tasks

Conversation

puneetlath commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

This comment was marked as resolved.

melvin-bot bot commented Jan 28, 2026

Uh oh!

Uh oh!

ShridharGoel commented Jan 28, 2026

Uh oh!

ShridharGoel commented Jan 28, 2026

Uh oh!

ShridharGoel commented Jan 28, 2026

Uh oh!

puneetlath commented Jan 28, 2026

Uh oh!

ShridharGoel commented Jan 28, 2026

Uh oh!

puneetlath commented Jan 28, 2026

Uh oh!

puneetlath commented Jan 28, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

trjExpensify commented Jan 28, 2026

Uh oh!

srikarparsi left a comment

Choose a reason for hiding this comment

Uh oh!

ShridharGoel commented Jan 29, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 29, 2026

Uh oh!

puneetlath commented Jan 29, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 29, 2026

Uh oh!

OSBotify commented Jan 30, 2026

Uh oh!

jponikarchuk commented Jan 31, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

puneetlath commented Jan 28, 2026 •

edited

Loading