[Home Page] [Release 3] Add card fraud alert

[mountiny]

Explanation of Change

Details

This PR implements the Card Fraud Alert time-sensitive widget for the Home page as part of Release 3.

When a user's Expensify Card has potential fraud detected (either individual-level or domain-level), a high-priority alert widget appears in the Time Sensitive section, prompting them to review the suspicious activity.

Changes

New Component: ReviewCardFraud.tsx

• Displays a time-sensitive widget when card.fraud === 'domain' or card.fraud === 'individual'
• Fetches fraud details (amount, merchant, currency) from the associated report action
• Uses CurrencyUtils.convertToDisplayString() to format the transaction amount
• Shows dynamic title: "Review $500 in potential fraud at Gucci" when details are available
• Falls back to generic title: "Review potential fraud on your Expensify Card" if details not loaded
• Navigates to the fraud alert report on CTA press
• Uses danger styling (tangerine background, red button) to indicate urgency

Type Extensions: Card.ts

• Added PossibleFraudData type with fraudAlertReportID and fraudAlertReportActionID for deeplink navigation
• Added CardMessage type containing possibleFraud data
• Extended Card type with optional message field

Selector Updates: Card.ts

• Added isCardWithPotentialFraud() helper function
• Extended timeSensitiveCardsSelector to return cardsWithFraud array

Hook Updates: useTimeSensitiveCards.ts

• Added cardsWithFraud and shouldShowReviewCardFraud to return values

TimeSensitiveSection Updates

• Renders fraud alert widget with highest priority (before discount offers, shipping, activation)

Fixed Issues

$ #79992
PROPOSAL:

Tests

Prerequisites:
Logged in user with an Expensify Card

Test Steps

1. Apply mock data - Open browser DevTools console and run:

Onyx.merge('cardList', { '12345': { cardID: 12345, accountID: 18439984, bank: 'Expensify Card', availableSpend: 5000, domainName: 'expensify-policy123.exfy', fraud: 'individual', fundID: '123456', lastFourPAN: '1234', state: 3, isVirtual: false, nameValuePairs: { isVirtual: false }, message: { possibleFraud: { state: 1, date: '2025-01-29',triggerAmount: 50000, triggerMerchant: 'Gucci', triggerCurrency: 'GBP', fraudAlertReportID: 999888777, fraudAlertReportActionID: 111222333 } } } });

Onyx.merge('reportActions_999888777', { '111222333': { reportActionID: '111222333', actionName: 'ACTIONABLECARDFAUDALERT', created: '2025-01-29 10:00:00.000', actorAccountID: 1, originalMessage: { cardID: 12345, maskedCardNumber: 'XXXXXXXXXXXX1234', triggerAmount: 50000, triggerMerchant: 'Gucci', currency: 'USD' } } });

1. Navigate to Home page
2. Verify widget appears in the Time Sensitive section with:

• Expensify Card icon with tangerine background
• Title: "Review $500.00 in potential fraud at Gucci"
• Subtitle: "Expensify Card"
• Red "Review" button

1. Click "Review" button - should navigate to the fraud alert report
2. Test fallback title - Apply mock without report action:

Onyx.merge('cardList', { '99999': { cardID: 99999, accountID: 18439984, bank: 'Expensify Card', fraud: 'domain', fundID: '123456', state: 3, nameValuePairs: { isVirtual: false } } });

1. Should show generic title: "Review potential fraud on your Expensify Card"
2. Test priority - Verify fraud widget appears above discount offers and card activation widgets
3. Test exclusion - Cards with fraud: 'none' should NOT show the widget

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as steps
// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I verified that similar component doesn't exist in the codebase
• I verified that all props are defined accurately and each prop has a /** comment above it */
• I verified that each file is named correctly
• I verified that each component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
• I verified that the only data being stored in component state is data necessary for rendering and nothing else
• In component if we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
• For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
• I verified that component internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
• I verified that all JSX used for rendering exists in the render method
• I verified that each component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

The merge-base changed after approval.

[mountiny]

@grgia @youssef-lr ready for the review

[youssef-lr]

LGTM

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.3.17-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[youssef-lr]

@mountiny I'm seeing this for the 2nd mock data without report action

[IuliiaHerets]

Hi @mountiny. Can this PR be executed on the Native apps?

[mountiny]

We need to wait for some customer to hit this issue afresh so we can supportal to their account and test there

[nlemma]

@mountiny this PR is failing due to #82242

[mountiny]

Looking into that, no need to block the deploy

[OSBotify]

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌