[No QA] fix: improve CLEAN-REACT-PATTERNS-* rules detection by adhorodyski · Pull Request #82443 · Expensify/App

adhorodyski · 2026-02-13T17:05:01Z

Explanation of Change

CLEAN-REACT-PATTERNS-1 (Composition over Configuration): Restructured search patterns to be per-case, broadened boolean prop detection (should\w+, can\w+), added new cases for config-array driven rendering (Case 4), render function props (Case 5), and ReactNode slot props (Case 6). Also closes loopholes, clarifies the presentational prop exception, and adds DO NOT flag exceptions for thin platform wrappers, children, list callbacks, and runtime data.
CLEAN-REACT-PATTERNS-4 (No Side-Effect Spaghetti): Added detection for internal render helpers (renderContent, renderTodoItems, etc.) as single-responsibility violations that hide the render tree and prevent React Compiler memoization.

Tested against:
#82229
#80829
#81058
#80974
#80931
#80951

Fixed Issues

$ #74367
PROPOSAL:

Tests

Ask Claude Code to dry-run the code-inline-reviewer (agent) against any PR and report you back violations.

Offline tests

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

.claude/agents/code-inline-reviewer.md

TMisiukiewicz · 2026-02-16T08:10:30Z

I'd also ensure these rules apply to hooks - see this discussion for reference. Right now they only cover components

.claude/agents/code-inline-reviewer.md

…rule - Broaden Case 1 search patterns to should\w+ and can\w+ (VickyStash) - Generalize Case 1 condition to reference search patterns (VickyStash) - Remove onChange from Case 3 monolithic prop example (VickyStash) - Add DO NOT flag for thin platform primitive wrappers (TMisiukiewicz) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Explicitly note that booleans selecting between layout/styling strategies on focused components (e.g., shouldUseAspectRatio) fall under the existing presentational prop exception and should not be flagged as composition-over-configuration violations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Adds detection for statically-known items encoded as data arrays and .map()'d through generic components — a pattern missed during PR Expensify#80829 review. Includes incorrect/correct examples, review metadata conditions, DO NOT flag exceptions for runtime data and list components, and search patterns. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Add ReactNode slot props as Case 2 variant (leftComponent, rightComponent, etc.) - Add Case 5: render function props (renderTitle, renderSubtitle, etc.) - Add correct examples: compound component slots, Suspense over isLoading - Fix Case 2 detection step 4: test "only for conditional rendering" not "only one place" - Close Case 4 cosmetic compliance loophole (compound components inside .map) - Replace Case 3 numeric threshold with qualitative guideline - Add DO NOT flag exceptions for children, list callbacks, per-item runtime data - Add search patterns for Case 5 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Render helpers (renderContent, renderTodoItems, etc.) are a single-responsibility violation — they hide the render tree and prevent React Compiler memoization. Added incorrect example, detection conditions, exceptions, and search patterns. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…in CLEAN-REACT-PATTERNS-1 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

melvin-bot · 2026-02-18T17:30:20Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2026-02-18T21:19:50Z

@adhorodyski Seems like you already tested this with bunch of PRs, did you want to do any more tests?

mountiny · 2026-02-19T08:15:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

OSBotify · 2026-02-19T08:56:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-19T18:01:44Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.23-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-20T16:11:37Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.23-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned adhorodyski Feb 13, 2026

VickyStash reviewed Feb 16, 2026

View reviewed changes

TMisiukiewicz reviewed Feb 16, 2026

View reviewed changes

.claude/agents/code-inline-reviewer.md Outdated Show resolved Hide resolved

.claude/agents/code-inline-reviewer.md Outdated Show resolved Hide resolved

adhorodyski force-pushed the fix/composition-over-configuration branch from 002c915 to 8b1c388 Compare February 16, 2026 14:15

adhorodyski and others added 4 commits February 17, 2026 17:08

adhorodyski changed the title ~~fix: improve CLEAN-REACT-PATTERNS-1 Case 2 detection~~ fix: improve CLEAN-REACT-PATTERNS-* rules detection Feb 18, 2026

adhorodyski mentioned this pull request Feb 18, 2026

[Due for payment 2026-02-27] [Due for payment 2026-02-23] [Due for payment 2026-02-17] [Tracking] Removing React Anti-Patterns #74367

Closed

5 tasks

Close consumer-vs-creator loophole, tighten presentational exception …

782db44

…in CLEAN-REACT-PATTERNS-1 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

adhorodyski marked this pull request as ready for review February 18, 2026 17:30

adhorodyski requested a review from a team as a code owner February 18, 2026 17:30

melvin-bot bot requested review from truph01 and removed request for a team February 18, 2026 17:30

adhorodyski changed the title ~~fix: improve CLEAN-REACT-PATTERNS-* rules detection~~ [No QA] fix: improve CLEAN-REACT-PATTERNS-* rules detection Feb 18, 2026

mountiny self-requested a review February 18, 2026 20:58

mountiny approved these changes Feb 19, 2026

View reviewed changes

mountiny merged commit 533432a into Expensify:main Feb 19, 2026
15 checks passed

adhorodyski deleted the fix/composition-over-configuration branch February 19, 2026 09:26

OSBotify mentioned this pull request Feb 19, 2026

Deploy Checklist: New Expensify 2026-02-19 #82970

Closed

41 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] fix: improve CLEAN-REACT-PATTERNS-* rules detection#82443

[No QA] fix: improve CLEAN-REACT-PATTERNS-* rules detection#82443
mountiny merged 6 commits intoExpensify:mainfrom
callstack-internal:fix/composition-over-configuration

adhorodyski commented Feb 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TMisiukiewicz commented Feb 16, 2026

Uh oh!

Uh oh!

Uh oh!

melvin-bot bot commented Feb 18, 2026

Uh oh!

mountiny commented Feb 18, 2026

Uh oh!

mountiny commented Feb 19, 2026

Uh oh!

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

OSBotify commented Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

adhorodyski commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TMisiukiewicz commented Feb 16, 2026

Uh oh!

Uh oh!

Uh oh!

melvin-bot bot commented Feb 18, 2026

Uh oh!

mountiny commented Feb 18, 2026

Uh oh!

mountiny commented Feb 19, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

OSBotify commented Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

adhorodyski commented Feb 13, 2026 •

edited

Loading