[Home Page] Create ForYouSection Component#80829
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index ab9aca8e..0fbe7421 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -8217,8 +8217,21 @@ Hier ist ein *Testbeleg*, um dir zu zeigen, wie es funktioniert:`,
discoverSection: {
title: 'Entdecken',
menuItemTitleNonAdmin: 'Erfahren Sie, wie Sie Ausgaben erstellen und Berichte einreichen.',
- menuItemTitleAdmin: 'Erfahren Sie, wie Sie Mitglieder einladen, Genehmigungsworkflows bearbeiten und Firmenkarten abstimmen.',
- menuItemDescription: 'Sehen Sie, was Expensify in 2 Minuten kann',
+ menuItemTitleAdmin: 'Erfahren Sie, wie Sie Mitglieder einladen, Genehmigungs-Workflows bearbeiten und Firmenkarten abstimmen.',
+ menuItemDescription: 'Sieh dir in 2 Minuten an, was Expensify kann',
+ },
+ forYouSection: {
+ submit: ({count}: {count: number}) => `Sende ${count} ${count === 1 ? 'Bericht' : 'Berichte'}`,
+ approve: ({count}: {count: number}) => `Genehmige ${count} ${count === 1 ? 'Bericht' : 'Berichte'}`,
+ pay: ({count}: {count: number}) => `Bezahlen ${count} ${count === 1 ? 'Bericht' : 'Berichte'}`,
+ export: ({count}: {count: number}) => `${count} ${count === 1 ? 'Bericht' : 'Berichte'} exportieren`,
+ begin: 'Beginnen',
+ emptyStateMessages: {
+ nicelyDone: 'Gut gemacht',
+ keepAnEyeOut: 'Behalte im Blick, was als Nächstes kommt!',
+ allCaughtUp: 'Du bist auf dem neuesten Stand',
+ upcomingTodos: 'Anstehende To-dos werden hier angezeigt.',
+ },
},
},
};
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 52e3d950..a258c40b 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -8223,8 +8223,21 @@ Voici un *reçu test* pour vous montrer comment cela fonctionne :`,
discoverSection: {
title: 'Découvrir',
menuItemTitleNonAdmin: 'Découvrez comment créer des dépenses et soumettre des rapports.',
- menuItemTitleAdmin: 'Apprenez à inviter des membres, à modifier les circuits d’approbation et à rapprocher les cartes de l’entreprise.',
- menuItemDescription: 'Découvrez ce qu’Expensify peut faire en 2 minutes',
+ menuItemTitleAdmin: 'Apprenez à inviter des membres, modifier les workflows d’approbation et rapprocher les cartes de société.',
+ menuItemDescription: 'Découvrez ce qu’Expensify peut faire en 2 minutes',
+ },
+ forYouSection: {
+ submit: ({count}: {count: number}) => `Soumettre ${count} ${count === 1 ? 'rapport' : 'rapports'}`,
+ approve: ({count}: {count: number}) => `Approuver ${count} ${count === 1 ? 'rapport' : 'rapports'}`,
+ pay: ({count}: {count: number}) => `Payer ${count} ${count === 1 ? 'rapport' : 'rapports'}`,
+ export: ({count}: {count: number}) => `Exporter ${count} ${count === 1 ? 'rapport' : 'rapports'}`,
+ begin: 'Commencer',
+ emptyStateMessages: {
+ nicelyDone: 'Bien joué',
+ keepAnEyeOut: 'Restez à l’affût de ce qui arrive bientôt !',
+ allCaughtUp: 'Vous êtes à jour',
+ upcomingTodos: 'Les tâches à venir apparaîtront ici.',
+ },
},
},
};
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 1b17f3cd..3f5693f6 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -6988,7 +6988,7 @@ Richiedi dettagli di spesa come ricevute e descrizioni, imposta limiti e valori
[CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID prelievo', //_/\__/_/ \_,_/\__/\__/\_,_/
[CONST.SEARCH.GROUP_BY.CATEGORY]: 'Categoria',
[CONST.SEARCH.GROUP_BY.MERCHANT]: 'Esercente',
- [CONST.SEARCH.GROUP_BY.TAG]: 'Tag',
+ [CONST.SEARCH.GROUP_BY.TAG]: 'Etichetta',
[CONST.SEARCH.GROUP_BY.MONTH]: 'Mese',
},
feed: 'Feed',
@@ -8203,9 +8203,22 @@ Ecco una *ricevuta di prova* per mostrarti come funziona:`,
discoverSection: {
title: 'Scopri',
menuItemTitleNonAdmin: 'Scopri come creare spese e inviare report.',
- menuItemTitleAdmin: 'Scopri come invitare membri, modificare i flussi di approvazione e riconciliare le carte aziendali.',
+ menuItemTitleAdmin: 'Scopri come invitare i membri, modificare i flussi di approvazione e riconciliare le carte aziendali.',
menuItemDescription: 'Scopri cosa può fare Expensify in 2 minuti',
},
+ forYouSection: {
+ submit: ({count}: {count: number}) => `Invia ${count} ${count === 1 ? 'rendiconto' : 'rapporti'}`,
+ approve: ({count}: {count: number}) => `Approva ${count} ${count === 1 ? 'rendiconto' : 'rapporti'}`,
+ pay: ({count}: {count: number}) => `Paga ${count} ${count === 1 ? 'rendiconto' : 'rapporti'}`,
+ export: ({count}: {count: number}) => `Esporta ${count} ${count === 1 ? 'rendiconto' : 'rapporti'}`,
+ begin: 'Inizia',
+ emptyStateMessages: {
+ nicelyDone: 'Ben fatto',
+ keepAnEyeOut: 'Tieni d’occhio cosa arriverà dopo!',
+ allCaughtUp: 'Sei in pari',
+ upcomingTodos: 'Le prossime attività da fare verranno visualizzate qui.',
+ },
+ },
},
};
// IMPORTANT: This line is manually replaced in generate translation files by scripts/generateTranslations.ts,
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 6e70da58..38fdae7c 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -6925,7 +6925,7 @@ ${reportName}
groupBy: {
[CONST.SEARCH.GROUP_BY.FROM]: '差出人',
[CONST.SEARCH.GROUP_BY.CARD]: 'カード',
- [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: '出金ID',
+ [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: '出金 ID',
[CONST.SEARCH.GROUP_BY.CATEGORY]: 'カテゴリ',
[CONST.SEARCH.GROUP_BY.MERCHANT]: '加盟店',
[CONST.SEARCH.GROUP_BY.TAG]: 'タグ',
@@ -8116,8 +8116,21 @@ Expensify の使い方をお見せするための*テストレシート*がこ
discoverSection: {
title: '発見',
menuItemTitleNonAdmin: '経費の作成方法とレポートの提出方法を学びましょう。',
- menuItemTitleAdmin: 'メンバーの招待方法、承認ワークフローの編集方法、会社カードの照合方法について学びましょう。',
- menuItemDescription: '2 分で Expensify でできることを確認する',
+ menuItemTitleAdmin: 'メンバーの招待方法、承認ワークフローの編集方法、会社カードの照合作業について学びましょう。',
+ menuItemDescription: '2分でExpensifyでできることを確認する',
+ },
+ forYouSection: {
+ submit: ({count}: {count: number}) => `${count} ${count === 1 ? 'レポート' : 'レポート'} を提出`,
+ approve: ({count}: {count: number}) => `${count} ${count === 1 ? 'レポート' : 'レポート'} を承認`,
+ pay: ({count}: {count: number}) => `${count} ${count === 1 ? 'レポート' : 'レポート'} を支払う`,
+ export: ({count}: {count: number}) => `${count} ${count === 1 ? 'レポート' : 'レポート'} をエクスポート`,
+ begin: '開始',
+ emptyStateMessages: {
+ nicelyDone: 'よくできました',
+ keepAnEyeOut: '次に何が来るか注目していてください！',
+ allCaughtUp: 'すべて確認済みです',
+ upcomingTodos: '今後のTo-doがここに表示されます。',
+ },
},
},
};
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 2ddc9f82..3f2387d0 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -6971,7 +6971,7 @@ Vraag verplichte uitgavedetails zoals bonnetjes en beschrijvingen, stel limieten
[CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'Opname-ID',
[CONST.SEARCH.GROUP_BY.CATEGORY]: 'Categorie',
[CONST.SEARCH.GROUP_BY.MERCHANT]: 'Handelaar',
- [CONST.SEARCH.GROUP_BY.TAG]: 'Tag',
+ [CONST.SEARCH.GROUP_BY.TAG]: 'Label',
[CONST.SEARCH.GROUP_BY.MONTH]: 'Maand',
},
feed: 'Feed',
@@ -8177,10 +8177,23 @@ Hier is een *testbon* om je te laten zien hoe het werkt:`,
forYou: 'Voor jou',
announcements: 'Aankondigingen',
discoverSection: {
- title: 'Ontdek',
+ title: 'Ontdekken',
menuItemTitleNonAdmin: 'Leer hoe je uitgaven aanmaakt en rapporten indient.',
menuItemTitleAdmin: 'Leer hoe u leden uitnodigt, goedkeuringsworkflows bewerkt en bedrijfskaarten afstemt.',
- menuItemDescription: 'Ontdek wat Expensify in 2 minuten kan doen',
+ menuItemDescription: 'Zie wat Expensify in 2 minuten kan doen',
+ },
+ forYouSection: {
+ submit: ({count}: {count: number}) => `Verzend ${count} ${count === 1 ? 'rapport' : 'rapporten'}`,
+ approve: ({count}: {count: number}) => `Goedkeuren ${count} ${count === 1 ? 'rapport' : 'rapporten'}`,
+ pay: ({count}: {count: number}) => `Betaal ${count} ${count === 1 ? 'rapport' : 'rapporten'}`,
+ export: ({count}: {count: number}) => `Exporteer ${count} ${count === 1 ? 'rapport' : 'rapporten'}`,
+ begin: 'Beginnen',
+ emptyStateMessages: {
+ nicelyDone: 'Goed gedaan',
+ keepAnEyeOut: 'Houd in de gaten wat er binnenkort komt!',
+ allCaughtUp: 'Je bent helemaal bij',
+ upcomingTodos: 'Aankomende taken verschijnen hier.',
+ },
},
},
};
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index d5865831..af0937c4 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -6957,7 +6957,7 @@ Wymagaj szczegółów wydatków, takich jak paragony i opisy, ustawiaj limity i
groupBy: {
[CONST.SEARCH.GROUP_BY.FROM]: 'Od',
[CONST.SEARCH.GROUP_BY.CARD]: 'Karta',
- [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID wypłaty',
+ [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'Identyfikator wypłaty',
[CONST.SEARCH.GROUP_BY.CATEGORY]: 'Kategoria',
[CONST.SEARCH.GROUP_BY.MERCHANT]: 'Sprzedawca',
[CONST.SEARCH.GROUP_BY.TAG]: 'Etykieta',
@@ -8160,13 +8160,26 @@ Oto *paragon testowy*, który pokazuje, jak to działa:`,
fabGpsTripExplained: 'Przejdź do ekranu GPS (przycisk akcji)',
},
homePage: {
- forYou: 'Dla ciebie',
+ forYou: 'Dla Ciebie',
announcements: 'Ogłoszenia',
discoverSection: {
title: 'Odkryj',
- menuItemTitleNonAdmin: 'Dowiedz się, jak tworzyć wydatki i składać raporty.',
- menuItemTitleAdmin: 'Dowiedz się, jak zapraszać członków, edytować przepływy akceptacji i uzgadniać karty firmowe.',
- menuItemDescription: 'Zobacz, co Expensify potrafi w 2 minuty',
+ menuItemTitleNonAdmin: 'Dowiedz się, jak tworzyć wydatki i przesyłać raporty.',
+ menuItemTitleAdmin: 'Dowiedz się, jak zapraszać członków, edytować ścieżki zatwierdzania i uzgadniać karty firmowe.',
+ menuItemDescription: 'Zobacz, co Expensify potrafi zrobić w 2 min',
+ },
+ forYouSection: {
+ submit: ({count}: {count: number}) => `Prześlij ${count} ${count === 1 ? 'raport' : 'raporty'}`,
+ approve: ({count}: {count: number}) => `Zatwierdź ${count} ${count === 1 ? 'raport' : 'raporty'}`,
+ pay: ({count}: {count: number}) => `Zapłać ${count} ${count === 1 ? 'raport' : 'raporty'}`,
+ export: ({count}: {count: number}) => `Eksportuj ${count} ${count === 1 ? 'raport' : 'raporty'}`,
+ begin: 'Rozpocznij',
+ emptyStateMessages: {
+ nicelyDone: 'Dobra robota',
+ keepAnEyeOut: 'Wypatruj, co nadchodzi wkrótce!',
+ allCaughtUp: 'Wszystko nadrobione',
+ upcomingTodos: 'Nadchodzące zadania do wykonania pojawią się tutaj.',
+ },
},
},
};
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 0f08e19e..b3d3d2b1 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -6958,9 +6958,9 @@ Exija detalhes de despesas como recibos e descrições, defina limites e padrõe
groupBy: {
[CONST.SEARCH.GROUP_BY.FROM]: 'De',
[CONST.SEARCH.GROUP_BY.CARD]: 'Cartão',
- [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID da retirada',
+ [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: 'ID de saque',
[CONST.SEARCH.GROUP_BY.CATEGORY]: 'Categoria',
- [CONST.SEARCH.GROUP_BY.MERCHANT]: 'Estabelecimento',
+ [CONST.SEARCH.GROUP_BY.MERCHANT]: 'Comerciante',
[CONST.SEARCH.GROUP_BY.TAG]: 'Etiqueta',
[CONST.SEARCH.GROUP_BY.MONTH]: 'Mês',
},
@@ -8173,10 +8173,23 @@ Aqui está um *recibo de teste* para mostrar como funciona:`,
announcements: 'Anúncios',
discoverSection: {
title: 'Descobrir',
- menuItemTitleNonAdmin: 'Aprenda a criar despesas e enviar relatórios.',
- menuItemTitleAdmin: 'Aprenda a convidar membros, editar fluxos de aprovação e reconciliar cartões corporativos.',
+ menuItemTitleNonAdmin: 'Aprenda como criar despesas e enviar relatórios.',
+ menuItemTitleAdmin: 'Aprenda como convidar membros, editar fluxos de aprovação e reconciliar cartões corporativos.',
menuItemDescription: 'Veja o que o Expensify pode fazer em 2 minutos',
},
+ forYouSection: {
+ submit: ({count}: {count: number}) => `Enviar ${count} ${count === 1 ? 'relatório' : 'relatórios'}`,
+ approve: ({count}: {count: number}) => `Aprovar ${count} ${count === 1 ? 'relatório' : 'relatórios'}`,
+ pay: ({count}: {count: number}) => `Pagar ${count} ${count === 1 ? 'relatório' : 'relatórios'}`,
+ export: ({count}: {count: number}) => `Exportar ${count} ${count === 1 ? 'relatório' : 'relatórios'}`,
+ begin: 'Iniciar',
+ emptyStateMessages: {
+ nicelyDone: 'Muito bem feito',
+ keepAnEyeOut: 'Fique de olho no que vem a seguir!',
+ allCaughtUp: 'Você está em dia',
+ upcomingTodos: 'Próximas tarefas aparecerão aqui.',
+ },
+ },
},
};
// IMPORTANT: This line is manually replaced in generate translation files by scripts/generateTranslations.ts,
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index a78ef128..f6be0e26 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -6803,13 +6803,13 @@ ${reportName}
reimbursable: '可报销',
purchaseCurrency: '购买货币',
groupBy: {
- [CONST.SEARCH.GROUP_BY.FROM]: '来自',
- [CONST.SEARCH.GROUP_BY.CARD]: '卡',
- [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: '提现编号',
+ [CONST.SEARCH.GROUP_BY.FROM]: '发件人',
+ [CONST.SEARCH.GROUP_BY.CARD]: '卡片',
+ [CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID]: '提现 ID',
[CONST.SEARCH.GROUP_BY.CATEGORY]: '类别',
- [CONST.SEARCH.GROUP_BY.MERCHANT]: '商户',
+ [CONST.SEARCH.GROUP_BY.MERCHANT]: '商家',
[CONST.SEARCH.GROUP_BY.TAG]: '标签',
- [CONST.SEARCH.GROUP_BY.MONTH]: '月',
+ [CONST.SEARCH.GROUP_BY.MONTH]: '月份',
},
feed: '动态',
withdrawalType: {
@@ -7938,10 +7938,18 @@ ${reportName}
announcements: '公告',
discoverSection: {
title: '发现',
- menuItemTitleNonAdmin: '了解如何创建费用并提交报表。',
- menuItemTitleAdmin: '了解如何邀请成员、编辑审批流程以及对公司卡进行对账。',
+ menuItemTitleNonAdmin: '了解如何创建报销和提交报告。',
+ menuItemTitleAdmin: '了解如何邀请成员、编辑审批流程以及对公司信用卡进行对账。',
menuItemDescription: '看看 Expensify 在 2 分钟内能为你做什么',
},
+ forYouSection: {
+ submit: ({count}: {count: number}) => `提交 ${count} ${count === 1 ? '报销单' : '报销单'}`,
+ approve: ({count}: {count: number}) => `批准 ${count} ${count === 1 ? '报销单' : '报销单'}`,
+ pay: ({count}: {count: number}) => `支付 ${count} ${count === 1 ? '报销单' : '报销单'}`,
+ export: ({count}: {count: number}) => `导出 ${count} ${count === 1 ? '报销单' : '报销单'}`,
+ begin: '开始',
+ emptyStateMessages: {nicelyDone: '做得很好', keepAnEyeOut: '敬请关注接下来的更新！', allCaughtUp: '你已经全部看完了', upcomingTodos: '即将进行的待办事项会显示在此处。'},
+ },
},
};
// IMPORTANT: This line is manually replaced in generate translation files by scripts/generateTranslations.ts,
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
adamgrzybowski
force-pushed
the
home-page/for-you
branch
from
46de8a6 to
08777fd
Compare
adamgrzybowski
force-pushed
the
home-page/for-you
branch
from
08777fd to
d54e385
Compare
adamgrzybowski
changed the title
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@codex review |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d54e385540
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b45d2c31bc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const {translate} = useLocalize(); | ||
| const {shouldUseNarrowLayout} = useResponsiveLayout(); | ||
| const [accountID] = useOnyx(ONYXKEYS.SESSION, {canBeMissing: false, selector: accountIDSelector}); | ||
| const [isLoadingApp] = useOnyx(ONYXKEYS.IS_LOADING_APP, {canBeMissing: true}); |
There was a problem hiding this comment.
When ONYXKEYS.IS_LOADING_APP hasn't been hydrated yet (it’s canBeMissing: true), useOnyx returns undefined and the if (isLoadingApp) branch is skipped, so the section renders <EmptyState /> (and possibly the “all caught up” copy) before todos have loaded. This depends on the initial render timing but will cause a visible flicker on app startup and can briefly show “no todos” even when there are some. Consider defaulting isLoadingApp to true (as other components do) or using an Onyx-loading guard to keep the spinner until the value is known.
Useful? React with 👍 / 👎.
|
NAB for this PR 
@Expensify/design the home page components can currently be cut off, with important text below the fold. We may want to consider flex styling vs fixed heights |
mountiny
left a comment
mountiny
left a comment
There was a problem hiding this comment.
Lets address the codex comment
| @@ -0,0 +1,52 @@ | |||
| import React, {useMemo} from 'react'; | |||
| import {View} from 'react-native'; | |||
| import {Fireworks, ThumbsUpStars} from '@components/Icon/Illustrations'; | |||
There was a problem hiding this comment.
Lets use the lazy loading
| ); | ||
| } | ||
|
|
||
| EmptyState.displayName = 'EmptyState'; |
There was a problem hiding this comment.
No need for this
| EmptyState.displayName = 'EmptyState'; |
| import {View} from 'react-native'; | ||
| import ActivityIndicator from '@components/ActivityIndicator'; | ||
| import BaseWidgetItem from '@components/BaseWidgetItem'; | ||
| import {Cash, Export, Send, ThumbsUp} from '@components/Icon/Expensicons'; |
I am not sure if I understand, this really depends on the size of the viewport, I think we should expect the user to scroll down |
mountiny
left a comment
mountiny
left a comment
There was a problem hiding this comment.
Gonna address the small comments in next pr
@mountiny this is what I mean: The For You seems quite large. It should be ~55% width to 45% second column. See this mock where you can see all three: 
Even on a large screen: |
grgia
left a comment
grgia
left a comment
There was a problem hiding this comment.
agree nab on the styling, we can do that when we have the announcements
As I remember, we use 66% and 33% |
|
I see, lets discuss in a follow up |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@grgia I confirmed with @dannymcclain that it should be 1/3 and 2/3 |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.3.11-16 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀
|
Adds detection for statically-known items encoded as data arrays and .map()'d through generic components — a pattern missed during PR Expensify#80829 review. Includes incorrect/correct examples, review metadata conditions, DO NOT flag exceptions for runtime data and list components, and search patterns. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8 participants
Explanation of Change
Implement "For You" section for the new Home Page
Fixed Issues
$ #79979
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
There are two empty states for the for you sections
Make sure to add report types to test if the component filled with content matches the designs as well
Check if every button leads to a proper query in the reports tab
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-01-28.at.16.25.32.mov