Skip to content

fix: the page title does not describe the purpose of page#81150

Merged
yuwenmemon merged 8 commits intoExpensify:mainfrom
daledah:fix/74767
Feb 24, 2026
Merged

fix: the page title does not describe the purpose of page#81150
yuwenmemon merged 8 commits intoExpensify:mainfrom
daledah:fix/74767

Conversation

@daledah
Copy link
Contributor

@daledah daledah commented Feb 2, 2026

Explanation of Change

Fixed Issues

$ #74767
PROPOSAL: #74767 (comment)

Tests

Prerequisite:

  1. User is logged in
  2. Using Chrome, open the URL: https://new.expensify.com/
  3. Activate the "My Settings" button
  4. Activate the "Subscription" menu item
  5. Inspect the code and note the title of the page.
  6. Verify that: The page title should clearly describe the purpose or content of the page to help users understand its context and differentiate it from other open tabs
  • Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native android
Android: mWeb Chrome android
iOS: Native ios
iOS: mWeb Safari ios-mweb
MacOS: Chrome / Safari
web.mov

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/hooks/useDocumentTitle.ts 100.00% <100.00%> (ø)
...s/UnreadIndicatorUpdater/updateUnread/index.ios.ts 66.66% <100.00%> (-33.34%) ⬇️
src/pages/settings/Profile/ProfilePage.tsx 90.90% <100.00%> (+0.11%) ⬆️
...readIndicatorUpdater/updateUnread/index.android.ts 0.00% <0.00%> (ø)
src/pages/TeachersUnite/SaveTheWorldPage.tsx 0.00% <0.00%> (ø)
src/pages/settings/AboutPage/AboutPage.tsx 0.00% <0.00%> (ø)
src/pages/settings/Preferences/PreferencesPage.tsx 0.00% <0.00%> (ø)
src/pages/settings/Rules/ExpenseRulesPage.tsx 0.00% <0.00%> (ø)
...c/pages/settings/Security/SecuritySettingsPage.tsx 0.00% <0.00%> (ø)
...settings/Subscription/SubscriptionSettingsPage.tsx 0.00% <0.00%> (ø)
... and 3 more
... and 44 files with indirect coverage changes

@daledah daledah marked this pull request as ready for review February 2, 2026 09:58
@daledah daledah requested review from a team as code owners February 2, 2026 09:58
@melvin-bot melvin-bot bot requested review from JmillsExpensify and mananjadhav and removed request for a team February 2, 2026 09:58
@melvin-bot
Copy link

melvin-bot bot commented Feb 2, 2026

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team February 2, 2026 09:58
Copy link
Contributor

@JmillsExpensify JmillsExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product review not strictly required.

@mananjadhav
Copy link
Collaborator

@daledah I can see 2 issues when testing.

  1. When I go to the Subscription page, it shows the title fine. But it still shows "Settings Subscription" when I visit Profile or Wallet pages.
  2. There's a small flicker when we do switch the title.
web-page-title-updates.mov

Copy link
Contributor

@yuwenmemon yuwenmemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment here: #74767 (comment)

@mananjadhav
Copy link
Collaborator

@daledah Quick bump.

@daledah
Copy link
Contributor Author

daledah commented Feb 16, 2026

@mananjadhav i just added the useDocumentTitle for other pages in the Account tab. Does this match the expected?
If yes, I will implement it for the entire app.

@yuwenmemon
Copy link
Contributor

@daledah Can you share screenshots?

@daledah
Copy link
Contributor Author

daledah commented Feb 17, 2026

Screen.Recording.2026-02-17.at.16.53.38.mov

@yuwenmemon here is the result

@yuwenmemon
Copy link
Contributor

LGTM 👍

@yuwenmemon
Copy link
Contributor

@mananjadhav, can you give this another pass? We can do the rest of the app in a follow-up PR, so long as we consistently cover the workspace editor in this one.

@mananjadhav
Copy link
Collaborator

mananjadhav commented Feb 21, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android-page-title.mov
Android: mWeb Chrome
mweb-chrome-page-title.mov
iOS: HybridApp
ios-page-title.mov
iOS: mWeb Safari
mweb-safari-page-title.mov
MacOS: Chrome / Safari
web-page-title.mov

Copy link
Collaborator

@mananjadhav mananjadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @yuwenmemon All yours.

@melvin-bot melvin-bot bot requested a review from yuwenmemon February 21, 2026 07:37
@rushatgabhane
Copy link
Member

@MelvinBot implement the review feedback please

@daledah
Copy link
Contributor Author

daledah commented Feb 24, 2026

@yuwenmemon @mananjadhav i updated

@melvin-bot melvin-bot bot requested a review from yuwenmemon February 24, 2026 18:20
Copy link
Contributor

@yuwenmemon yuwenmemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All feedback addressed - getter removed, no repeated comments, hook placement after variable declarations, and clean hook implementation. LGTM!

@yuwenmemon yuwenmemon merged commit b5d082a into Expensify:main Feb 24, 2026
30 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@yuwenmemon
Copy link
Contributor

Follow-up issue is here: #83378

@mananjadhav
Copy link
Collaborator

Thanks for creating the issue. I can help with the review if needed on the issue.

@github-actions
Copy link
Contributor

🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

@yuwenmemon
Copy link
Contributor

@mananjadhav Great - I assigned you here: #83388

@mananjadhav
Copy link
Collaborator

Thanks @yuwenmemon.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.26-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@mitarachim
Copy link

Deploy Blocker #83582 was identified to be related to this PR

aimane-chnaif added a commit to aimane-chnaif/Expensify that referenced this pull request Feb 26, 2026
This reverts commit b5d082a, reversing
changes made to 432aa05.
carlosmiceli added a commit that referenced this pull request Feb 26, 2026
[CP Staging] Revert "Merge pull request #81150 from daledah/fix/74767"
OSBotify pushed a commit that referenced this pull request Feb 26, 2026
[CP Staging] Revert "Merge pull request #81150 from daledah/fix/74767"

(cherry picked from commit cdb8d56)

(cherry-picked to staging by puneetlath)
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.27-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Mar 2, 2026

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.27-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

yuwenmemon added a commit that referenced this pull request Mar 13, 2026
PR #81150 was reverted via #83589, which removed useDocumentTitle
from settings pages and the setPageTitle infrastructure from
updateUnread. This commit re-adds those changes as part of this
PR's overall document title solution.

Pages updated: About, Preferences, Profile, ExpenseRules,
Security, Subscription, Troubleshoot, Wallet, SaveTheWorld.

Co-authored-by: Yuwen Memon <yuwenmemon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants