fix: the page title does not describe the purpose of page#81150
fix: the page title does not describe the purpose of page#81150yuwenmemon merged 8 commits intoExpensify:mainfrom
Conversation
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Product review not strictly required.
|
@daledah I can see 2 issues when testing.
web-page-title-updates.mov |
yuwenmemon
left a comment
There was a problem hiding this comment.
See my comment here: #74767 (comment)
|
@daledah Quick bump. |
|
@mananjadhav i just added the |
|
@daledah Can you share screenshots? |
Screen.Recording.2026-02-17.at.16.53.38.mov@yuwenmemon here is the result |
|
LGTM 👍 |
|
@mananjadhav, can you give this another pass? We can do the rest of the app in a follow-up PR, so long as we consistently cover the workspace editor in this one. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-page-title.movAndroid: mWeb Chromemweb-chrome-page-title.moviOS: HybridAppios-page-title.moviOS: mWeb Safarimweb-safari-page-title.movMacOS: Chrome / Safariweb-page-title.mov |
mananjadhav
left a comment
There was a problem hiding this comment.
LGTM. @yuwenmemon All yours.
|
@MelvinBot implement the review feedback please |
|
@yuwenmemon @mananjadhav i updated |
yuwenmemon
left a comment
There was a problem hiding this comment.
All feedback addressed - getter removed, no repeated comments, hook placement after variable declarations, and clean hook implementation. LGTM!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Follow-up issue is here: #83378 |
|
Thanks for creating the issue. I can help with the review if needed on the issue. |
|
🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@mananjadhav Great - I assigned you here: #83388 |
|
Thanks @yuwenmemon. |
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.26-0 🚀
|
|
Deploy Blocker #83582 was identified to be related to this PR |
[CP Staging] Revert "Merge pull request #81150 from daledah/fix/74767"
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀
|
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.27-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.27-8 🚀
|
PR #81150 was reverted via #83589, which removed useDocumentTitle from settings pages and the setPageTitle infrastructure from updateUnread. This commit re-adds those changes as part of this PR's overall document title solution. Pages updated: About, Preferences, Profile, ExpenseRules, Security, Subscription, Troubleshoot, Wallet, SaveTheWorld. Co-authored-by: Yuwen Memon <yuwenmemon@users.noreply.github.com>
Explanation of Change
Fixed Issues
$ #74767
PROPOSAL: #74767 (comment)
Tests
Prerequisite:
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov