[CP Staging] Revert "Merge pull request #81150 from daledah/fix/74767" by aimane-chnaif · Pull Request #83589 · Expensify/App

aimane-chnaif · 2026-02-26T15:53:50Z

This reverts commit b5d082a, reversing changes made to 432aa05.

Explanation of Change

One conflict happened on TroubleshootPage.tsx.

App/src/pages/settings/Troubleshoot/TroubleshootPage.tsx

Lines 66 to 67 in c230dc5

    
           const {setShouldResetSearchQuery} = useSearchActionsContext(); 
        
           useDocumentTitle(`${translate('common.settings')} - ${translate('initialSettingsPage.aboutPage.troubleshoot')}`);

useSearchContext was just renamed to useSearchActionsContext.
So it's safe change.

Fixed Issues

$ #83582
Context: https://expensify.slack.com/archives/C01GTK53T8Q/p1772120365360629?thread_ts=1772115560.317959&cid=C01GTK53T8Q

Tests

Log in or create a new account and complete onboarding
Navigate to Settings tab
Verify the browser tab title shows "New Expensify"
Navigate to Workspaces tab
Verify the browser tab title resets to "New Expensify"
Navigate to Inbox tab
Verify the browser tab title shows "New Expensify"
Navigate back to Settings tab
Verify the browser tab title shows "New Expensify" again

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-26.at.4.00.43.pm.mov

This reverts commit b5d082a, reversing changes made to 432aa05.

melvin-bot · 2026-02-26T15:54:31Z

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c00be1f969

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/UnreadIndicatorUpdater/updateUnread/index.ts

codecov · 2026-02-26T16:02:30Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...readIndicatorUpdater/updateUnread/index.android.ts	`0.00% <ø> (ø)`
...s/UnreadIndicatorUpdater/updateUnread/index.ios.ts	`100.00% <ø> (ø)`
src/pages/TeachersUnite/SaveTheWorldPage.tsx	`0.00% <ø> (ø)`
src/pages/settings/AboutPage/AboutPage.tsx	`0.00% <ø> (ø)`
src/pages/settings/Preferences/PreferencesPage.tsx	`0.00% <ø> (ø)`
src/pages/settings/Profile/ProfilePage.tsx	`90.78% <ø> (-0.12%)`	⬇️
src/pages/settings/Rules/ExpenseRulesPage.tsx	`0.00% <ø> (ø)`
...c/pages/settings/Security/SecuritySettingsPage.tsx	`0.00% <ø> (ø)`
...settings/Subscription/SubscriptionSettingsPage.tsx	`0.00% <ø> (ø)`
...c/pages/settings/Troubleshoot/TroubleshootPage.tsx	`0.00% <ø> (ø)`
... and 2 more
... and 16 files with indirect coverage changes

carlosmiceli · 2026-02-26T17:25:30Z

@MelvinBot please review.

carlosmiceli · 2026-02-26T17:25:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MelvinBot · 2026-02-26T17:27:57Z

Code Review

This is a cherry-pick to staging that reverts PR #81150 (which introduced page-specific browser tab titles via a useDocumentTitle hook). The revert addresses issue #83582 where the tab name would persist as "Settings - Profile" after navigating to other tabs.

Changes Summary

Area	Change
`src/hooks/useDocumentTitle.ts`	Deleted entirely
`updateUnread/index.ts`	Reverted to use `CONFIG.SITE_TITLE` directly instead of page-specific `currentPageTitle`; removed `setPageTitle` export
`updateUnread/index.android.ts`, `index.ios.ts`	Removed no-op `setPageTitle` stubs
10 settings pages	Removed `useDocumentTitle` import and usage

Review Findings

Revert completeness: The revert is clean and complete. No remaining references to useDocumentTitle or setPageTitle exist anywhere in the codebase.

Conflict resolution: The single conflict in TroubleshootPage.tsx was correctly resolved — useSearchContext was renamed to useSearchActionsContext on main, and the resolution correctly uses the new name while removing the reverted useDocumentTitle line.

Logic correctness: The updateUnread/index.ts properly restores the original behavior: document.title is set to either (count) New Expensify or New Expensify based on unread count, with no page-specific title management.

CI: All checks pass (lint, typecheck, tests, perf-tests, etc.).

No issues found. This is a straightforward and clean revert with a correctly resolved conflict. LGTM.

OSBotify · 2026-02-26T18:01:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-26T18:46:46Z

🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-26T18:51:25Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83589.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-cdb8d56-36323b8-a8e931ed5fda24baad1db7a83d68e87574299e51/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-cdb8d56-36323b8-61af1e83e58804e7c97ec7f1bc4ddf324eb55fb9/index.html

Web 🕸️
https://83589.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

[CP Staging] Revert "Merge pull request #81150 from daledah/fix/74767" (cherry picked from commit cdb8d56) (cherry-picked to staging by puneetlath)

OSBotify · 2026-02-26T20:14:48Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.3.26-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-27T15:00:13Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-27T15:29:02Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.3.27-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-02T22:20:22Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.27-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

PR #81150 was reverted via #83589, which removed useDocumentTitle from settings pages and the setPageTitle infrastructure from updateUnread. This commit re-adds those changes as part of this PR's overall document title solution. Pages updated: About, Preferences, Profile, ExpenseRules, Security, Subscription, Troubleshoot, Wallet, SaveTheWorld. Co-authored-by: Yuwen Memon <yuwenmemon@users.noreply.github.com>

Revert "Merge pull request Expensify#81150 from daledah/fix/74767"

c00be1f

This reverts commit b5d082a, reversing changes made to 432aa05.

aimane-chnaif requested review from a team as code owners February 26, 2026 15:53

melvin-bot bot assigned aimane-chnaif Feb 26, 2026

melvin-bot bot requested review from carlosmiceli and heyjennahay and removed request for a team February 26, 2026 15:53

melvin-bot bot removed the request for review from a team February 26, 2026 15:54

chatgpt-codex-connector bot reviewed Feb 26, 2026

View reviewed changes

src/libs/UnreadIndicatorUpdater/updateUnread/index.ts Show resolved Hide resolved

aimane-chnaif changed the title ~~Revert "Merge pull request #81150 from daledah/fix/74767"~~ [CP Staging] Revert "Merge pull request #81150 from daledah/fix/74767" Feb 26, 2026

aimane-chnaif mentioned this pull request Feb 26, 2026

Fix: useDocumentTitle uses focus events instead of mount lifecycle #83586

Closed

52 tasks

carlosmiceli approved these changes Feb 26, 2026

View reviewed changes

carlosmiceli merged commit cdb8d56 into Expensify:main Feb 26, 2026
33 of 36 checks passed

OSBotify pushed a commit that referenced this pull request Feb 26, 2026

Merge pull request #83589 from aimane-chnaif/fix-83582

e92e196

[CP Staging] Revert "Merge pull request #81150 from daledah/fix/74767" (cherry picked from commit cdb8d56) (cherry-picked to staging by puneetlath)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Feb 26, 2026

OSBotify mentioned this pull request Feb 26, 2026

Deploy Checklist: New Expensify 2026-02-25 #83466

Closed

MelvinBot mentioned this pull request Feb 27, 2026

Extend useDocumentTitle hook to all remaining pages #83388

Merged

52 tasks

MelvinBot mentioned this pull request Mar 12, 2026

[$250] Other A11y: Global: The page title does not describe the purpose of page #74767

Open

	const {setShouldResetSearchQuery} = useSearchActionsContext();
	useDocumentTitle(`${translate('common.settings')} - ${translate('initialSettingsPage.aboutPage.troubleshoot')}`);

Conversation

aimane-chnaif commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov bot commented Feb 26, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

carlosmiceli commented Feb 26, 2026

Uh oh!

carlosmiceli commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Feb 26, 2026

Code Review

Changes Summary

Review Findings

Uh oh!

Uh oh!

OSBotify commented Feb 26, 2026

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

OSBotify commented Feb 26, 2026

Uh oh!

OSBotify commented Feb 27, 2026

Uh oh!

OSBotify commented Feb 27, 2026

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aimane-chnaif commented Feb 26, 2026 •

edited

Loading

codecov bot commented Feb 26, 2026 •

edited by github-actions bot

Loading

carlosmiceli commented Feb 26, 2026 •

edited

Loading