Skip to content

Fix screen reader not announcing updated sign-in error during typing#81935

Closed
marufsharifi wants to merge 4 commits intoExpensify:mainfrom
marufsharifi:fix/a11y-screen-reader-signin-error-announcement
Closed

Fix screen reader not announcing updated sign-in error during typing#81935
marufsharifi wants to merge 4 commits intoExpensify:mainfrom
marufsharifi:fix/a11y-screen-reader-signin-error-announcement

Conversation

@marufsharifi
Copy link
Contributor

@marufsharifi marufsharifi commented Feb 10, 2026

Explanation of Change

When a user is focused in a field and a screen reader is on, updated error text is now announced automatically. Announcements only happen when the error message actually changes, so users get real-time guidance without repeated spam.

Fixed Issues

$ #77257
PROPOSAL: #77257 (comment)

Tests

  • the user is not signed in
  1. Using Android TalkBack or iOS VoiceOver, open the Expensify app
  2. Swipe to the 'Continue' button and double-tap to activate
  3. Note that the error message appeared on the screen
  4. Swipe to the 'Phone or email' input field and start to type.
  5. Note that the error message is updated
  6. Notice that the updated error message is announced.
  • Verify that no errors appear in the JS console

Offline tests

Same as the tests.

QA Steps

Same as the tests.

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android-native-announces-error-changes.mp4
Android: mWeb Chrome
android-web-announcing-error-change.mp4
iOS: Native
Screen.Recording.2026-02-15.at.11.30.56.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-02-12.at.3.51.14.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-12.at.3.55.02.PM.mov

@melvin-bot
Copy link

melvin-bot bot commented Feb 10, 2026

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...nput/BaseTextInput/implementation/index.native.tsx 76.31% <53.33%> (-1.62%) ⬇️
... and 12 files with indirect coverage changes

@marufsharifi marufsharifi marked this pull request as ready for review February 15, 2026 19:05
@marufsharifi marufsharifi requested review from a team as code owners February 15, 2026 19:05
@melvin-bot
Copy link

melvin-bot bot commented Feb 15, 2026

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed request for a team February 15, 2026 19:05
@suneox
Copy link
Contributor

suneox commented Feb 16, 2026

This PR depends on #81679 and is currently waiting on that PR.

Copy link
Contributor

@joekaufmanexpensify joekaufmanexpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine from a product perspective

@suneox
Copy link
Contributor

suneox commented Feb 17, 2026

@marufsharifi This PR can be handled in PR, so we can close this one.

@marufsharifi
Copy link
Contributor Author

@suneox, could you please take a look at this? thanks.

@suneox
Copy link
Contributor

suneox commented Feb 22, 2026

@suneox, could you please take a look at this? thanks.

We need to wait for #81679 because the current code doesn’t work on the Android platform.

@rushatgabhane
Copy link
Member

@MelvinBot merge main please

@rushatgabhane
Copy link
Member

@suneox that PR is merged. Let's get the ball rollin

…-screen-reader-signin-error-announcement

Co-authored-by: Rushat Gabhane <rushatgabhane@users.noreply.github.com>
@MelvinBot
Copy link
Contributor

Done! I've merged main into this branch (commit c17f741).

@marufsharifi
Copy link
Contributor Author

@suneox, kindly bump. thanks.

@suneox
Copy link
Contributor

suneox commented Mar 1, 2026

The current change duplicates the announcement handling already covered by FormHelpMessage, and it has already been resolved in the comment. so we can retest the issue

@rushatgabhane
Copy link
Member

issue not reproducible closing #77257 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants