Fix screen reader not announcing updated sign-in error during typing#81935
Fix screen reader not announcing updated sign-in error during typing#81935marufsharifi wants to merge 4 commits intoExpensify:mainfrom
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
This PR depends on #81679 and is currently waiting on that PR. |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Fine from a product perspective
|
@marufsharifi This PR can be handled in PR, so we can close this one. |
|
@suneox, could you please take a look at this? thanks. |
|
@MelvinBot merge main please |
|
@suneox that PR is merged. Let's get the ball rollin |
…-screen-reader-signin-error-announcement Co-authored-by: Rushat Gabhane <rushatgabhane@users.noreply.github.com>
|
Done! I've merged |
|
@suneox, kindly bump. thanks. |
|
The current change duplicates the announcement handling already covered by FormHelpMessage, and it has already been resolved in the comment. so we can retest the issue |
|
issue not reproducible closing #77257 (comment) |
Explanation of Change
When a user is focused in a field and a screen reader is on, updated error text is now announced automatically. Announcements only happen when the error message actually changes, so users get real-time guidance without repeated spam.
Fixed Issues
$ #77257
PROPOSAL: #77257 (comment)
Tests
Offline tests
Same as the tests.
QA Steps
Same as the tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-native-announces-error-changes.mp4
Android: mWeb Chrome
android-web-announcing-error-change.mp4
iOS: Native
Screen.Recording.2026-02-15.at.11.30.56.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-02-12.at.3.51.14.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-12.at.3.55.02.PM.mov