Fix screen reader error message announcement on multiple pages#81679
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f1ece2b08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
1. On Sign In - Enter Code 1.mp42. Onboarding: all fields in the flow 2.mov3. On Inbox: the field 'Enter your boss's email.' 3.mov4. On Profile - Display Name 4.mov5. On Profile - Date of Birth 5.mov6. On Profile - Address 6.mov7. On Profile - Legal Name 7.mov8. On Profile - Verify Email 8.mov9. On Security - Merge Accounts 9.mov10. On Security - Merge Accounts - Enter Code 10.mov11. On Security - Close Account 11.mov12. On Wallet - Add Bank Account 12.mov13. On Create Expense - Confirm Details 13.mov14. On Save the World - I know a teacher 14.mov15. On Create Workspace 15.mov |
@marufsharifi I see |
@marufsharifi No, I've identified the cause on a real device, as mentioned above. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppscreen-20260221-141343.4.mp4Android: mWeb Chromescreen-20260221-140511.3.mp4iOS: HybridAppScreenRecording_02-21-2026.13-39-23_1.5.mp4iOS: mWeb SafariScreenRecording_02-21-2026.13-57-01_1.6.mp4MacOS: Chrome / SafariCleanShot.2026-02-21.at.14.15.02.1.mp4 |
|
@suneox, I've addressed all your comments. Please take another look. thanks. |
|
@arosiclair, kindly bump. thanks. |
|
🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.3.25-0 🚀
|
|
Hi @marufsharifi. QA team failed this PR with an original issue. The error is not focused and announced 1771901305267.81679.1.mp4az_recorder_20260224_185841.mp4 |
On my Android device it still works as expected, and we haven’t verified it on Windows yet so @marufsharifi, could you check on Android? I'll revalidate on Windows |
|
@IuliiaHerets I re-tested this, and it works as expected on my side. Could you please re-test without screen recording (or with external capture) and confirm? cc @suneox |
|
@marufsharifi asked tester to recheck? |
|
@marufsharifi tester confirmed that PR passed for him in this way eba2019e02667641497b1d0accd8727c.mov |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.25-13 🚀
|
Explanation of Change
Fixed Issues
$ #77572
PROPOSAL: #77572 (comment)
Tests
Offline tests
Same as the tests.
QA Steps
Same as the tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-native-input-error-announcment.mp4
Android: mWeb Chrome
android-web-input-error-announcment.mp4
iOS: Native
Screen.Recording.2026-02-13.at.5.19.34.PM.mov
iOS: mWeb Safari
iosw.mp4
MacOS: Chrome / Safari
web.mp4