Fix - Suggested response button text doesn't wrap correctly in Concierge chat

[jmusial]

Explanation of Change

This pr changes how text is wrapped in followup buttons.

Fixed Issues

$ #81748
PROPOSAL:

Tests

1. Open a workspace in New Expensify that has Concierge suggested responses enabled (beta)
2. Navigate to a page where Concierge shows suggested response buttons (e.g., the onboarding welcome message or after a Concierge response with follow-up suggestions)
3. Observe the suggested response buttons at the bottom of the chat
4. When a suggested response button's text is too long for a single line, the text should wrap to the next line and the button should expand vertically to accommodate the full text.

Offline tests

N/A

QA Steps

Same as tests.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

[melvin-bot]

@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

❌ PERF-1 (docs)

Creating a new array inline within a component rendered by a list's renderItem forces React to treat the styles prop as changed on every render, preventing reconciliation optimizations.

Suggested fix: Define the combined styles array outside the component or memoize it:

// At the top of the component or outside
const conciergeTextStyles = [styles.textAlignLeft, styles.breakWord];

// Then use:
text: [isConciergeOptions || actionContainsFollowUps ? conciergeTextStyles : undefined],

Or use a useMemo:

const textStyles = useMemo(
    () => [isConciergeOptions || actionContainsFollowUps ? [styles.textAlignLeft, styles.breakWord] : undefined],
    [isConciergeOptions, actionContainsFollowUps]
);

// Then use:
styles={{ text: textStyles, ... }}

---

Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

[abzokhattab]

Hi, does this need c+ review?

[jmusial]

I guess but I'd leave final word to @marcochavezf

[marcochavezf]

Yup, we'd still require review @abzokhattab 🙇🏽‍♂️

[abzokhattab]

Open a workspace in New Expensify that has Concierge suggested responses enabled (beta)

can u please invite me to a workspace that have this enabled?

you can use this acc: abzokhattab+dododo@gmail.com

if its not possible to invite me then can u enable it for this workspace: 01EE3CAC620B3220

cc @jmusial @marcochavezf

[jmusial]

Open a workspace in New Expensify that has Concierge suggested responses enabled (beta)

can u please invite me to a workspace that have this enabled?

you can use this acc: abzokhattab+dododo@gmail.com

if its not possible to invite me then can u enable it for this workspace: 01EE3CAC620B3220

cc @jmusial @marcochavezf

you can use any fake email @swmansion.com. No need to receive magic code for this one.

[trjExpensify]

Let's have @Expensify/design review this PR.

[dubielzyk-expensify]

Shall we run a test build?

[abzokhattab]

I'm having some trouble running the iOS build locally. I’ve been troubleshooting for a couple of hours with no luck.

@marcochavezf Could you please trigger an ad-hoc build? It will be faster to run on the ad-hoc build than to spend more time

[github-actions]

🚧 @marcochavezf has triggered a test Expensify/App build. You can view the workflow run here.

[dubielzyk-expensify]

I can't see the new styling? Am I missing something?

[shawnborton]

@dubielzyk-expensify that's a good catch - I have a feeling that feature (from when you create an expense via your personal space) is not the same UI component that is used for the Concierge auto responses... we should align them though.

I am finding it nearly impossible to test the new buttons via other flows though as Concierge constantly categorizes things based on past activity. Any idea how to trigger the buttons reliably?

[jmusial]

I can't see the new styling? Am I missing something?

Yeah, I think we've been talking about doing it in a followup. I can get on it if we have a issue for it :)

[jmusial]

@dubielzyk-expensify that's a good catch - I have a feeling that feature (from when you create an expense via your personal space) is not the same UI component that is used for the Concierge auto responses... we should align them though.

I am finding it nearly impossible to test the new buttons via other flows though as Concierge constantly categorizes things based on past activity. Any idea how to trigger the buttons reliably?

You should be able to get the new ones on the onboarding for a new user that "Manages my team's expenses" and "1-10". Then you should get a welcome message w/ them in the #admins chat.

You may need to use @expensifail or @swmansion domains, but not 100% sure it's still gated to those @marcochavezf ?

[marcochavezf]

yup, the @expensifail.com domain might not wor, instead you can use @dmb.fun and without an + e.g. "testAdmin123@dmb.fun"

[shawnborton]

Hmm not seeing the new styles here:

[abzokhattab]

@jmusial can you please check this comment #82113 (comment)

[jmusial]

@jmusial can you please check this comment #82113 (comment)

Hey @shawnborton yes, no all Concierge response buttons are styled the new way. Right now only actions with follow ups have a new look. The rest is to be changed later in a follow up. Right now the most reliable way of getting them it is to:

1. Create a new account (in either @swmansion.com or @dmb.fun domains. Can be any fake email, you do not need to enter the magic code.)
2. In the onboarding for a new user that "Manages my team's expenses" and "1-10".
3. Get a welcome message w/ follow ups in the #admins chat.

[jmusial]

@Expensify/design just to confirm we're talking just about border-radius . Because stretching items on mobile for short messages do not look great imo

[shawnborton]

Yeah, basically let's reuse this exact same style you have here:

[jmusial]

Some screens on how it looks after update:

Proposing categories

Proposing actions

Adding someone to channel

Asking for a payment

Please let me know if that's ok ?

[shawnborton]

I don't think we want to change these green buttons:

Only the phrasal response buttons. Does that make sense?

Also, cc @Expensify/design for a check on the paddings/etc of the response buttons.

[dannymcclain]

Agree with you about the green buttons. Everything else is looking how I would expect it to though 👍

[dubielzyk-expensify]

Hmm. I can get onboard with not going green, but it feels a bit weird as it's the primary and only action. I guess they're far more visible now anyways so I guess I'm fine with keeping them the regular button color.

[abzokhattab]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

[abzokhattab]

Thanks ... the changes LGTM

[melvin-bot]

We did not find an internal engineer to review this PR, trying to assign a random engineer to #81748 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

[shawnborton]

Hmm. I can get onboard with not going green, but it feels a bit weird as it's the primary and only action. I guess they're far more visible now anyways so I guess I'm fine with keeping them the regular button color.

Ah sorry for the confusion, I was only suggesting that we leave those patterns as they are and only change the style of the phrasal response buttons for now.

[jmusial]

Updated PR, if the button is primary (green) it'll keep the styles as they were

Otherwise changes are as in my comment above

[shawnborton]

Awesome, let's get this into final review then 🚢

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82113.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-0d3105e-20791fb-c03dec79b0a3402e30a90e73d5509d8fc7c4a13d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0d3105e-20791fb-d20eab31b2304b997460feb52978e21573dba888/index.html

Web 🕸️
https://82113.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.22-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	cancelled 🔪
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	failure ❌
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪