Suggested response buttons style update#83048
Conversation
|
@Expensify/design please take a look and confirm that this are all the buttons that are considered |
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@bernhardoj I think this one counts as a regression from #82113 and @abzokhattab should do the review as the reviewer of the OG PR? |
|
The screenshots don't look quite right. I believe the design team landed on making these phrasal response buttons (PRBs!) look similar to product buttons so we don't have the confusion of multiple button shapes. To make this work in practice, this means that each phrasal response button needs to essentially have 20px of border radius with a 40px height. So that as the button grows, we get this effect: CleanShot.2026-02-20.at.15.26.56.mp4
Then the max-width would be the width of the container that it is in. Let me know how that sounds! |
|
cc @Expensify/design for the gut check on that |
Yeah, sorry - totally missed the convo and decision on slack 😢 . cc. @Beamanator we need to update emails as well |
|
@shawnborton that all sounds right to me!
🤣 Hate it and love it and am definitely going to use PRB in Slack/GH from now on 🤣 |
|
Oh I am digging that. Let's see what the rest of the @Expensify/design team thinks! (Also, thank you @jmusial - I know we've messed with these buttons waaaaaaaaaaay more than any of us expected 😅) |
|
Yeah that's looking good to me as well. (I hate the acronym 😂) |
|
In the mobile mock, I would expect the buttons to be hugging like they are in the desktop mock. Can you update that quickly? |
|
Yes, exactly! That's what I think we should do, and this way they are consistent. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
Looks good to me. Do we want to truncate these though or allow them to flow to more lines? I could at least see allowing 3 lines here... maybe that's crazy though! |
|
I think we should let them wrap. It feels so silly to me to present something to the user and then truncate it so they can't see the whole thing haha. We could try 3 lines at least to likely cover most of the bases. |
|
Cool, I say ship it. |
|
Agree with 3 lines. Send it! |
Reviewer Checklist
Screenshots/Videos |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.26-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀
|




















Explanation of Change
This PR is a second version of reverted #82113. DB link
It changes the styles for
phrasal response concierge buttons. (ADDCOMMENTw/ followups,CONCIERGEDESCRIPTIONOPTIONSandCONCIERGECATEGORYOPTIONS).Fixed Issues
$ #81748
PROPOSAL:
N/A
Tests
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Desktop:Mobile:

Super narrow screen (word break):

Whispers:
