[CP Staging] Revert Handle the Distance and Rate fields for splits by ZhenjaHorbach · Pull Request #82147 · Expensify/App

ZhenjaHorbach · 2026-02-11T15:26:38Z

Explanation of Change

Fixed Issues

$ #78891
#82122
#82120
#82119
#82116
#82134
PROPOSAL:

Tests

Open App
Go to workspace chat.
Create a distance expense.
Click More > Split.
Open any split
Verify that there are no rate or distance fields and confirm that the split flow works as expected

Open App
Go to workspace chat.
Create a manual expense.
Click More > Split.
Click Add split.
Click Make splits even.
Click Save.
Select one of the splits via checkbox.
Click dropdown button > Delete.
Delete the split.
Expected Result:
Verify that the remaining split amounts will not show 0.00.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

2026-01-13.13.21.34.mov

codecov · 2026-02-11T15:33:52Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`87.39% <ø> (ø)`
src/components/MoneyRequestHeader.tsx	`0.00% <ø> (ø)`
src/hooks/useSelectedTransactionsActions.ts	`85.22% <ø> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
src/libs/TransactionUtils/index.ts	`83.41% <100.00%> (-0.40%)`	⬇️
src/libs/actions/IOU/index.ts	`73.19% <100.00%> (-1.30%)`	⬇️
src/pages/iou/SplitExpenseCreateDateRagePage.tsx	`0.00% <ø> (ø)`
.../iou/request/step/IOURequestStepDistanceManual.tsx	`0.00% <ø> (ø)`
src/components/MoneyReportHeader.tsx	`0.00% <0.00%> (ø)`
src/pages/Search/SearchPage.tsx	`23.34% <0.00%> (+0.08%)`	⬆️
... and 10 more
... and 86 files with indirect coverage changes

melvin-bot · 2026-02-11T15:57:26Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4c995a8d4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/iou/SplitExpensePage.tsx

Krishna2323 · 2026-02-11T16:14:25Z

Reviewing....

Krishna2323 · 2026-02-11T16:20:37Z

@ZhenjaHorbach Could you please add all the test cases from the blockers?

ZhenjaHorbach · 2026-02-11T16:21:45Z

@ZhenjaHorbach Could you please add all the test cases from the blockers?

I already added
I think these cases will be enough

Krishna2323 · 2026-02-11T16:28:58Z

@ZhenjaHorbach Why weren’t all the changes from src/libs/actions/IOU/index.ts removed?

Monosnap Handle the Distance and Rate fields for splits 2026-02-11 21-57-07

ZhenjaHorbach · 2026-02-11T16:31:44Z

@ZhenjaHorbach Why weren’t all the changes from src/libs/actions/IOU/index.ts removed?

Because after merging my changes, almost all split functions were moved to IOU/Split.ts in another PR
So in this revert PR, I reverted a lot of changes in IOU/Split.ts(which were in the index.ts before)

src/libs/actions/IOU/Split.ts

Krishna2323 · 2026-02-11T16:56:13Z

@ZhenjaHorbach Please resolve the above comments, I'm still reviewing...

src/libs/actions/IOU/Split.ts

ZhenjaHorbach · 2026-02-11T17:13:42Z

Removed unused code!

lakchote · 2026-02-11T17:25:39Z

Removed unused code!

cc @Krishna2323

Krishna2323 · 2026-02-11T17:26:54Z

I'm still reviewing, there are some more comments, will submit in 15 mins.

src/libs/actions/IOU/Split.ts

Krishna2323 · 2026-02-11T17:42:58Z

These are not just unused pieces of code. If they’re not updated or removed, they will likely cause further regressions.

Krishna2323 · 2026-02-11T18:17:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

split_distance_revert.mp4

ZhenjaHorbach · 2026-02-11T18:17:59Z

@lakchote
The same
https://github.com/Expensify/App/actions/runs/21916705354/job/63285768072

Krishna2323

LGTM! 🚀

The lint errors are not coming from this PR.

lakchote

LGTM

lakchote · 2026-02-11T18:27:18Z

Lint and typescript checks failing are not related, see #82147 (comment)

melvin-bot · 2026-02-11T18:28:03Z

@lakchote looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

github-actions · 2026-02-11T18:28:14Z

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

lakchote · 2026-02-11T18:28:48Z

Not an emergency, see #82147 (comment) and https://expensify.slack.com/archives/C01GTK53T8Q/p1770832707076339

github-actions · 2026-02-11T18:31:36Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82147.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e0a6b4e-e7fd5d7065cf1c6be8fe767bbc6cf1d26bbe6aa0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e0a6b4e-86ed1c2dedabf3b5bdf984bc4464f19c84e7496d/index.html

Web 🕸️
https://82147.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-11T18:35:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[CP Staging] Revert Handle the Distance and Rate fields for splits (cherry picked from commit e0a6b4e) (cherry-picked to staging by lakchote)

OSBotify · 2026-02-11T19:19:17Z

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.3.17-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…pr-79099" This reverts commit e0a6b4e, reversing changes made to 9df3d2d.

OSBotify · 2026-02-12T15:26:02Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2026-02-12T15:50:47Z

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.3.18-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-13T18:51:07Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.18-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-25T18:24:34Z

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.3.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

izarutskaya · 2026-02-25T19:03:47Z

Hi @ZhenjaHorbach Do we need to check this?

OSBotify · 2026-02-27T14:55:54Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Revert changes

97e31dd

melvin-bot bot assigned ZhenjaHorbach Feb 11, 2026

lakchote self-requested a review February 11, 2026 15:30

Fix lint issues

c4c995a

ZhenjaHorbach marked this pull request as ready for review February 11, 2026 15:57

ZhenjaHorbach requested review from a team as code owners February 11, 2026 15:57

melvin-bot bot requested review from Krishna2323 and trjExpensify and removed request for a team February 11, 2026 15:57

Return navigation

8094dd7

chatgpt-codex-connector bot reviewed Feb 11, 2026

View reviewed changes

src/pages/iou/SplitExpensePage.tsx Show resolved Hide resolved

Krishna2323 suggested changes Feb 11, 2026

View reviewed changes

src/libs/actions/IOU/Split.ts Outdated Show resolved Hide resolved

src/libs/actions/IOU/Split.ts Outdated Show resolved Hide resolved

src/libs/actions/IOU/Split.ts Outdated Show resolved Hide resolved

ZhenjaHorbach added 2 commits February 11, 2026 18:04

Remove unused code

a012bb6

Remove unused code x2

14dcd9c

Krishna2323 suggested changes Feb 11, 2026

View reviewed changes

src/libs/actions/IOU/Split.ts Show resolved Hide resolved

src/libs/actions/IOU/Split.ts Outdated Show resolved Hide resolved

src/libs/actions/IOU/Split.ts Outdated Show resolved Hide resolved

Krishna2323 approved these changes Feb 11, 2026

View reviewed changes

lakchote approved these changes Feb 11, 2026

View reviewed changes

lakchote changed the title ~~Revert Handle the Distance and Rate fields for splits~~ [CP Staging] Revert Handle the Distance and Rate fields for splits Feb 11, 2026

lakchote merged commit e0a6b4e into Expensify:main Feb 11, 2026
29 of 31 checks passed

melvin-bot bot added the Emergency label Feb 11, 2026

lakchote removed the Emergency label Feb 11, 2026

Julesssss mentioned this pull request Feb 11, 2026

[HOLD] Disable split action for odometer expenses #82159

Closed

53 tasks

OSBotify pushed a commit that referenced this pull request Feb 11, 2026

Merge pull request #82147 from ZhenjaHorbach/revert-pr-79099

49eb51d

[CP Staging] Revert Handle the Distance and Rate fields for splits (cherry picked from commit e0a6b4e) (cherry-picked to staging by lakchote)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Feb 11, 2026

OSBotify mentioned this pull request Feb 11, 2026

Deploy Checklist: New Expensify 2026-02-11 #82079

Closed

Pujan92 mentioned this pull request Feb 12, 2026

[CP Staging] fix: Merchant field is displayed instead of Distance & Rate field after splitting distance with user #82142

Merged

53 tasks

ZhenjaHorbach added a commit to ZhenjaHorbach/App that referenced this pull request Feb 12, 2026

Revert "Merge pull request Expensify#82147 from ZhenjaHorbach/revert-…

70e137d

…pr-79099" This reverts commit e0a6b4e, reversing changes made to 9df3d2d.

melvin-bot bot mentioned this pull request Feb 12, 2026

[Due for payment 2026-03-06] [Due for payment 2026-02-19] [Splits in NewDot] Handle the Distance and Rate fields #78891

Closed

lakchote mentioned this pull request Feb 17, 2026

[Awaiting Payment] Pay C+ for review of PR #82147 #82633

Closed

OSBotify mentioned this pull request Feb 25, 2026

Deploy Checklist: New Expensify 2026-02-25 #83466

Closed

Conversation

ZhenjaHorbach commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 11, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Feb 11, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Krishna2323 commented Feb 11, 2026

Uh oh!

Krishna2323 commented Feb 11, 2026

Uh oh!

ZhenjaHorbach commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Krishna2323 commented Feb 11, 2026

Uh oh!

ZhenjaHorbach commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Krishna2323 commented Feb 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ZhenjaHorbach commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lakchote commented Feb 11, 2026

Uh oh!

Krishna2323 commented Feb 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Krishna2323 commented Feb 11, 2026

Uh oh!

Krishna2323 commented Feb 11, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Feb 11, 2026

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

lakchote commented Feb 11, 2026

Uh oh!

Uh oh!

melvin-bot bot commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

lakchote commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

OSBotify commented Feb 11, 2026

ZhenjaHorbach commented Feb 11, 2026 •

edited

Loading

codecov bot commented Feb 11, 2026 •

edited by github-actions bot

Loading

ZhenjaHorbach commented Feb 11, 2026 •

edited

Loading

ZhenjaHorbach commented Feb 11, 2026 •

edited

Loading

ZhenjaHorbach commented Feb 11, 2026 •

edited

Loading