[Onyx audit] Migrate keys to RAM-only - part 1/2 by JKobrynski · Pull Request #82309 · Expensify/App

JKobrynski · 2026-02-12T19:36:49Z

Explanation of Change

This PR is part 1/2 of RAM-only migration - it migrates the obvious keys.

Fixed Issues

$ #80091
PROPOSAL: N/A

Tests

1. App Launch & Deep Linking (`IS_CHECKING_PUBLIC_ROOM`)

Launch the app and confirm the splash screen disappears and you land on the home screen without hanging
Open a deep link to a public room while logged out (e.g. a shared report link) — confirm the app correctly navigates to the public room or shows the sign-in page
Open a deep link to a public room while logged in — confirm you are taken directly to the report
Open a deep link to a private room while logged out — confirm you are redirected to the sign-in page
Kill and restart the app, then repeat steps 1–4 to verify no stale state persists across restarts

2. App Update Modals (`UPDATE_AVAILABLE`, `UPDATE_REQUIRED`)

It's difficult to test these, as the related actions are only triggered by API

Make sure no "Update required"/"Update available" modal is shown by mistake when launching the app

3. Search / User Selection Loading States (`IS_SEARCHING_FOR_REPORTS`)

New Chat

Go to New Chat (+ button > New Chat), type a search term in the search field — confirm a loading indicator appears while results are being fetched from the server and disappears once results load

Money Request (Expense) Participant Selector

Start creating a new expense (Request Money / Split Expense), and in the participant selector search for a user — confirm the loading indicator appears during server search
Confirm the results load correctly and you can select a participant

Workspace Invite

Go to a Workspace > Members > Invite, search for a user to invite — confirm the loading spinner appears during the search and results load

Search Router

Open the global Search (magnifying glass icon), type a query — confirm loading indicator appears and search results populate

4. Wallet / Onfido Identity Verification (`WALLET_ONFIDO`)

Go to Settings > Wallet > Enable Payments and start the wallet activation flow
When you reach the Onfido step, confirm the privacy policy screen appears first (not stale data from a previous attempt)
Accept the privacy policy — confirm a loading indicator shows while the Onfido SDK token is being fetched
If identity verification fails, confirm the error is displayed and you are sent back to the privacy policy screen on retry
Navigate away from the Onfido flow and then navigate back — confirm the flow restarts cleanly (the privacy policy screen shows again, not stale SDK data)
Kill and restart the app, then go back to the Onfido flow — confirm no stale wallet/onfido data persists

5. General Regression Checks

Confirm the app works correctly offline — toggle airplane mode, navigate around, and confirm no crashes related to these keys
Confirm logging out and logging back in works without issues (no stale RAM-only key state leaking across sessions)
Confirm there are no console errors or warnings related to Onyx keys on app startup

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests section above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web-compressed.mov

codecov · 2026-02-12T19:45:11Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.54% <ø> (ø)`
src/Expensify.tsx	`88.13% <100.00%> (ø)`
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
...ponents/BaseVacationDelegateSelectionComponent.tsx	`0.00% <ø> (ø)`
...ponents/Search/FilterDropdowns/UserSelectPopup.tsx	`2.63% <ø> (+0.06%)`	⬆️
...c/components/Search/SearchFiltersChatsSelector.tsx	`0.00% <ø> (ø)`
...rc/components/Search/SearchRouter/SearchRouter.tsx	`40.98% <ø> (-0.96%)`	⬇️
src/libs/actions/App.ts	`46.94% <ø> (ø)`
src/libs/actions/QueuedOnyxUpdates.ts	`100.00% <ø> (ø)`
src/pages/EnablePayments/OnfidoStep.tsx	`0.00% <ø> (ø)`
... and 23 more
... and 133 files with indirect coverage changes

…ly-part-1

The submodule update was unintentionally included and is unrelated to the RAM-only keys migration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…ly-part-1

src/libs/migrations/RemoveRamOnlyKeysFromStorage.ts

…-migrate-keys-to-ram-only-part-1

…ly-part-1

…91-migrate-keys-to-ram-only-part-1

melvin-bot · 2026-03-02T14:14:48Z

@Krishna2323 @roryabraham One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2026-03-02T14:18:24Z

I’ll be reviewing this shortly.

Krishna2323 · 2026-03-13T11:22:55Z

Works well 🎉

fix_part_1.mp4

fix_part_2.mp4

Krishna2323 · 2026-03-13T11:26:10Z

@JKobrynski Is there anything left? I tried checking for similar cases but found that it shouldn’t happen anywhere else.

Here's what I found. Beyond the NavigationRoot issue we already fixed, there are a few other places with similar one-time-computation patterns, but none of them have the same cold-start severity:

Already fixed (the critical one):

NavigationRoot.tsx lines 104-142 -- useMemo(() => ..., []) reads initialUrl once. This is the bug we fixed by gating NavigationRoot mounting on initialUrl !== undefined.

Other patterns found but low/no risk:

useInitialValue hook (src/hooks/useInitialValue.ts) -- Used in TimezoneSelectPage.tsx to compute timezone list once. It reads timezone.selected from personal details on first render. If personal details load late, isSelected could be wrong. But this is a settings page (not cold start), and the user navigates there manually -- by that time Onyx data is always loaded. No risk.

WorkspaceOwnerRestrictedAction (index.native.tsx line 22) -- useMemo(() => Navigation.getActiveRoute(), []) freezes the active route. But this component only renders when a user navigates to it (never on cold start), so the navigation state is always ready. No risk.

MapView components -- These have initialState in their useMemo deps (not empty), so they recompute when props change. No risk.

SignInModal.tsx -- useMemo(() => isMobileSafari(), []) -- purely synchronous platform check. No risk.

InitialURLContextProvider -- Calls Linking.getInitialURL() but uses useState/setInitialURL (not useMemo), so it updates correctly when the promise resolves. No risk.

SplitRouter.ts -- getInitialState reads preserved navigator state. It already has a guard checking navigationRef.isReady(). Low risk.

Bottom line: The cold-start race condition was unique to the NavigationRoot + DeepLinkHandler + Expensify interaction. No other code in the codebase has this same pattern of gating a component that reads an async value only once on mount during cold start. The author's fix is sufficient.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e9b00ca33

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-13T11:39:51Z

src/DeepLinkHandler.tsx

+        Promise.race([
+            Linking.getInitialURL(),
+            new Promise<null>((resolve) => {
+                setTimeout(() => resolve(null), CONST.TIMING.GET_INITIAL_URL_TIMEOUT);
+            }),


Handle late getInitialURL resolution after timeout

Racing Linking.getInitialURL() against a 10s null timeout unblocks startup, but it also permanently drops deep links when the native bridge returns the initial URL after that timeout (a case this comment already calls out in HybridApp). Once the timeout wins, onInitialUrl(null) runs and the eventual URL resolution is ignored, so users can land on the default route instead of the intended deep-linked report on slower/lagging startup paths.

Useful? React with 👍 / 👎.

@Krishna2323 do you have any thoughts on this ☝️ ?

Not a practical concern. getInitialURL() resolves in milliseconds (it's a synchronous native read). The 10s timeout would only fire if the native bridge is broken, in which case the URL is unavailable anyway. Without the timeout, a broken bridge would leave the app stuck on the splash screen forever -- so this seems to be the right tradeoff.

JKobrynski · 2026-03-13T14:11:35Z

Is there anything left? I tried checking for similar cases but found that it shouldn’t happen anywhere else.

These are just some suggestions for further investigation on similar cases, and potential improvements to consider!

Krishna2323 · 2026-03-13T16:15:18Z

I'm going to share more details about my investigation in the issue but I think we can test this PR again.

@JKobrynski I was asking about this :)

JKobrynski · 2026-03-13T17:28:30Z

@Krishna2323 posted on the issue yesterday!

Krishna2323 · 2026-03-16T07:09:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: HybridApp

test_1.mp4

test_2.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

loader_test.mp4

onfido_test.mp4

Krishna2323 · 2026-03-16T07:13:25Z

@JKobrynski could you please check the failing tests?

JKobrynski · 2026-03-16T08:43:32Z

@Krishna2323 on it

…-migrate-keys-to-ram-only-part-1

JKobrynski · 2026-03-16T14:11:30Z

@Krishna2323 I updated the branch with the latest main and the test started passing locally, let's see if CI follows

JKobrynski · 2026-03-16T15:15:54Z

@Krishna2323 all green now!

Krishna2323

LGTM and works well! 🚀

mountiny · 2026-03-16T20:36:19Z

Dang there are confclits now @JKobrynski

…91-migrate-keys-to-ram-only-part-1

JKobrynski · 2026-03-16T20:48:03Z

@mountiny conflicts resolved 🫡

github-actions · 2026-03-16T22:16:40Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-03-16T22:19:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-16T22:21:28Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82309.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f1fabc9-03346cd-6e767c9c7e5e45305f3fabe687886df6dead7db1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f1fabc9-03346cd-17cb72b46ff698009f95e6deec623d99527dd40a/index.html

Web 🕸️
https://82309.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-17T11:54:38Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.39-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T13:01:44Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.39-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

JKobrynski added 2 commits February 12, 2026 20:30

add ramOnlyKeys param to Onyx.init, remove initWithStoredValues

44aa890

remove initWithStoredValues: true

4436a4f

melvin-bot bot assigned JKobrynski Feb 12, 2026

JKobrynski mentioned this pull request Feb 12, 2026

[Due for payment 2026-03-11] [Due for payment 2026-02-19] [Onyx Audit] Remove initWithStoredValues from useOnyx #80091

Open

JKobrynski and others added 6 commits February 13, 2026 13:02

Merge branch 'main' into JKobrynski/feat/80091-migrate-keys-to-ram-on…

8b95a3a

…ly-part-1

add onyx migration for ram-only keys

fe16418

revert accidental Mobile-Expensify submodule pointer change

b58c765

The submodule update was unintentionally included and is unrelated to the RAM-only keys migration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix canBeMissing for IS_SEARCHING_FOR_REPORTS to true

6844562

Merge branch 'main' into JKobrynski/feat/80091-migrate-keys-to-ram-on…

de91bc0

…ly-part-1

fix typo in migration log message

d4c0ac6

fabioh8010 reviewed Feb 16, 2026

View reviewed changes

address review comments

626d598

JKobrynski requested a review from fabioh8010 February 16, 2026 09:04

Merge remote-tracking branch 'origin/main' into JKobrynski/feat/80091…

93bd301

…-migrate-keys-to-ram-only-part-1

fabioh8010 mentioned this pull request Feb 27, 2026

[Tracking] Onyx Improvements #80355

Open

JKobrynski added 4 commits March 2, 2026 08:40

Merge branch 'main' into JKobrynski/feat/80091-migrate-keys-to-ram-on…

4a8d2dc

…ly-part-1

remove ram-only onyx migration

2ce3734

Merge branch 'main' into JKobrynski/feat/80091-migrate-keys-to-ram-on…

97a936f

…ly-part-1

Merge remote-tracking branch 'upstream/main' into JKobrynski/feat/800…

d6f1594

…91-migrate-keys-to-ram-only-part-1

JKobrynski marked this pull request as ready for review March 2, 2026 14:14

JKobrynski requested review from a team as code owners March 2, 2026 14:14

melvin-bot bot requested review from Krishna2323, joekaufmanexpensify and roryabraham and removed request for a team March 2, 2026 14:14

melvin-bot bot removed the request for review from a team March 2, 2026 14:14

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into JKobrynski/feat/80091…

410724a

…-migrate-keys-to-ram-only-part-1

lint, fix tests

69b7431

Krishna2323 approved these changes Mar 16, 2026

View reviewed changes

melvin-bot bot requested a review from roryabraham March 16, 2026 15:17

Merge remote-tracking branch 'upstream/main' into JKobrynski/feat/800…

33da95e

…91-migrate-keys-to-ram-only-part-1

mountiny approved these changes Mar 16, 2026

View reviewed changes

mountiny merged commit f1fabc9 into Expensify:main Mar 16, 2026
37 of 38 checks passed

OSBotify mentioned this pull request Mar 17, 2026

Deploy Checklist: New Expensify 2026-03-17 #85529

Closed

75 tasks

mountiny mentioned this pull request Mar 17, 2026

[CP Staging] Revert "[Onyx audit] Migrate keys to RAM-only - part 1/2" #85555

Merged

vincdargento mentioned this pull request Mar 17, 2026

[Exploratory] Workspace - Members list appears empty when opened offline #85606

Open

7 tasks

This was referenced Mar 20, 2026

[Onyx audit] Migrate keys to RAM-only - part 1/2 (including bugfix) #85963

Closed

[Onyx audit] Migrate keys to RAM-only - part 1/2 (including bugfix) #85980

Open

Conversation

JKobrynski commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

1. App Launch & Deep Linking (IS_CHECKING_PUBLIC_ROOM)

2. App Update Modals (UPDATE_AVAILABLE, UPDATE_REQUIRED)

3. Search / User Selection Loading States (IS_SEARCHING_FOR_REPORTS)

4. Wallet / Onfido Identity Verification (WALLET_ONFIDO)

5. General Regression Checks

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 12, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

melvin-bot bot commented Mar 2, 2026

Uh oh!

Krishna2323 commented Mar 2, 2026

Uh oh!

Krishna2323 commented Mar 13, 2026

Uh oh!

Krishna2323 commented Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

JKobrynski Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

JKobrynski commented Mar 13, 2026

Uh oh!

Krishna2323 commented Mar 13, 2026

Uh oh!

JKobrynski commented Mar 13, 2026

Uh oh!

Krishna2323 commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented Mar 16, 2026

Uh oh!

JKobrynski commented Mar 16, 2026

Uh oh!

JKobrynski commented Mar 16, 2026

Uh oh!

JKobrynski commented Mar 16, 2026

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Mar 16, 2026

Uh oh!

JKobrynski commented Mar 16, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

JKobrynski commented Feb 12, 2026 •

edited

Loading

1. App Launch & Deep Linking (`IS_CHECKING_PUBLIC_ROOM`)

2. App Update Modals (`UPDATE_AVAILABLE`, `UPDATE_REQUIRED`)

3. Search / User Selection Loading States (`IS_SEARCHING_FOR_REPORTS`)

4. Wallet / Onfido Identity Verification (`WALLET_ONFIDO`)

codecov bot commented Feb 12, 2026 •

edited by github-actions bot

Loading

Krishna2323 commented Mar 16, 2026 •

edited

Loading