RevertSplitTransaction fails with UNIQUE constraint: App reuses existing reportActionID instead of generating a new one by ZhenjaHorbach · Pull Request #82315 · Expensify/App

ZhenjaHorbach · 2026-02-12T20:20:53Z

Explanation of Change

Fixed Issues

$ #81994
PROPOSAL:

Tests

Open App
Create a workspace expense
Press More button and choose Split
On the splits screen, press save to create a few splits
After creating splits, open any split and in More menu, press Edit split
On the splits screen remove all splits except one
Press Save
Verify that the split reverting was successful without any issues

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

2026-02-13.13.04.29.mov

melvin-bot · 2026-02-13T12:11:21Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JmillsExpensify

All looks good from a product perspective.

ahmedGaber93 · 2026-02-15T17:22:27Z

CC @lakchote for review. Please let me know if this PR requires a C+ review.

mountiny · 2026-02-15T21:24:54Z

@ahmedGaber93 yes please can you test it?

ahmedGaber93 · 2026-02-15T22:07:56Z

@mountiny @ZhenjaHorbach I’m unable to reproduce the main issue on staging.

According to the issue OP:

The user sees "An unexpected error occurred, please try again" and cannot revert their split.

On my end, reverting the split works as expected on staging. Am I missing any specific steps or conditions to reproduce it?

20260215235900365.mp4

ZhenjaHorbach · 2026-02-15T22:12:57Z

@mountiny @ZhenjaHorbach I’m unable to reproduce the main issue on staging.

According to the issue OP:

The user sees "An unexpected error occurred, please try again" and cannot revert their split.

On my end, reverting the split works as expected on staging. Am I missing any specific steps or conditions to reproduce it?

20260215235900365.mp4

The same
I think in this PR it is enough to make sure that we haven't broken anything, and we pass the random reportActionID to BE after reverting splits to prevent the BE issue from description

ahmedGaber93 · 2026-02-15T22:25:26Z

I think in this PR it is enough to make sure that we haven't broken anything, and we pass the random reportActionID to BE after reverting splits to prevent the BE issue from description

For that it works well, nothing have broken.

But do we send the updated currentReportActionID to BE @ZhenjaHorbach?, It looks here we don't send it.

App/src/libs/actions/IOU/Split.ts

Lines 1452 to 1458 in 412f158

if (isReverseSplitOperation) {

const parameters = {

...splits.at(0),

comment: splits.at(0)?.comment?.comment,

} as RevertSplitTransactionParams;

API.write(WRITE_COMMANDS.REVERT_SPLIT_TRANSACTION, parameters, onyxData);

} else {

ZhenjaHorbach · 2026-02-15T22:30:12Z

I think in this PR it is enough to make sure that we haven't broken anything, and we pass the random reportActionID to BE after reverting splits to prevent the BE issue from description

For that it works well, nothing have broken.

But do we send the updated currentReportActionID to BE @ZhenjaHorbach?, It looks here we don't send it.

App/src/libs/actions/IOU/Split.ts

Lines 1452 to 1458 in 412f158

if (isReverseSplitOperation) {

const parameters = {

...splits.at(0),

comment: splits.at(0)?.comment?.comment,

} as RevertSplitTransactionParams;

API.write(WRITE_COMMANDS.REVERT_SPLIT_TRANSACTION, parameters, onyxData);

} else {

We are adding splitReportActionID here

App/src/libs/actions/IOU/Split.ts

Lines 1300 to 1304 in 5d42cd8

    
           if (currentSplit) { 
        
               currentSplit.transactionThreadReportID = transactionThreadReportID; 
        
               currentSplit.createdReportActionIDForThread = createdReportActionIDForThread; 
        
               currentSplit.splitReportActionID = iouAction.reportActionID; 
        
           }

And then just pass to BE using the spread operator

App/src/libs/actions/IOU/Split.ts

Line 1454 in 5d42cd8

...splits.at(0),

ahmedGaber93 · 2026-02-15T22:49:14Z

Ahhh, I see that.

ahmedGaber93 · 2026-02-15T22:52:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

20260216001344018.mp4

ahmedGaber93

@mountiny @lakchote The OP solution has been implemented correctly, we now send a unique splitReportActionID to the BE. I’ve tested it and everything is working as expected, and nothing appears to be broken.

That said, we’re still unable to reproduce the original issue on staging to fully confirm it’s resolved.

If needed, we can shift focus back to reproducing it.

All yours!

lakchote

LGTM

OSBotify · 2026-02-16T10:26:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-16T10:51:52Z

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-16T10:55:46Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82315.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-5ec34f546359eea9daecff00aa25e7e699244de2-68566d4e55b4a83bb3d65d9a1f621c40ee06eb6c/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-5ec34f546359eea9daecff00aa25e7e699244de2-72541de1b3fb578bf593834418d4dc48024a7735/index.html

Web 🕸️
https://82315.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-16T15:51:00Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.3.20-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-17T23:48:09Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.20-6 🚀

platform	result
🕸 web 🕸	cancelled 🔪
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-17T23:59:15Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.20-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

Add changes for RevertSplitTransaction fails with UNIQUE constraint

c63111b

melvin-bot bot assigned ZhenjaHorbach Feb 12, 2026

ZhenjaHorbach marked this pull request as ready for review February 13, 2026 12:11

ZhenjaHorbach requested review from a team as code owners February 13, 2026 12:11

melvin-bot bot requested review from JmillsExpensify and ahmedGaber93 and removed request for a team February 13, 2026 12:11

melvin-bot bot removed the request for review from a team February 13, 2026 12:11

JmillsExpensify approved these changes Feb 13, 2026

View reviewed changes

mountiny requested a review from lakchote February 15, 2026 21:24

ahmedGaber93 approved these changes Feb 15, 2026

View reviewed changes

lakchote approved these changes Feb 16, 2026

View reviewed changes

lakchote merged commit 5ec34f5 into Expensify:main Feb 16, 2026
33 of 87 checks passed

OSBotify mentioned this pull request Feb 16, 2026

Deploy Checklist: New Expensify 2026-02-16 #82567

Closed

51 tasks

nlemma mentioned this pull request Feb 16, 2026

Expense-Split reverting was not successful for expense with negative amount. #82575

Open

7 tasks

OSBotify mentioned this pull request Feb 17, 2026

[Due for payment 2026-03-23] [$250] Android - Report - App crashes after splitting an expense and deleting one split offline. #82611

Closed

7 tasks

mountiny mentioned this pull request Feb 17, 2026

[CP Staging] Revert "RevertSplitTransaction fails with UNIQUE constraint: App reuses existing reportActionID instead of generating a new one" #82713

Merged

51 tasks

Conversation

ZhenjaHorbach commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 13, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 commented Feb 15, 2026

Uh oh!

mountiny commented Feb 15, 2026

Uh oh!

ahmedGaber93 commented Feb 15, 2026

Uh oh!

ZhenjaHorbach commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmedGaber93 commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmedGaber93 commented Feb 15, 2026

Uh oh!

ahmedGaber93 commented Feb 15, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

ahmedGaber93 left a comment

Choose a reason for hiding this comment

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

OSBotify commented Feb 16, 2026

Uh oh!

OSBotify commented Feb 17, 2026

Uh oh!

OSBotify commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ZhenjaHorbach commented Feb 12, 2026 •

edited

Loading

ZhenjaHorbach commented Feb 15, 2026 •

edited

Loading

ahmedGaber93 commented Feb 15, 2026 •

edited

Loading

ZhenjaHorbach commented Feb 15, 2026 •

edited

Loading