Conversation
…es existing reportActionID instead of generating a new one"
melvin-bot
bot
requested review from
joekaufmanexpensify and
sobitneupane
and removed request for
a team
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
francoisl
approved these changes
Feb 17, 2026
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
francoisl
deleted the
revert-82315-fix-revertSplitTransaction-fails-with-unique-constraint
branch
|
@francoisl looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Contributor
|
Straight revert, not an emergency |
Contributor
|
🚧 @francoisl has triggered a test Expensify/App build. You can view the workflow run here. |
OSBotify
pushed a commit
that referenced
this pull request
Feb 17, 2026
…Transaction-fails-with-unique-constraint [CP Staging] Revert "RevertSplitTransaction fails with UNIQUE constraint: App reuses existing reportActionID instead of generating a new one" (cherry picked from commit e8b0e81) (cherry-picked to staging by mountiny)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c824f2c779
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| newNonReimbursableTotal: (transactionReport?.nonReimbursableTotal ?? 0) - changesInReportTotal, | ||
| isSplitExpense: true, | ||
| currentReportActionID: !isReverseSplitOperation ? currentReportAction?.reportActionID : undefined, | ||
| currentReportActionID: currentReportAction?.reportActionID, |
There was a problem hiding this comment.
When isReverseSplitOperation is true, this now forwards currentReportAction?.reportActionID into getMoneyRequestInformation, which makes the optimistic IOU action reuse an ID that already exists on the original split action. That reused ID is then propagated as splitReportActionID for REVERT_SPLIT_TRANSACTION, so reverse-splitting can hit a duplicate report-action insert (UNIQUE constraint) and fail instead of completing.
Useful? React with 👍 / 👎.
51 tasks
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.20-6 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.20-6 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.20-6 🚀
|
Contributor
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.21-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.21-4 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #82315
Fixed issues
$ #82611
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari